)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66e4a2debce95c3428a1980907aa4e9917b69de8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes it easier to tell which cell a result came from when"},{"line_number":10,"context_line":"we are merging results from multiple cells."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0631aad1f4d2ce8b786cae74de16d7dd6e3b1411"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_1aa7b2bf","line":11,"updated":"2018-08-22 19:50:32.000000000","message":"nit: I would expect some kind of, \"This will be used when...\".","commit_id":"1479c8a4b3f2b6db4e1eef6a702a71a87fb33ecd"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e2d7e7493418468c83582cf5eb1b8cbe3d31d4ae","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Implementing __lt__ is enough for heapq.merge() to do its work."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    def __init__(self, ctx, sort_ctx, db_record):"},{"line_number":59,"context_line":"        self._ctx \u003d ctx"},{"line_number":60,"context_line":"        self._sort_ctx \u003d sort_ctx"},{"line_number":61,"context_line":"        self._db_record \u003d db_record"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_af34544b","line":58,"updated":"2018-08-22 08:12:18.000000000","message":"https://github.com/openstack/nova/blob/571928c/nova/tests/unit/compute/test_instance_list.py#L148\n\nThis is also need change","commit_id":"202ea7d178b115f58242ffa44050faeae9633a05"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b72c9d7f447f4453fb6f7bb458ee79b4e6bd84ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Implementing __lt__ is enough for heapq.merge() to do its work."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    def __init__(self, ctx, sort_ctx, db_record):"},{"line_number":59,"context_line":"        self._ctx \u003d ctx"},{"line_number":60,"context_line":"        self._sort_ctx \u003d sort_ctx"},{"line_number":61,"context_line":"        self._db_record \u003d db_record"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4ab24796","line":58,"in_reply_to":"3f79a3b5_af34544b","updated":"2018-08-22 14:09:26.000000000","message":"Indeed, thanks :)","commit_id":"202ea7d178b115f58242ffa44050faeae9633a05"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66e4a2debce95c3428a1980907aa4e9917b69de8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    Implementing __lt__ is enough for heapq.merge() to do its work."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    def __init__(self, ctx, sort_ctx, db_record):"},{"line_number":59,"context_line":"        self._ctx \u003d ctx"},{"line_number":60,"context_line":"        self._sort_ctx \u003d sort_ctx"},{"line_number":61,"context_line":"        self._db_record \u003d db_record"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3a186e1c","line":59,"updated":"2018-08-22 19:50:32.000000000","message":"Should we deepcopy this for any reason? I just get nervous about stashing context on stuff. How does ovo handle this for versioned objects, like an Instance, once targeted to a cell?\n\n(later)\n\nLooks like ovo doesn\u0027t really care, it just sets it and uses it when necessary, no copying or anything.\n\nAnd these RecordWrappers are per result from the DB? So we could have at most, by default, a 1000 of them in memory while listing? Same can be said for Instance objects so again, maybe doesn\u0027t matter. I\u0027d just prefer to pull the fields we need off the RequestContext rather than store the whole object.","commit_id":"1479c8a4b3f2b6db4e1eef6a702a71a87fb33ecd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5cd36a136f5fbde4777f78dc1cadb4ebd8f80b2d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    Implementing __lt__ is enough for heapq.merge() to do its work."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    def __init__(self, ctx, sort_ctx, db_record):"},{"line_number":59,"context_line":"        self._ctx \u003d ctx"},{"line_number":60,"context_line":"        self._sort_ctx \u003d sort_ctx"},{"line_number":61,"context_line":"        self._db_record \u003d db_record"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b5efaf1b","line":59,"in_reply_to":"3f79a3b5_3a186e1c","updated":"2018-08-22 20:20:10.000000000","message":"I\u0027ve gotten to at least the patch that uses the cell_uuid from this, so can we just not store the entire RequestContext object in RecordWrapper and just store off the cell_uuid? Since I don\u0027t see anything needing any other fields off self._ctx.","commit_id":"1479c8a4b3f2b6db4e1eef6a702a71a87fb33ecd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"614b1f90574900956670c364385c03609af9bbd9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    Implementing __lt__ is enough for heapq.merge() to do its work."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    def __init__(self, ctx, sort_ctx, db_record):"},{"line_number":59,"context_line":"        self._ctx \u003d ctx"},{"line_number":60,"context_line":"        self._sort_ctx \u003d sort_ctx"},{"line_number":61,"context_line":"        self._db_record \u003d db_record"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_55c3bb57","line":59,"in_reply_to":"3f79a3b5_b5efaf1b","updated":"2018-08-22 20:37:28.000000000","message":"We can. It\u0027s less memory to store a reference to a single object than what it takes to store a uuid-sized string, so don\u0027t think there is a concern about how many of these we\u0027re storing.","commit_id":"1479c8a4b3f2b6db4e1eef6a702a71a87fb33ecd"}]}