)]}'
{"nova/compute/migration_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4199a85cd39b1604ea643c1d2adcae31a0da12b4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        results \u003d context.scatter_gather_skip_cell0("},{"line_number":57,"context_line":"            ctx, db.migration_get_by_uuid, marker)"},{"line_number":58,"context_line":"        db_migration \u003d None"},{"line_number":59,"context_line":"        cell_uuid \u003d None"},{"line_number":60,"context_line":"        for result_cell_uuid, result in results.items():"},{"line_number":61,"context_line":"            if result not in (context.did_not_respond_sentinel,"},{"line_number":62,"context_line":"                              context.raised_exception_sentinel):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4ffbf945","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":24},"updated":"2018-08-24 14:57:11.000000000","message":"Isn\u0027t this redundant? Meaning, if we break the loop, result_cell_uuid is already set and the one we return. If we don\u0027t break the loop, we raise MarkerNotFound anyway so don\u0027t care.","commit_id":"3862ebab3b0769104cd05ed0d0130c609bbcf748"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33af1aa53bdf05c7ba4949e4481d5bda8eb7516b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            if result not in (context.did_not_respond_sentinel,"},{"line_number":61,"context_line":"                              context.raised_exception_sentinel):"},{"line_number":62,"context_line":"                db_migration \u003d result"},{"line_number":63,"context_line":"                cell_uuid \u003d result_cell_uuid"},{"line_number":64,"context_line":"                break"},{"line_number":65,"context_line":"        if not db_migration:"},{"line_number":66,"context_line":"            raise exception.MarkerNotFound(marker\u003dmarker)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_e79f814d","line":63,"updated":"2018-08-24 20:57:02.000000000","message":"nit: remove this and just return result_cell_uuid","commit_id":"393b588ce529239a776d21a42d1f6ba170ed012d"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4199a85cd39b1604ea643c1d2adcae31a0da12b4","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @abc.abstractmethod"},{"line_number":167,"context_line":"    def get_marker_record(self, ctx, marker_id):"},{"line_number":168,"context_line":"        \"\"\"Get the cell and instance of the marker record by id."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        This needs to look up the marker record in whatever cell it is in"},{"line_number":171,"context_line":"        and return it. It should be populated with values corresponding to"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0f9741ee","line":168,"range":{"start_line":168,"start_character":19,"end_line":168,"end_character":23},"updated":"2018-08-24 14:57:11.000000000","message":"cell uuid","commit_id":"3862ebab3b0769104cd05ed0d0130c609bbcf748"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4199a85cd39b1604ea643c1d2adcae31a0da12b4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        :param ctx: A RequestContext"},{"line_number":175,"context_line":"        :param marker_id: The identifier of the marker to find"},{"line_number":176,"context_line":"        :returns: A tuple of cell_uuid where the marker was found and an"},{"line_number":177,"context_line":"        instance of the marker from the database"},{"line_number":178,"context_line":"        :raises: MarkerNotFound if the marker does not exist"},{"line_number":179,"context_line":"        \"\"\""},{"line_number":180,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2f9a3d13","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":17},"updated":"2018-08-24 14:57:11.000000000","message":"indent","commit_id":"3862ebab3b0769104cd05ed0d0130c609bbcf748"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4199a85cd39b1604ea643c1d2adcae31a0da12b4","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            # that had the actual marker record."},{"line_number":272,"context_line":"            local_marker_prefix \u003d []"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"            this_cell \u003d cctx.cell_uuid"},{"line_number":275,"context_line":"            marker_id \u003d self.marker_identifier"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"            if marker:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_8fb35198","line":274,"updated":"2018-08-24 14:57:11.000000000","message":"nit: this assignment could go inside the \"if marker\" condition below.","commit_id":"3862ebab3b0769104cd05ed0d0130c609bbcf748"}],"nova/tests/unit/compute/test_multi_cell_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4199a85cd39b1604ea643c1d2adcae31a0da12b4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                                     name\u003d\u0027cell%i\u0027 % i)"},{"line_number":337,"context_line":"                 for i in range(0, 3)]"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # Two of the five cells will fail, one with timeout and one"},{"line_number":340,"context_line":"        # with an error"},{"line_number":341,"context_line":"        lister \u003d TestLister(data, [], [], cells\u003dcells)"},{"line_number":342,"context_line":"        ctx \u003d context.RequestContext()"},{"line_number":343,"context_line":"        result \u003d list(lister.get_records_sorted(ctx, {}, 10, None))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4f2c59ab","line":340,"range":{"start_line":339,"start_character":8,"end_line":340,"end_character":23},"updated":"2018-08-24 14:57:11.000000000","message":"This was copied from above, but it\u0027s wrong, right? For one, you have 3 cells, and another is you\u0027re not using the FailureLister.","commit_id":"3862ebab3b0769104cd05ed0d0130c609bbcf748"}]}