)]}'
{"nova/api/openstack/compute/extended_volumes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db08efbd4856fb5b908404db7207d9a75386412e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def detail(self, req, resp_obj):"},{"line_number":82,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":83,"context_line":"        servers \u003d list(resp_obj.obj[\u0027servers\u0027])"},{"line_number":84,"context_line":"        bdms \u003d self._get_instance_bdms_in_multiple_cells(context, servers)"},{"line_number":85,"context_line":"        for server in servers:"},{"line_number":86,"context_line":"            instance_bdms \u003d self._get_instance_bdms(bdms, server)"},{"line_number":87,"context_line":"            self._extend_server(server, req, instance_bdms)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_instance_bdms(self, bdms, server):"},{"line_number":90,"context_line":"        # server[\u0027id\u0027] is guaranteed to be in the cache due to"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_530989da","side":"PARENT","line":87,"range":{"start_line":84,"start_character":8,"end_line":87,"end_character":59},"updated":"2018-09-17 22:51:20.000000000","message":"Wouldn\u0027t this be much more efficient before the change to move this into the ViewBuilder where it\u0027s being done per server in the response?","commit_id":"6eab5c982b5d6247930ae5359f7c60238c113987"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"7631aef678951ed89890b29c13478e8fbfb2eabc","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _get_volumes_attached(self, req, server):"},{"line_number":494,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":495,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":496,"context_line":"            context, [server[\"uuid\"]])"},{"line_number":497,"context_line":"        volumes_attached \u003d []"},{"line_number":498,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cbc5c05d","line":495,"updated":"2018-08-24 12:51:04.000000000","message":"oops, target this better for the multi-cells","commit_id":"cd1ac30a78fddc02e20906cf349f5d84ae9b196c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3204211d114b833293ccabe6822422b663fb2aa2","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                    for bdm in bdms:"},{"line_number":516,"context_line":"                        if bdm.get(\u0027volume_id\u0027):"},{"line_number":517,"context_line":"                            volume \u003d {\u0027id\u0027: bdm[\u0027volume_id\u0027]}"},{"line_number":518,"context_line":"                            if api_version_request.is_supported(req,"},{"line_number":519,"context_line":"                                min_version\u003d\u00272.3\u0027):"},{"line_number":520,"context_line":"                                    volume[\u0027delete_on_termination\u0027] \u003d ("},{"line_number":521,"context_line":"                                        bdm[\u0027delete_on_termination\u0027])"},{"line_number":522,"context_line":"                            volumes_attached.append(volume)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_73b3654f","line":519,"range":{"start_line":518,"start_character":28,"end_line":519,"end_character":51},"updated":"2018-09-17 22:41:03.000000000","message":"Let\u0027s pull this out of the loop.","commit_id":"1c1e190e4787703a2c35fd452384c9a726d48d0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db08efbd4856fb5b908404db7207d9a75386412e","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                    \u0027security_groups\u0027, [{\u0027name\u0027: \u0027default\u0027}])"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    @staticmethod"},{"line_number":508,"context_line":"    def _get_volumes_attached(req, server):"},{"line_number":509,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":510,"context_line":"        volumes_attached \u003d []"},{"line_number":511,"context_line":"        # There should not be a situation where there is an instance but no"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_73fda5b0","line":508,"updated":"2018-09-17 22:51:20.000000000","message":"When listing servers, we\u0027re going to hit this once per server which is going to be less efficient (I think anyway?) than what the detail() method in the extension was doing before where it was querying all cells and then putting the results together for the response. This was probably written before I asked gmann to rewrite _add_security_grps above to work on a list of servers so we don\u0027t have to call it once per server and we can then batch the results. Can that be done here also?","commit_id":"3a3a0a45e813afa1e03017b6ffbf671674b25182"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23f6f5455d5c91e0b8a26238c103ce3b9b022f6","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                    \u0027security_groups\u0027, [{\u0027name\u0027: \u0027default\u0027}])"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    @staticmethod"},{"line_number":508,"context_line":"    def _get_volumes_attached(req, server):"},{"line_number":509,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":510,"context_line":"        volumes_attached \u003d []"},{"line_number":511,"context_line":"        # There should not be a situation where there is an instance but no"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_eecea759","line":508,"in_reply_to":"3f79a3b5_73fda5b0","updated":"2018-09-18 08:57:52.000000000","message":"done","commit_id":"3a3a0a45e813afa1e03017b6ffbf671674b25182"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db08efbd4856fb5b908404db7207d9a75386412e","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            im \u003d objects.InstanceMapping.get_by_instance_uuid(context,"},{"line_number":518,"context_line":"                                                              server[\"uuid\"])"},{"line_number":519,"context_line":"            if im.cell_mapping is not None:"},{"line_number":520,"context_line":"                bdms \u003d nova_context.scatter_gather_single_cell("},{"line_number":521,"context_line":"                    context,"},{"line_number":522,"context_line":"                    im.cell_mapping,"},{"line_number":523,"context_line":"                    objects.BlockDeviceMappingList.get_by_instance_uuid,"},{"line_number":524,"context_line":"                    server[\"uuid\"])"},{"line_number":525,"context_line":"                bdms \u003d bdms[im.cell_mapping.uuid]"},{"line_number":526,"context_line":"                if bdms is nova_context.raised_exception_sentinel:"},{"line_number":527,"context_line":"                    LOG.warning(\u0027Failed to get block device mappings from \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_93fac1b7","line":524,"range":{"start_line":520,"start_character":16,"end_line":524,"end_character":35},"updated":"2018-09-17 22:51:20.000000000","message":"This is likely less performant than what we had before where we\u0027d scatter and gather the results across cells.","commit_id":"3a3a0a45e813afa1e03017b6ffbf671674b25182"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c23f6f5455d5c91e0b8a26238c103ce3b9b022f6","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            im \u003d objects.InstanceMapping.get_by_instance_uuid(context,"},{"line_number":518,"context_line":"                                                              server[\"uuid\"])"},{"line_number":519,"context_line":"            if im.cell_mapping is not None:"},{"line_number":520,"context_line":"                bdms \u003d nova_context.scatter_gather_single_cell("},{"line_number":521,"context_line":"                    context,"},{"line_number":522,"context_line":"                    im.cell_mapping,"},{"line_number":523,"context_line":"                    objects.BlockDeviceMappingList.get_by_instance_uuid,"},{"line_number":524,"context_line":"                    server[\"uuid\"])"},{"line_number":525,"context_line":"                bdms \u003d bdms[im.cell_mapping.uuid]"},{"line_number":526,"context_line":"                if bdms is nova_context.raised_exception_sentinel:"},{"line_number":527,"context_line":"                    LOG.warning(\u0027Failed to get block device mappings from \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0ecc435f","line":524,"range":{"start_line":520,"start_character":16,"end_line":524,"end_character":35},"in_reply_to":"3f79a3b5_93fac1b7","updated":"2018-09-18 08:57:52.000000000","message":"done","commit_id":"3a3a0a45e813afa1e03017b6ffbf671674b25182"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"7d2da441bfd2c2528b8b4a110b777f26da19e666","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            add_delete_on_termination \u003d api_version_request.is_supported("},{"line_number":248,"context_line":"                request, min_version\u003d\u00272.3\u0027)"},{"line_number":249,"context_line":"            if bdms is None:"},{"line_number":250,"context_line":"                bdms \u003d objects.BlockDeviceMappingList.bdms_by_instance_uuid("},{"line_number":251,"context_line":"                    context, [instance[\"uuid\"]])"},{"line_number":252,"context_line":"            self._add_volumes_attachments(server[\"server\"],"},{"line_number":253,"context_line":"                                          bdms,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8fe04a29","line":250,"range":{"start_line":250,"start_character":54,"end_line":250,"end_character":76},"updated":"2018-09-18 13:22:09.000000000","message":"we should just be using get_by_instance_uuid for this since its only for nova show, but its okay since this does get_by_instance_uuids for a single instance","commit_id":"dff2df2bca7c997738d9fe4e9735fb86b5b6b15e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89c0f3641fad07517e95afc497c679f6f05623d1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"             show_extended_attr\u003dNone, show_host_status\u003dNone,"},{"line_number":130,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"},{"line_number":131,"context_line":"             show_extended_status\u003dTrue, show_extended_volumes\u003dTrue,"},{"line_number":132,"context_line":"             bdms\u003dNone):"},{"line_number":133,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":134,"context_line":"        ip_v4 \u003d instance.get(\u0027access_ip_v4\u0027)"},{"line_number":135,"context_line":"        ip_v6 \u003d instance.get(\u0027access_ip_v6\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1d8a29bb","line":132,"range":{"start_line":132,"start_character":13,"end_line":132,"end_character":22},"updated":"2018-09-18 20:24:57.000000000","message":"OK so I guess this is for distinguishing the show vs list case.","commit_id":"2f70333240ab4a643b8267654f0e8f8945c7caab"}],"nova/tests/unit/api/openstack/compute/test_extended_volumes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5a89a5afa6399b88ec4561cb546a80f06fe34a3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.assertEqual([], actual)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"class ExtendedVolumesTestV23(ExtendedVolumesTestV21):"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    exp_volumes_show \u003d ["},{"line_number":211,"context_line":"        {\u0027id\u0027: \u0027some_volume_1\u0027, \u0027delete_on_termination\u0027: True},"},{"line_number":212,"context_line":"    ]"},{"line_number":213,"context_line":"    exp_volumes_detail \u003d ["},{"line_number":214,"context_line":"        ["},{"line_number":215,"context_line":"            {\u0027id\u0027: \u0027some_volume_1\u0027, \u0027delete_on_termination\u0027: True},"},{"line_number":216,"context_line":"        ],"},{"line_number":217,"context_line":"        ["},{"line_number":218,"context_line":"            {\u0027id\u0027: \u0027some_volume_2\u0027, \u0027delete_on_termination\u0027: False},"},{"line_number":219,"context_line":"            {\u0027id\u0027: \u0027some_volume_3\u0027, \u0027delete_on_termination\u0027: False},"},{"line_number":220,"context_line":"        ],"},{"line_number":221,"context_line":"    ]"},{"line_number":222,"context_line":"    wsgi_api_version \u003d \u00272.3\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_31a5deb4","side":"PARENT","line":222,"range":{"start_line":208,"start_character":0,"end_line":222,"end_character":28},"updated":"2018-09-18 09:30:44.000000000","message":"testing of \u0027delete_on_termination\u0027 with 2.3 is not included in test_serversV21.py","commit_id":"6eab5c982b5d6247930ae5359f7c60238c113987"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"45322f3a5ee24cf25e1a42a1109c7b03a450d4a0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.assertEqual([], actual)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"class ExtendedVolumesTestV23(ExtendedVolumesTestV21):"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    exp_volumes_show \u003d ["},{"line_number":211,"context_line":"        {\u0027id\u0027: \u0027some_volume_1\u0027, \u0027delete_on_termination\u0027: True},"},{"line_number":212,"context_line":"    ]"},{"line_number":213,"context_line":"    exp_volumes_detail \u003d ["},{"line_number":214,"context_line":"        ["},{"line_number":215,"context_line":"            {\u0027id\u0027: \u0027some_volume_1\u0027, \u0027delete_on_termination\u0027: True},"},{"line_number":216,"context_line":"        ],"},{"line_number":217,"context_line":"        ["},{"line_number":218,"context_line":"            {\u0027id\u0027: \u0027some_volume_2\u0027, \u0027delete_on_termination\u0027: False},"},{"line_number":219,"context_line":"            {\u0027id\u0027: \u0027some_volume_3\u0027, \u0027delete_on_termination\u0027: False},"},{"line_number":220,"context_line":"        ],"},{"line_number":221,"context_line":"    ]"},{"line_number":222,"context_line":"    wsgi_api_version \u003d \u00272.3\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a56d2530","side":"PARENT","line":222,"range":{"start_line":208,"start_character":0,"end_line":222,"end_character":28},"in_reply_to":"3f79a3b5_31a5deb4","updated":"2018-09-18 14:59:38.000000000","message":"its done already: https://review.openstack.org/#/c/596285/5/nova/tests/unit/api/openstack/compute/test_serversV21.py@1606","commit_id":"6eab5c982b5d6247930ae5359f7c60238c113987"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"e0c9c5c9880fdfd0f5c07a4c50ce05dc077fe8ed","unresolved":false,"context_lines":[{"line_number":6639,"context_line":""},{"line_number":6640,"context_line":"        self.request.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":6641,"context_line":"        self.view_builder.show(self.request, self.instance)"},{"line_number":6642,"context_line":"        mock_im.assert_called_once_with(mock.ANY, self.uuid)"},{"line_number":6643,"context_line":""},{"line_number":6644,"context_line":"    @mock.patch(\u0027nova.objects.InstanceMapping.get_by_instance_uuid\u0027)"},{"line_number":6645,"context_line":"    def test_build_server_detail_with_fault_loaded(self, mock_im):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_20c1fc4e","side":"PARENT","line":6642,"updated":"2018-09-18 20:45:36.000000000","message":"accident","commit_id":"a899e09cfea174205b1c9475270665a626db3a65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89c0f3641fad07517e95afc497c679f6f05623d1","unresolved":false,"context_lines":[{"line_number":6651,"context_line":""},{"line_number":6652,"context_line":"        self.request.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":6653,"context_line":"        self.view_builder.show(self.request, self.instance)"},{"line_number":6654,"context_line":"        self.assertFalse(mock_im.called)"},{"line_number":6655,"context_line":""},{"line_number":6656,"context_line":"    def test_build_server_detail_with_fault_no_details_not_admin(self):"},{"line_number":6657,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.ERROR"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e09ea4b6","side":"PARENT","line":6654,"updated":"2018-09-18 20:24:57.000000000","message":"Why is this removed? And if it\u0027s not needed, can we also remove the mock?","commit_id":"a899e09cfea174205b1c9475270665a626db3a65"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"e0c9c5c9880fdfd0f5c07a4c50ce05dc077fe8ed","unresolved":false,"context_lines":[{"line_number":6651,"context_line":""},{"line_number":6652,"context_line":"        self.request.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":6653,"context_line":"        self.view_builder.show(self.request, self.instance)"},{"line_number":6654,"context_line":"        self.assertFalse(mock_im.called)"},{"line_number":6655,"context_line":""},{"line_number":6656,"context_line":"    def test_build_server_detail_with_fault_no_details_not_admin(self):"},{"line_number":6657,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.ERROR"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_00c4005f","side":"PARENT","line":6654,"in_reply_to":"3f79a3b5_e09ea4b6","updated":"2018-09-18 20:45:36.000000000","message":"yikes, accident","commit_id":"a899e09cfea174205b1c9475270665a626db3a65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89c0f3641fad07517e95afc497c679f6f05623d1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    ]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def fake_inst_mapp(*args, **kwargs):"},{"line_number":173,"context_line":"    return [{"},{"line_number":174,"context_line":"        \u0027id\u0027: 1,"},{"line_number":175,"context_line":"        \u0027instance_uuid\u0027: UUID1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_8051f00f","line":172,"range":{"start_line":172,"start_character":14,"end_line":172,"end_character":19},"updated":"2018-09-18 20:24:57.000000000","message":"nit: typo","commit_id":"2f70333240ab4a643b8267654f0e8f8945c7caab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89c0f3641fad07517e95afc497c679f6f05623d1","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def fake_inst_mapp(*args, **kwargs):"},{"line_number":173,"context_line":"    return [{"},{"line_number":174,"context_line":"        \u0027id\u0027: 1,"},{"line_number":175,"context_line":"        \u0027instance_uuid\u0027: UUID1,"},{"line_number":176,"context_line":"        \u0027cell_mapping\u0027: {\u0027id\u0027: 1, \u0027uuid\u0027: uuids.cell1, \u0027name\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_403f58b4","line":173,"updated":"2018-09-18 20:24:57.000000000","message":"nit: use a real InstanceMappingList","commit_id":"2f70333240ab4a643b8267654f0e8f8945c7caab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a98f02644eaf9e0869947c353f19183a5940361","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def fake_inst_mapp(*args, **kwargs):"},{"line_number":173,"context_line":"    return [{"},{"line_number":174,"context_line":"        \u0027id\u0027: 1,"},{"line_number":175,"context_line":"        \u0027instance_uuid\u0027: UUID1,"},{"line_number":176,"context_line":"        \u0027cell_mapping\u0027: {\u0027id\u0027: 1, \u0027uuid\u0027: uuids.cell1, \u0027name\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e0d6a427","line":173,"in_reply_to":"3f79a3b5_403f58b4","updated":"2018-09-18 20:39:50.000000000","message":"Oh nevermind I guess this is meant to stub out the DB API which returns dict-like objects, not an InstanceMappingList.","commit_id":"2f70333240ab4a643b8267654f0e8f8945c7caab"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"e0c9c5c9880fdfd0f5c07a4c50ce05dc077fe8ed","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def fake_inst_mapp(*args, **kwargs):"},{"line_number":173,"context_line":"    return [{"},{"line_number":174,"context_line":"        \u0027id\u0027: 1,"},{"line_number":175,"context_line":"        \u0027instance_uuid\u0027: UUID1,"},{"line_number":176,"context_line":"        \u0027cell_mapping\u0027: {\u0027id\u0027: 1, \u0027uuid\u0027: uuids.cell1, \u0027name\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_2096dc4a","line":173,"in_reply_to":"3f79a3b5_e0d6a427","updated":"2018-09-18 20:45:36.000000000","message":"yea","commit_id":"2f70333240ab4a643b8267654f0e8f8945c7caab"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"428c39cfad146bed4b8b683c4bdea44f7bd50dd4","unresolved":false,"context_lines":[{"line_number":6639,"context_line":""},{"line_number":6640,"context_line":"        self.request.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":6641,"context_line":"        self.view_builder.show(self.request, self.instance)"},{"line_number":6642,"context_line":"        mock_im.assert_called_once_with(mock.ANY, self.uuid)"},{"line_number":6643,"context_line":""},{"line_number":6644,"context_line":"    @mock.patch(\u0027nova.objects.InstanceMapping.get_by_instance_uuid\u0027)"},{"line_number":6645,"context_line":"    def test_build_server_detail_with_fault_loaded(self, mock_im):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_20bd7cb0","side":"PARENT","line":6642,"range":{"start_line":6642,"start_character":30,"end_line":6642,"end_character":34},"updated":"2018-09-18 20:49:13.000000000","message":"actually this change and the one below were accidents caused by change in the test case since I changed,","commit_id":"a899e09cfea174205b1c9475270665a626db3a65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b278ef104f80d4a5062dee64c63e38a7ab7fd78f","unresolved":false,"context_lines":[{"line_number":6639,"context_line":""},{"line_number":6640,"context_line":"        self.request.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":6641,"context_line":"        self.view_builder.show(self.request, self.instance)"},{"line_number":6642,"context_line":"        mock_im.assert_called_once_with(mock.ANY, self.uuid)"},{"line_number":6643,"context_line":""},{"line_number":6644,"context_line":"    @mock.patch(\u0027nova.objects.InstanceMapping.get_by_instance_uuid\u0027)"},{"line_number":6645,"context_line":"    def test_build_server_detail_with_fault_loaded(self, mock_im):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_60513462","side":"PARENT","line":6642,"range":{"start_line":6642,"start_character":30,"end_line":6642,"end_character":34},"in_reply_to":"3f79a3b5_20bd7cb0","updated":"2018-09-18 20:55:13.000000000","message":"Yeah next patch set fixes these.","commit_id":"a899e09cfea174205b1c9475270665a626db3a65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4a0aac5dc553cb632dbe6d8688f1cf603b6a581","unresolved":false,"context_lines":[{"line_number":6457,"context_line":"        self.assertEqual(result, expected)"},{"line_number":6458,"context_line":""},{"line_number":6459,"context_line":"    @mock.patch(\u0027nova.context.scatter_gather_cells\u0027)"},{"line_number":6460,"context_line":"    def test_get_volumes_attached_with_faily_cells(self, mock_sg):"},{"line_number":6461,"context_line":"        bdms \u003d fake_bdms_get_all_by_instance_uuids()"},{"line_number":6462,"context_line":"        # just faking a nova list scenario"},{"line_number":6463,"context_line":"        mock_sg.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_40d998f1","line":6460,"range":{"start_line":6460,"start_character":8,"end_line":6460,"end_character":50},"updated":"2018-09-18 20:57:08.000000000","message":"I\u0027m guessing this is attempting to be a new version of the now deleted test_detail_with_cell_failures test?","commit_id":"c60688e11b30dedf272e1a53af4cf1d79a0143d8"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"a8d6003d45751f715507c1b8f34bf2da60d01c4c","unresolved":false,"context_lines":[{"line_number":6457,"context_line":"        self.assertEqual(result, expected)"},{"line_number":6458,"context_line":""},{"line_number":6459,"context_line":"    @mock.patch(\u0027nova.context.scatter_gather_cells\u0027)"},{"line_number":6460,"context_line":"    def test_get_volumes_attached_with_faily_cells(self, mock_sg):"},{"line_number":6461,"context_line":"        bdms \u003d fake_bdms_get_all_by_instance_uuids()"},{"line_number":6462,"context_line":"        # just faking a nova list scenario"},{"line_number":6463,"context_line":"        mock_sg.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_2314a640","line":6460,"range":{"start_line":6460,"start_character":8,"end_line":6460,"end_character":50},"in_reply_to":"3f79a3b5_40d998f1","updated":"2018-09-18 21:05:33.000000000","message":"yes. I could just put the same test back, but we stub the instance_mappings and all.","commit_id":"c60688e11b30dedf272e1a53af4cf1d79a0143d8"}]}