)]}'
{"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b920fc62e10ff514e3dd6e56333a74f559617aee","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/volume-attachment-detail-resp.json"},{"line_number":136,"context_line":"   :language: javascript"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{volume_id}"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_5f3863d1","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":26},"updated":"2018-08-27 14:01:07.000000000","message":"is this an endpoint we should potentially deprecate/remove in the future in favor of calling the cinder apis directly or\ndo we legitimately need this for some other reason beyond backwards compatibility.\n\nim not sure of the histroy of this endpoint but it feels like a proxy api that may be better served by going direct to cinder then contiuing to support in nova.\n\nlist, attach and detach make sense to me but the usage of this endpoint feels somewhat different.","commit_id":"f3fa4eef4cb0f51f1f480302f31b0dab4e27107d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42f1c33c9b0d72a0f3c5b584c4940a76602a193f","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/volume-attachment-detail-resp.json"},{"line_number":136,"context_line":"   :language: javascript"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{volume_id}"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_4ce2c3a2","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":26},"in_reply_to":"3f79a3b5_5f3863d1","updated":"2018-08-29 19:26:09.000000000","message":"\u003e is this an endpoint we should potentially deprecate/remove in the\n \u003e future in favor of calling the cinder apis directly or\n \u003e do we legitimately need this for some other reason beyond backwards\n \u003e compatibility.\n\nThis API exists solely as a callback for volume retype/live migration. Its purpose is for Cinder to tell Nova to swap the block device. But since it\u0027s a REST API people can (ab)use it.\n\n \u003e \n \u003e im not sure of the histroy of this endpoint but it feels like a\n \u003e proxy api that may be better served by going direct to cinder then\n \u003e contiuing to support in nova.\n \u003e \n \u003e list, attach and detach make sense to me but the usage of this\n \u003e endpoint feels somewhat different.\n\nYes users should be using the retype/migration APIs in Cinder directly, not using this in Nova. But apparently there are sometimes issues with doing that so they hack around it by calling nova directly. I\u0027m still unclear on what the blocking issues are with people not being able to use the Cinder APIs. It sounds like at least one is you can\u0027t do certain things if the volume has snapshots.","commit_id":"f3fa4eef4cb0f51f1f480302f31b0dab4e27107d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4fc119482f0da789449fdda72ac281c0044fd847","unresolved":false,"context_lines":[{"line_number":153,"context_line":"             within the guest such as block storage serial IDs. Furthermore,"},{"line_number":154,"context_line":"             this API is only implemented by `certain compute drivers`_."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":".. _certain compute drivers: https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_swap_volume"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":159,"context_line":"this operation. Cloud providers can change these permissions through the"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_53ab82d4","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":114},"updated":"2018-08-27 11:13:54.000000000","message":"I wonder if we should use the openstackdocstheme extensions [1] to ensure this points to a versioned link? I guess this link won\u0027t change for a while?\n\n[1] https://docs.openstack.org/openstackdocstheme/latest/#external-link-helper","commit_id":"f3fa4eef4cb0f51f1f480302f31b0dab4e27107d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5cc3bbc463f6b92c58346fc86538e99b85a56846","unresolved":false,"context_lines":[{"line_number":153,"context_line":"             within the guest such as block storage serial IDs. Furthermore,"},{"line_number":154,"context_line":"             this API is only implemented by `certain compute drivers`_."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":".. _certain compute drivers: https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_swap_volume"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":159,"context_line":"this operation. Cloud providers can change these permissions through the"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_7959bf8b","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":114},"in_reply_to":"3f79a3b5_53ab82d4","updated":"2018-08-27 13:08:53.000000000","message":"API reference is based on latest so I don\u0027t think we\u0027d want to pin this to a release which could get stale.","commit_id":"f3fa4eef4cb0f51f1f480302f31b0dab4e27107d"}]}