)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5026bdfd9dbed9cd6f1c5889ce1bfca0ed162b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Fried \u003cefried@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-28 17:23:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Other host allocs may appear in gafpt during evac"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The report client\u0027s get_allocations_for_provider_tree tries pretty hard"},{"line_number":10,"context_line":"to retrieve only allocations relevant to the compute on which it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_eaf70859","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":49},"updated":"2018-08-28 22:27:50.000000000","message":"nit: Could also be a resize across hosts that are being upgraded.","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a1a7f94cfdf1c752f26371a4452d17ff8c263c93","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Fried \u003cefried@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-28 17:23:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Other host allocs may appear in gafpt during evac"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The report client\u0027s get_allocations_for_provider_tree tries pretty hard"},{"line_number":10,"context_line":"to retrieve only allocations relevant to the compute on which it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_6371d7de","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":49},"in_reply_to":"3f79a3b5_40229403","updated":"2018-08-29 12:59:11.000000000","message":"Yeah good point, ignore my comments about resize then.","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"279508c05dffba844fc6866bf34835c49d74b9b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Fried \u003cefried@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-28 17:23:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Other host allocs may appear in gafpt during evac"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The report client\u0027s get_allocations_for_provider_tree tries pretty hard"},{"line_number":10,"context_line":"to retrieve only allocations relevant to the compute on which it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_40229403","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":49},"in_reply_to":"3f79a3b5_eaf70859","updated":"2018-08-29 09:02:53.000000000","message":"I don\u0027t see how an ongoing resize will result in allocations from two different computes appearing in the result.\n\nI think during resize the source allocation is held by the migration_uuid and the destination allocation is held by instance_uuid. \n\nThe code first collects RPs that are in the compute node tree. Then gets the consumers having allocations on those RPs. In case of resize it will be either the migration_uuid (if we are on the source host) or instance_uuid (if we are on the dest host) or both (if it is a same-host resize). But there are no resize cases where both the instance_uuid and the migration_uuid appears in the output but they hold allocations against two different compute hosts.","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5026bdfd9dbed9cd6f1c5889ce1bfca0ed162b","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        providers if those allocations are associated with a consumer on this"},{"line_number":2013,"context_line":"        compute node. This is intentional and desirable. But it may also return"},{"line_number":2014,"context_line":"        allocations belonging to other hosts, e.g. if this is happening in the"},{"line_number":2015,"context_line":"        middle of an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2016,"context_line":"        allocations if they appear."},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        :param context: The security context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2a83c0ab","line":2015,"range":{"start_line":2015,"start_character":31,"end_line":2015,"end_character":51},"updated":"2018-08-28 22:27:50.000000000","message":"ComputeDriver.update_provider_tree otherwise it sounds like update_provider_tree is in this method.","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5026bdfd9dbed9cd6f1c5889ce1bfca0ed162b","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        providers if those allocations are associated with a consumer on this"},{"line_number":2013,"context_line":"        compute node. This is intentional and desirable. But it may also return"},{"line_number":2014,"context_line":"        allocations belonging to other hosts, e.g. if this is happening in the"},{"line_number":2015,"context_line":"        middle of an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2016,"context_line":"        allocations if they appear."},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        :param context: The security context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4a9cfc0d","line":2015,"range":{"start_line":2015,"start_character":21,"end_line":2015,"end_character":29},"updated":"2018-08-28 22:27:50.000000000","message":"or resize","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"279508c05dffba844fc6866bf34835c49d74b9b8","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        providers if those allocations are associated with a consumer on this"},{"line_number":2013,"context_line":"        compute node. This is intentional and desirable. But it may also return"},{"line_number":2014,"context_line":"        allocations belonging to other hosts, e.g. if this is happening in the"},{"line_number":2015,"context_line":"        middle of an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2016,"context_line":"        allocations if they appear."},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        :param context: The security context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6080f0c0","line":2015,"range":{"start_line":2015,"start_character":31,"end_line":2015,"end_character":51},"in_reply_to":"3f79a3b5_2a83c0ab","updated":"2018-08-29 09:02:53.000000000","message":"\u003e ComputeDriver.update_provider_tree otherwise it sounds like\n \u003e update_provider_tree is in this method.\n\n+1","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"279508c05dffba844fc6866bf34835c49d74b9b8","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        providers if those allocations are associated with a consumer on this"},{"line_number":2013,"context_line":"        compute node. This is intentional and desirable. But it may also return"},{"line_number":2014,"context_line":"        allocations belonging to other hosts, e.g. if this is happening in the"},{"line_number":2015,"context_line":"        middle of an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2016,"context_line":"        allocations if they appear."},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        :param context: The security context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_206af81a","line":2015,"range":{"start_line":2015,"start_character":21,"end_line":2015,"end_character":29},"in_reply_to":"3f79a3b5_4a9cfc0d","updated":"2018-08-29 09:02:53.000000000","message":"\u003e or resize\n\nI think it cannot happen. See my reply in the commit message","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0a6611143a56ae2099c6923aa641645f2ee7b081","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        providers if those allocations are associated with a consumer on this"},{"line_number":2013,"context_line":"        compute node. This is intentional and desirable. But it may also return"},{"line_number":2014,"context_line":"        allocations belonging to other hosts, e.g. if this is happening in the"},{"line_number":2015,"context_line":"        middle of an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2016,"context_line":"        allocations if they appear."},{"line_number":2017,"context_line":""},{"line_number":2018,"context_line":"        :param context: The security context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_49a035a6","line":2015,"range":{"start_line":2015,"start_character":31,"end_line":2015,"end_character":51},"in_reply_to":"3f79a3b5_6080f0c0","updated":"2018-08-31 20:54:52.000000000","message":"Done","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a1a7f94cfdf1c752f26371a4452d17ff8c263c93","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"                 call fails."},{"line_number":2045,"context_line":"        :raises: ValueError if there\u0027s no provider with the specified nodename."},{"line_number":2046,"context_line":"        \"\"\""},{"line_number":2047,"context_line":"        # NOTE(efried): Despite our best efforts, there are some scenarios"},{"line_number":2048,"context_line":"        # (e.g. mid-evacuate) where we can still wind up returning allocations"},{"line_number":2049,"context_line":"        # against providers belonging to other hosts. We count on the consumer"},{"line_number":2050,"context_line":"        # of this information (i.e. the reshaper flow of a virt driver\u0027s"},{"line_number":2051,"context_line":"        # update_provider_tree) to ignore allocations associated with any"},{"line_number":2052,"context_line":"        # provider it is not reshaping - and it should never be reshaping"},{"line_number":2053,"context_line":"        # providers belonging to other hosts."},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":"        # We can\u0027t get *all* allocations for associated sharing providers"},{"line_number":2056,"context_line":"        # because some of those will belong to consumers on other hosts. So we"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_23a67f55","line":2053,"range":{"start_line":2047,"start_character":8,"end_line":2053,"end_character":45},"updated":"2018-08-29 12:59:11.000000000","message":"I guess we already have this...","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf5026bdfd9dbed9cd6f1c5889ce1bfca0ed162b","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"        # result. This will include allocations on sharing providers, which is"},{"line_number":2072,"context_line":"        # intentional and desirable. But it may also include allocations"},{"line_number":2073,"context_line":"        # belonging to other hosts, e.g. if this is happening in the middle of"},{"line_number":2074,"context_line":"        # an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2075,"context_line":"        # allocations if they appear."},{"line_number":2076,"context_line":"        # TODO(efried): This could be more efficient if placement offered an"},{"line_number":2077,"context_line":"        # operation like GET /allocations?consumer_uuid\u003din:\u003clist\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ca8faccb","line":2074,"range":{"start_line":2074,"start_character":13,"end_line":2074,"end_character":43},"updated":"2018-08-28 22:27:50.000000000","message":"same as above","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0a6611143a56ae2099c6923aa641645f2ee7b081","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"        # result. This will include allocations on sharing providers, which is"},{"line_number":2072,"context_line":"        # intentional and desirable. But it may also include allocations"},{"line_number":2073,"context_line":"        # belonging to other hosts, e.g. if this is happening in the middle of"},{"line_number":2074,"context_line":"        # an evacuate. update_provider_tree is supposed to ignore such"},{"line_number":2075,"context_line":"        # allocations if they appear."},{"line_number":2076,"context_line":"        # TODO(efried): This could be more efficient if placement offered an"},{"line_number":2077,"context_line":"        # operation like GET /allocations?consumer_uuid\u003din:\u003clist\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_69a3b1b2","line":2074,"range":{"start_line":2074,"start_character":13,"end_line":2074,"end_character":43},"in_reply_to":"3f79a3b5_ca8faccb","updated":"2018-08-31 20:54:52.000000000","message":"Done","commit_id":"04e0e24bc8763d37cdc6be5ab0981b2ff8250c77"}]}