)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"55b2022cc23ec19c3804dec2a8030c191bedd382","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def _get_server_search_options(self, req):"},{"line_number":1090,"context_line":"        \"\"\"Return server search options allowed by non-admin.\"\"\""},{"line_number":1091,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1092,"context_line":"                    \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027)"},{"line_number":1093,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.5\u0027):"},{"line_number":1094,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1095,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.26\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2842a8ac","line":1092,"range":{"start_line":1091,"start_character":9,"end_line":1092,"end_character":57},"updated":"2018-08-31 08:50:01.000000000","message":"those are allowed by non-admin\nso delete should be ignored silently at line 1184\n\nare you suggesting to raise issue instead of silent ignore it?","commit_id":"4649279bfdbc414d88910eb21822957abbc287f2"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"2b864b7c3af72f50430c21047d869938bf11dab3","unresolved":false,"context_lines":[{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"    def _get_server_search_options(self, req):"},{"line_number":1090,"context_line":"        \"\"\"Return server search options allowed by non-admin.\"\"\""},{"line_number":1091,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1092,"context_line":"                    \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027)"},{"line_number":1093,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.5\u0027):"},{"line_number":1094,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1095,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.26\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4ee84db2","line":1092,"range":{"start_line":1091,"start_character":9,"end_line":1092,"end_character":57},"in_reply_to":"3f79a3b5_2842a8ac","updated":"2018-08-31 09:26:17.000000000","message":"Yes, I think it\u0027s better to raise issue like \u0027nova list --status\u003dDELETED\u0027 did.\n\nCurrently non-admin users will get non-deleted instances like \u0027nova list\u0027 did.","commit_id":"4649279bfdbc414d88910eb21822957abbc287f2"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"55b2022cc23ec19c3804dec2a8030c191bedd382","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"    unknown_options \u003d [opt for opt in search_options"},{"line_number":1182,"context_line":"                        if opt not in allowed_search_options]"},{"line_number":1183,"context_line":"    if unknown_options:"},{"line_number":1184,"context_line":"        LOG.debug(\"Removing options \u0027%s\u0027 from query\","},{"line_number":1185,"context_line":"                  \", \".join(unknown_options))"},{"line_number":1186,"context_line":"        for opt in unknown_options:"},{"line_number":1187,"context_line":"            search_options.pop(opt, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a836b850","line":1184,"range":{"start_line":1184,"start_character":8,"end_line":1184,"end_character":52},"updated":"2018-08-31 08:50:01.000000000","message":"ignore here","commit_id":"4649279bfdbc414d88910eb21822957abbc287f2"}]}