)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"712ab0a62cc74b119b468ddd501d139514c423b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix filter server list by multiple vm or task states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For example, if we make the API call"},{"line_number":10,"context_line":"\"GET servers/detail?vm_state\u003dACTIVE\u0026vm_state\u003dSTOPPED\","},{"line_number":11,"context_line":"only servers with STOPPED vm_state are returned instead"},{"line_number":12,"context_line":"of servers with either state. This patch fixes it by"},{"line_number":13,"context_line":"capturing all provided states."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_efd633f3","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":52},"updated":"2018-09-10 22:58:19.000000000","message":"In this case, should we expect server info of ACTIVE *OR* STOPPED? or none server info?\nIt is better to take time for discussing how to change here more.","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"},{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"ec47e4075569d605acbc5f69673da8e4eb4b83b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix filter server list by multiple vm or task states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For example, if we make the API call"},{"line_number":10,"context_line":"\"GET servers/detail?vm_state\u003dACTIVE\u0026vm_state\u003dSTOPPED\","},{"line_number":11,"context_line":"only servers with STOPPED vm_state are returned instead"},{"line_number":12,"context_line":"of servers with either state. This patch fixes it by"},{"line_number":13,"context_line":"capturing all provided states."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_603d508d","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":52},"in_reply_to":"3f79a3b5_efd633f3","updated":"2018-09-11 02:13:26.000000000","message":"Currently if we do it with status filters \"status\u003dactive\u0026status\u003dshutoff\", both active and shutoff servers\u0027s info will show up. And this patch just ensures all vm_states are captured when we use multiple vm_state filters but does not try to modify the default behavior.","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ecd44f97ab08a490f8dbfb87f75a94a1bdc6f2b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027default\u0027 not in task_state:"},{"line_number":143,"context_line":"                search_opts[\u0027task_state\u0027] \u003d task_state"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Options vm_state and task_state can be provided multiple times"},{"line_number":146,"context_line":"        # in the request. We need to capture all those states. At the same"},{"line_number":147,"context_line":"        # time explictly provided vm_state and task_state values should"},{"line_number":148,"context_line":"        # override those derived from option status."},{"line_number":149,"context_line":"        if \u0027vm_state\u0027 in req.GET.keys():"},{"line_number":150,"context_line":"            vm_state \u003d req.GET.getall(\u0027vm_state\u0027)"},{"line_number":151,"context_line":"            search_opts[\u0027vm_state\u0027] \u003d vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c7453717","line":148,"range":{"start_line":145,"start_character":8,"end_line":148,"end_character":52},"updated":"2018-08-30 13:15:09.000000000","message":"This all smells like API behavior change to me.","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"d4f1b690939dd55469b4a1bdbdafd2eed7cc66ca","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027default\u0027 not in task_state:"},{"line_number":143,"context_line":"                search_opts[\u0027task_state\u0027] \u003d task_state"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Options vm_state and task_state can be provided multiple times"},{"line_number":146,"context_line":"        # in the request. We need to capture all those states. At the same"},{"line_number":147,"context_line":"        # time explictly provided vm_state and task_state values should"},{"line_number":148,"context_line":"        # override those derived from option status."},{"line_number":149,"context_line":"        if \u0027vm_state\u0027 in req.GET.keys():"},{"line_number":150,"context_line":"            vm_state \u003d req.GET.getall(\u0027vm_state\u0027)"},{"line_number":151,"context_line":"            search_opts[\u0027vm_state\u0027] \u003d vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_d0120e58","line":148,"range":{"start_line":145,"start_character":8,"end_line":148,"end_character":52},"in_reply_to":"3f79a3b5_6a52eae0","updated":"2020-04-10 03:34:27.000000000","message":"It\u0027s commpleted in https://review.opendev.org/#/c/701609/9/nova/api/openstack/compute/servers.py@1274, I think we can abandon this patch now.","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3c2fdff5c16eb1c772a4f2a58bdad2881ab78134","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027default\u0027 not in task_state:"},{"line_number":143,"context_line":"                search_opts[\u0027task_state\u0027] \u003d task_state"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Options vm_state and task_state can be provided multiple times"},{"line_number":146,"context_line":"        # in the request. We need to capture all those states. At the same"},{"line_number":147,"context_line":"        # time explictly provided vm_state and task_state values should"},{"line_number":148,"context_line":"        # override those derived from option status."},{"line_number":149,"context_line":"        if \u0027vm_state\u0027 in req.GET.keys():"},{"line_number":150,"context_line":"            vm_state \u003d req.GET.getall(\u0027vm_state\u0027)"},{"line_number":151,"context_line":"            search_opts[\u0027vm_state\u0027] \u003d vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6a52eae0","line":148,"range":{"start_line":145,"start_character":8,"end_line":148,"end_character":52},"in_reply_to":"3f79a3b5_c7453717","updated":"2018-08-30 13:50:47.000000000","message":"yea, I second on this...","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"881191faf30f793bf1a80701a4c48ad894a524c0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027default\u0027 not in task_state:"},{"line_number":143,"context_line":"                search_opts[\u0027task_state\u0027] \u003d task_state"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Options vm_state and task_state can be provided multiple times"},{"line_number":146,"context_line":"        # in the request. We need to capture all those states. At the same"},{"line_number":147,"context_line":"        # time explictly provided vm_state and task_state values should"},{"line_number":148,"context_line":"        # override those derived from option status."},{"line_number":149,"context_line":"        if \u0027vm_state\u0027 in req.GET.keys():"},{"line_number":150,"context_line":"            vm_state \u003d req.GET.getall(\u0027vm_state\u0027)"},{"line_number":151,"context_line":"            search_opts[\u0027vm_state\u0027] \u003d vm_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a4b6cb89","line":148,"range":{"start_line":145,"start_character":8,"end_line":148,"end_character":52},"in_reply_to":"df33271e_d0120e58","updated":"2020-05-22 10:37:55.000000000","message":"I don\u0027t see that the microversion 2.83 supports multiple vm_state attributes either. See http://paste.openstack.org/show/793878/","commit_id":"af69269eb32c3bf7418692e28558278cac50b826"}]}