)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"25659ccd9cd6b32bd819c64d3172d56ebb5d2e00","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LOG.warn() and LOG.error() should support translation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Based on a search done in nova code,"},{"line_number":10,"context_line":"some logs have been changed in order to support translation"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I371b714d004bcd0091ae569d4b82ae8d19fba708"},{"line_number":13,"context_line":"Closes-Bug: #1235088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9sI0%3D","line":10,"updated":"2013-12-07 13:30:25.000000000","message":"s/have been/have to be/, right?","commit_id":"a3e32ec092055b76e22abc5644d1055b8f5db949"}],"nova/openstack/common/rpc/impl_zmq.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"00155eda4e1f0ca3400af8796941c737c7a443a8","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            # it would be much worse if some of the code calling this"},{"line_number":193,"context_line":"            # were to fail. For now, lets log, and later evaluate"},{"line_number":194,"context_line":"            # if we can safely raise here."},{"line_number":195,"context_line":"            LOG.error(_(\"ZeroMQ socket could not be closed.\"))"},{"line_number":196,"context_line":"        self.sock \u003d None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def recv(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96%2Fc%3D","line":195,"updated":"2013-12-04 13:13:42.000000000","message":"this code should be changed in oslo first and then backported","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"91e7194ec96dc9e401ddda93f9ce513b7dd0247d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            # it would be much worse if some of the code calling this"},{"line_number":193,"context_line":"            # were to fail. For now, lets log, and later evaluate"},{"line_number":194,"context_line":"            # if we can safely raise here."},{"line_number":195,"context_line":"            LOG.error(_(\"ZeroMQ socket could not be closed.\"))"},{"line_number":196,"context_line":"        self.sock \u003d None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def recv(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F965Y%3D","line":195,"in_reply_to":"AAAATn%2F96%2Fc%3D","updated":"2013-12-04 13:38:54.000000000","message":"I\u0027ll raise an issue for that in oslo, so far it is just for translation","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"874e213f46373c1e9d8b7106db5434efe1d6e1cd","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            # it would be much worse if some of the code calling this"},{"line_number":193,"context_line":"            # were to fail. For now, lets log, and later evaluate"},{"line_number":194,"context_line":"            # if we can safely raise here."},{"line_number":195,"context_line":"            LOG.error(_(\"ZeroMQ socket could not be closed.\"))"},{"line_number":196,"context_line":"        self.sock \u003d None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def recv(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F90p0%3D","line":195,"updated":"2013-12-05 15:12:46.000000000","message":"This one should be fixed in Oslo","commit_id":"4a6eaf17cf2e51aae49ff47fb71a1427d0ec49bf"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"9e903354df6a8331cdfb92d4398d5cde5f55c155","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            # it would be much worse if some of the code calling this"},{"line_number":193,"context_line":"            # were to fail. For now, lets log, and later evaluate"},{"line_number":194,"context_line":"            # if we can safely raise here."},{"line_number":195,"context_line":"            LOG.error(_(\"ZeroMQ socket could not be closed.\"))"},{"line_number":196,"context_line":"        self.sock \u003d None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def recv(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9z0o%3D","line":195,"in_reply_to":"AAAATn%2F90p0%3D","updated":"2013-12-05 17:43:23.000000000","message":"Done","commit_id":"4a6eaf17cf2e51aae49ff47fb71a1427d0ec49bf"}],"nova/tests/db/test_migrations.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"874e213f46373c1e9d8b7106db5434efe1d6e1cd","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                if check:"},{"line_number":551,"context_line":"                    check(engine, data)"},{"line_number":552,"context_line":"        except Exception:"},{"line_number":553,"context_line":"            LOG.error(_(\"Failed to migrate to version %(version)s on engine \""},{"line_number":554,"context_line":"                        \"%(engine)s\"), {\u0027version\u0027: version, \u0027engine\u0027: engine})"},{"line_number":555,"context_line":"            raise"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F90ow%3D","line":553,"updated":"2013-12-05 15:12:46.000000000","message":"Although I agree that log in source codes should support translation, I don\u0027t think log in unit test cases should and openstack developers need to read translated log when running UT, except that it increase tranlsation work load. Do we really need this support translation?","commit_id":"4a6eaf17cf2e51aae49ff47fb71a1427d0ec49bf"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"9e903354df6a8331cdfb92d4398d5cde5f55c155","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                if check:"},{"line_number":551,"context_line":"                    check(engine, data)"},{"line_number":552,"context_line":"        except Exception:"},{"line_number":553,"context_line":"            LOG.error(_(\"Failed to migrate to version %(version)s on engine \""},{"line_number":554,"context_line":"                        \"%(engine)s\"), {\u0027version\u0027: version, \u0027engine\u0027: engine})"},{"line_number":555,"context_line":"            raise"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9zwI%3D","line":553,"in_reply_to":"AAAATn%2F90ow%3D","updated":"2013-12-05 17:43:23.000000000","message":"Agree on this.","commit_id":"4a6eaf17cf2e51aae49ff47fb71a1427d0ec49bf"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"83840851b2866ee4e4d0d13a95d29c893d525e88","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                    check(engine, data)"},{"line_number":552,"context_line":"        except Exception:"},{"line_number":553,"context_line":"            LOG.error(\"Failed to migrate to version %(version)s on engine \""},{"line_number":554,"context_line":"                        \"%(engine)s\", {\u0027version\u0027: version, \u0027engine\u0027: engine})"},{"line_number":555,"context_line":"            raise"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9th4%3D","line":554,"updated":"2013-12-06 20:51:38.000000000","message":"You\u0027re not making this one translatable, which I agree with, so I would leave this line of code unchanged.\n\nThere are other instances of this same thing in the patch, so please undo all of them when updating this.","commit_id":"a3e32ec092055b76e22abc5644d1055b8f5db949"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"25659ccd9cd6b32bd819c64d3172d56ebb5d2e00","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                    check(engine, data)"},{"line_number":552,"context_line":"        except Exception:"},{"line_number":553,"context_line":"            LOG.error(\"Failed to migrate to version %(version)s on engine \""},{"line_number":554,"context_line":"                        \"%(engine)s\", {\u0027version\u0027: version, \u0027engine\u0027: engine})"},{"line_number":555,"context_line":"            raise"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9sIk%3D","line":554,"in_reply_to":"AAAATn%2F9tDo%3D","updated":"2013-12-07 13:30:25.000000000","message":"Yes, this is not related to i18n, so perhaps we can handle this in another patch.","commit_id":"a3e32ec092055b76e22abc5644d1055b8f5db949"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"7d378d5123cb4b225809f7207846cf722da5248e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                    check(engine, data)"},{"line_number":552,"context_line":"        except Exception:"},{"line_number":553,"context_line":"            LOG.error(\"Failed to migrate to version %(version)s on engine \""},{"line_number":554,"context_line":"                        \"%(engine)s\", {\u0027version\u0027: version, \u0027engine\u0027: engine})"},{"line_number":555,"context_line":"            raise"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9tDo%3D","line":554,"in_reply_to":"AAAATn%2F9th4%3D","updated":"2013-12-06 22:45:54.000000000","message":"These are small improvements in the logs, do you think we should not include these improvements?","commit_id":"a3e32ec092055b76e22abc5644d1055b8f5db949"}],"nova/tests/integrated/test_api_samples.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"00155eda4e1f0ca3400af8796941c737c7a443a8","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                missing_tests.append(extension)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if missing_tests:"},{"line_number":154,"context_line":"            LOG.error(_(\"Extensions are missing tests: %s\") % missing_tests)"},{"line_number":155,"context_line":"        self.assertEqual(missing_tests, [])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96%2FE%3D","line":154,"updated":"2013-12-04 13:13:42.000000000","message":"please use a , instead of %","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"91e7194ec96dc9e401ddda93f9ce513b7dd0247d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                missing_tests.append(extension)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if missing_tests:"},{"line_number":154,"context_line":"            LOG.error(_(\"Extensions are missing tests: %s\") % missing_tests)"},{"line_number":155,"context_line":"        self.assertEqual(missing_tests, [])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F967A%3D","line":154,"in_reply_to":"AAAATn%2F96%2FE%3D","updated":"2013-12-04 13:38:54.000000000","message":"Done","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"}],"nova/tests/virt/test_virt_drivers.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"00155eda4e1f0ca3400af8796941c737c7a443a8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return f(self, *args, **kwargs)"},{"line_number":51,"context_line":"        except NotImplementedError:"},{"line_number":52,"context_line":"            frame \u003d traceback.extract_tb(sys.exc_info()[2])[-1]"},{"line_number":53,"context_line":"            LOG.error(_(\u0027%(driver)s does not implement %(method)s\u0027) % {"},{"line_number":54,"context_line":"                                               \u0027driver\u0027: type(self.connection),"},{"line_number":55,"context_line":"                                               \u0027method\u0027: frame[2]})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96%2FA%3D","line":53,"updated":"2013-12-04 13:13:42.000000000","message":"ditto regarding comma","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"91e7194ec96dc9e401ddda93f9ce513b7dd0247d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return f(self, *args, **kwargs)"},{"line_number":51,"context_line":"        except NotImplementedError:"},{"line_number":52,"context_line":"            frame \u003d traceback.extract_tb(sys.exc_info()[2])[-1]"},{"line_number":53,"context_line":"            LOG.error(_(\u0027%(driver)s does not implement %(method)s\u0027) % {"},{"line_number":54,"context_line":"                                               \u0027driver\u0027: type(self.connection),"},{"line_number":55,"context_line":"                                               \u0027method\u0027: frame[2]})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F966o%3D","line":53,"in_reply_to":"AAAATn%2F96%2FA%3D","updated":"2013-12-04 13:38:54.000000000","message":"Done","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"}],"nova/version.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9640eb4bc64a4733614b8aa7a74d46235956d615","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.openstack.common.gettextutils import _"},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9r9Y%3D","line":17,"updated":"2013-12-07 17:07:21.000000000","message":"this is in a different section to the pbr.\n\ni think that it should be:\n\nimport pbr.version\n\nfrom nova.openstack.common.gettextutils import _","commit_id":"61530c0ed268b94fb046160373be9116dd3d09a9"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"0b2f99ee2acbcda5103606b34772a2d1d6c9ccfa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.openstack.common.gettextutils import _"},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9r6c%3D","line":17,"in_reply_to":"AAAATn%2F9r9Y%3D","updated":"2013-12-07 18:18:27.000000000","message":"Done","commit_id":"61530c0ed268b94fb046160373be9116dd3d09a9"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"093bd74f6cf18d3ed9b31c7c08831f359e2cc70d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.openstack.common.gettextutils import _"},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"NOVA_VENDOR \u003d \"OpenStack Foundation\""},{"line_number":22,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sCI%3D","line":19,"updated":"2013-12-07 14:55:56.000000000","message":"nit: No need to add blanks space here","commit_id":"61530c0ed268b94fb046160373be9116dd3d09a9"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"0b2f99ee2acbcda5103606b34772a2d1d6c9ccfa","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.openstack.common.gettextutils import _"},{"line_number":18,"context_line":"import pbr.version"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"NOVA_VENDOR \u003d \"OpenStack Foundation\""},{"line_number":22,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9r6Y%3D","line":19,"in_reply_to":"AAAATn%2F9sCI%3D","updated":"2013-12-07 18:18:27.000000000","message":"Done","commit_id":"61530c0ed268b94fb046160373be9116dd3d09a9"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"00155eda4e1f0ca3400af8796941c737c7a443a8","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            self.__class__.can_fallocate \u003d can_fallocate"},{"line_number":208,"context_line":"            if not can_fallocate:"},{"line_number":209,"context_line":"                LOG.error(_(\u0027Unable to preallocate_images\u003d%(imgs)s at path: \u0027"},{"line_number":210,"context_line":"                            \u0027%(path)s\u0027) % {\u0027imgs\u0027: CONF.preallocate_images,"},{"line_number":211,"context_line":"                                           \u0027path\u0027: self.path})"},{"line_number":212,"context_line":"        return can_fallocate"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96%2B8%3D","line":210,"updated":"2013-12-04 13:13:42.000000000","message":"please use a comma","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"91e7194ec96dc9e401ddda93f9ce513b7dd0247d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            self.__class__.can_fallocate \u003d can_fallocate"},{"line_number":208,"context_line":"            if not can_fallocate:"},{"line_number":209,"context_line":"                LOG.error(_(\u0027Unable to preallocate_images\u003d%(imgs)s at path: \u0027"},{"line_number":210,"context_line":"                            \u0027%(path)s\u0027) % {\u0027imgs\u0027: CONF.preallocate_images,"},{"line_number":211,"context_line":"                                           \u0027path\u0027: self.path})"},{"line_number":212,"context_line":"        return can_fallocate"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9658%3D","line":210,"in_reply_to":"AAAATn%2F96%2B8%3D","updated":"2013-12-04 13:38:54.000000000","message":"Done","commit_id":"4126563996f21fa1e4a83d5e4f9df7828a1f0d79"}]}