)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"6e1f2cc3ba57ffb201d6526827411dfed298e30d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Dynamically adding or removing a device needs to be synchronized"},{"line_number":10,"context_line":"to work around a bug in XenServer 6.1 and 6.2 where simultaneous"},{"line_number":11,"context_line":"events can be partially ignored, leading to a failure to plug or"},{"line_number":12,"context_line":"unplug."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change I041365ed863a1a1c55e88025dff42d01c35494a2 attempted to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9aBo%3D","line":11,"updated":"2013-12-11 20:55:51.000000000","message":"I\u0027m trying to understand the scope of the bug.\n\nSo there is a per-VM race condition with respect to processing events?\n\nYou are defining event as a XAPI call like \"VBD.plug\" or \"VIF.unplug\", etc?","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"37e9be3713e0803f7747a9f46f0e7741cc5e5357","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Dynamically adding or removing a device needs to be synchronized"},{"line_number":10,"context_line":"to work around a bug in XenServer 6.1 and 6.2 where simultaneous"},{"line_number":11,"context_line":"events can be partially ignored, leading to a failure to plug or"},{"line_number":12,"context_line":"unplug."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change I041365ed863a1a1c55e88025dff42d01c35494a2 attempted to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9WmE%3D","line":11,"in_reply_to":"AAAATn%2F9aBo%3D","updated":"2013-12-12 10:58:35.000000000","message":"Yes - Updated explanation","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"6e1f2cc3ba57ffb201d6526827411dfed298e30d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Change I041365ed863a1a1c55e88025dff42d01c35494a2 attempted to"},{"line_number":15,"context_line":"work around the issue by retrying - however that does not catch"},{"line_number":16,"context_line":"all failures.  This change should eliminate some of the known"},{"line_number":17,"context_line":"INTERNAL_ERROR failures, but not all, so I041 should not be"},{"line_number":18,"context_line":"reverted."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change Ie7a64c481a9e3874df9d5924fbb050ac7ab117db does the same"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9aBY%3D","line":17,"updated":"2013-12-11 20:55:51.000000000","message":"This is confusing.  The commit you\u0027re referencing is abandoned so this verbiage should not be in the commit message.  Perhaps it is better in discussion on the bug itself?","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"37e9be3713e0803f7747a9f46f0e7741cc5e5357","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Change I041365ed863a1a1c55e88025dff42d01c35494a2 attempted to"},{"line_number":15,"context_line":"work around the issue by retrying - however that does not catch"},{"line_number":16,"context_line":"all failures.  This change should eliminate some of the known"},{"line_number":17,"context_line":"INTERNAL_ERROR failures, but not all, so I041 should not be"},{"line_number":18,"context_line":"reverted."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change Ie7a64c481a9e3874df9d5924fbb050ac7ab117db does the same"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9WnA%3D","line":17,"in_reply_to":"AAAATn%2F9aBY%3D","updated":"2013-12-12 10:58:35.000000000","message":"Sorry - I should have referenced I7b86325714e38b00a2f51bbf083b5532a6c51fa9 which was the change that was accepted.\nWill update the commit message.","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d92c39f83ece84bc3169a21d0afe24b4763152d2","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            err \u003d\u003d \u0027INTERNAL_ERROR\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def unplug_vbd(session, vbd_ref, this_vm_ref):"},{"line_number":416,"context_line":"    max_attempts \u003d CONF.xenserver.num_vbd_unplug_retries + 1"},{"line_number":417,"context_line":"    for num_attempt in xrange(1, max_attempts + 1):"},{"line_number":418,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F96S0%3D","line":415,"updated":"2013-12-04 16:17:11.000000000","message":"Should we just move this into volume_utils to be more consistent with unplug?","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"37e9be3713e0803f7747a9f46f0e7741cc5e5357","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            err \u003d\u003d \u0027INTERNAL_ERROR\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def unplug_vbd(session, vbd_ref, this_vm_ref):"},{"line_number":416,"context_line":"    max_attempts \u003d CONF.xenserver.num_vbd_unplug_retries + 1"},{"line_number":417,"context_line":"    for num_attempt in xrange(1, max_attempts + 1):"},{"line_number":418,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Wlw%3D","line":415,"in_reply_to":"AAAATn%2F96S0%3D","updated":"2013-12-12 10:58:35.000000000","message":"It makes sense here too because it\u0027s only used here.  Anyway, I\u0027m happy for it to be moved but any refactor should be a separate change.","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"}],"nova/virt/xenapi/volume_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d92c39f83ece84bc3169a21d0afe24b4763152d2","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def vbd_plug(session, vbd_ref, vm_ref):"},{"line_number":318,"context_line":"    @utils.synchronized(\u0027xenapi-events-\u0027 + vm_ref)"},{"line_number":319,"context_line":"    def synchronized_plug():"},{"line_number":320,"context_line":"        session.call_xenapi(\"VBD.plug\", vbd_ref)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F96T4%3D","line":318,"updated":"2013-12-04 16:17:11.000000000","message":"I would rather see it be scoped to vbd","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3070738c60711235eeb51fe515addfdf73483f75","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def vbd_plug(session, vbd_ref, vm_ref):"},{"line_number":318,"context_line":"    @utils.synchronized(\u0027xenapi-events-\u0027 + vm_ref)"},{"line_number":319,"context_line":"    def synchronized_plug():"},{"line_number":320,"context_line":"        session.call_xenapi(\"VBD.plug\", vbd_ref)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F92FE%3D","line":318,"in_reply_to":"AAAATn%2F96T4%3D","updated":"2013-12-05 10:21:12.000000000","message":"The issue is for all hotplug events - including vifs if we were hotplugging them.\n\nWe\u0027re not currently hotplugging VIFs into the control domain, but I think this scoping is appropriate given the underlying issue.","commit_id":"f721a766e6b81023f7b72fc77fb7896462871261"}]}