)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e6d6912e46dce75b49c1baf10ea64b733d755d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a log message in the scheduler which dumps all instances"},{"line_number":10,"context_line":"running on a compute host. There are at least 2 problems with this:"},{"line_number":11,"context_line":"1. it generates huge amount of logs which are not really useful"},{"line_number":12,"context_line":"2. it crashes when there is an instance with non-ascii name"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead of fixing 2), just print instance count."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9d5cf97d","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":63},"updated":"2018-09-05 18:37:59.000000000","message":"This is arguable depending on the filters being used. The affinity filters and same/different host filters come to mind.\n\nSince I766bb5645e3b598468d092fb9e4f18e720617c52 we only really care about the UUIDs for the in-tree filters anyway. So I think at a minimum, rather than just log the count, we should log the UUIDs, which will avoid the non-ascii name issue as well.","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e6d6912e46dce75b49c1baf10ea64b733d755d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a log message in the scheduler which dumps all instances"},{"line_number":10,"context_line":"running on a compute host. There are at least 2 problems with this:"},{"line_number":11,"context_line":"1. it generates huge amount of logs which are not really useful"},{"line_number":12,"context_line":"2. it crashes when there is an instance with non-ascii name"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead of fixing 2), just print instance count."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_dd2fd1f3","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":35},"updated":"2018-09-05 18:37:59.000000000","message":"True, see https://review.openstack.org/#/c/366283/ and bug 1620692.","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e6d6912e46dce75b49c1baf10ea64b733d755d3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead of fixing 2), just print instance count."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1790126"},{"line_number":17,"context_line":"Change-Id: I0eda1c58a7eb54121230c880818b4b1d0fdf4893"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3d55a550","line":16,"updated":"2018-09-05 18:37:59.000000000","message":"Let\u0027s add Related-Bug: #1620692","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"91dbbea7db76263c1fc3de2532125fa031ca7698","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead of fixing 2), just print instance count."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1790126"},{"line_number":17,"context_line":"Change-Id: I0eda1c58a7eb54121230c880818b4b1d0fdf4893"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_53ccec68","line":16,"in_reply_to":"3f79a3b5_3d55a550","updated":"2018-09-07 07:05:35.000000000","message":"Done","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e6d6912e46dce75b49c1baf10ea64b733d755d3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                LOG.debug(\"Update host state with service dict: %s\", service)"},{"line_number":178,"context_line":"                self.service \u003d ReadOnlyDict(service)"},{"line_number":179,"context_line":"            if inst_dict is not None:"},{"line_number":180,"context_line":"                LOG.debug(\"Update host state with %d instance(s)\","},{"line_number":181,"context_line":"                          len(inst_dict))"},{"line_number":182,"context_line":"                self.instances \u003d inst_dict"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return _locked_update(self, compute, service, aggregates, inst_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7dcc7d33","line":181,"range":{"start_line":180,"start_character":16,"end_line":181,"end_character":41},"updated":"2018-09-05 18:37:59.000000000","message":"As noted in the commit message, we should at least log the UUIDs since the affinity filters rely on those so it could be useful for debugging.","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"91dbbea7db76263c1fc3de2532125fa031ca7698","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                LOG.debug(\"Update host state with service dict: %s\", service)"},{"line_number":178,"context_line":"                self.service \u003d ReadOnlyDict(service)"},{"line_number":179,"context_line":"            if inst_dict is not None:"},{"line_number":180,"context_line":"                LOG.debug(\"Update host state with %d instance(s)\","},{"line_number":181,"context_line":"                          len(inst_dict))"},{"line_number":182,"context_line":"                self.instances \u003d inst_dict"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return _locked_update(self, compute, service, aggregates, inst_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_13c2f434","line":181,"range":{"start_line":180,"start_character":16,"end_line":181,"end_character":41},"in_reply_to":"3f79a3b5_7dcc7d33","updated":"2018-09-07 07:05:35.000000000","message":"Done","commit_id":"b593e0161e0c7d31237219637b33104a0928413d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ada841a3a8b55a59a8c5d84b1f43974fa8ed6649","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                self.service \u003d ReadOnlyDict(service)"},{"line_number":179,"context_line":"            if inst_dict is not None:"},{"line_number":180,"context_line":"                LOG.debug(\"Update host state with instances: %s\","},{"line_number":181,"context_line":"                          inst_dict.keys())"},{"line_number":182,"context_line":"                self.instances \u003d inst_dict"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return _locked_update(self, compute, service, aggregates, inst_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_598acabb","line":181,"range":{"start_line":181,"start_character":26,"end_line":181,"end_character":42},"updated":"2018-09-07 12:26:14.000000000","message":"idk if inst_dict is actually a dict or if it has an override for (the magic method under) keys(), but in py3 this will display as \u0027dict_keys([...])\u0027. Consider using list(inst_dict) instead.\n\n(I originally thought it printed something really unhelpful like \u0027\u003citerator at 0x...\u003e\u0027, which would have been worth a -1, but this at least still has the intended information in it, so...)","commit_id":"9c49db8ceba5dd59e5af7d263cbfbde057f30972"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"cb4d17924fe13c4de9c6bdcb8716d54a7d62c5e2","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                self.service \u003d ReadOnlyDict(service)"},{"line_number":179,"context_line":"            if inst_dict is not None:"},{"line_number":180,"context_line":"                LOG.debug(\"Update host state with instances: %s\","},{"line_number":181,"context_line":"                          inst_dict.keys())"},{"line_number":182,"context_line":"                self.instances \u003d inst_dict"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return _locked_update(self, compute, service, aggregates, inst_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_349b5373","line":181,"range":{"start_line":181,"start_character":26,"end_line":181,"end_character":42},"in_reply_to":"3f79a3b5_598acabb","updated":"2018-09-07 12:56:02.000000000","message":"Agree, changed it to list(inst_dict)","commit_id":"9c49db8ceba5dd59e5af7d263cbfbde057f30972"}]}