)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"3a345f2959295229ed2528f0f4925d0d9f5d0427","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when add/remove a host to one aggregate or update aggregate"},{"line_number":10,"context_line":"metadata incluing availability_zone, \"OS-EXT-AZ:availability_zone\""},{"line_number":11,"context_line":"property of sone instances in the host can not show correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The cause is that when getting availability_zone of one instance"},{"line_number":14,"context_line":", it will try to get the value from cache first, but unfortunately"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F900E%3D","line":11,"updated":"2013-12-05 14:48:43.000000000","message":"typo","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"2a3548766a00a7937a55972a8a88f4616e1fa7aa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when add/remove a host to one aggregate or update aggregate"},{"line_number":10,"context_line":"metadata incluing availability_zone, \"OS-EXT-AZ:availability_zone\""},{"line_number":11,"context_line":"property of sone instances in the host can not show correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The cause is that when getting availability_zone of one instance"},{"line_number":14,"context_line":", it will try to get the value from cache first, but unfortunately"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9rig%3D","line":11,"in_reply_to":"AAAATn%2F900E%3D","updated":"2013-12-08 04:31:06.000000000","message":"Thanks, will change it.","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"edc64eea4400960ee8c5f67ea0af6dd09fee21b9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"property of some instances in the host can not show correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The cause is that when getting availability_zone of one instance"},{"line_number":14,"context_line":", it will try to get the value from cache first, but unfortunately"},{"line_number":15,"context_line":"the cache does not update or reset in time, and it will keep one"},{"line_number":16,"context_line":"hour if we do not change it."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F8480%3D","line":14,"updated":"2013-12-19 05:34:18.000000000","message":"I think the comma was supposed to be next to the above word \"instance.\"","commit_id":"16f1293815fd06e50c4fd51ec24cd7d464f860b0"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"83b98a5b7cc6ec6ebfb5de18844981b2ea85e6a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"property of some instances in the host can not show correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The cause is that when getting availability_zone of one instance"},{"line_number":14,"context_line":", it will try to get the value from cache first, but unfortunately"},{"line_number":15,"context_line":"the cache does not update or reset in time, and it will keep one"},{"line_number":16,"context_line":"hour if we do not change it."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F847c%3D","line":14,"in_reply_to":"AAAATn%2F8480%3D","updated":"2013-12-19 05:43:21.000000000","message":"Thanks, Melanie, will change it asap.","commit_id":"16f1293815fd06e50c4fd51ec24cd7d464f860b0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"edc64eea4400960ee8c5f67ea0af6dd09fee21b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hour if we do not change it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch will add update or reset after adding/removing a host"},{"line_number":19,"context_line":"to one aggregate or updating aggregate metadata incluing"},{"line_number":20,"context_line":"availability_zone."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5dd07f876471b5faf8fb1016e25a861124b7cb6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F8484%3D","line":19,"updated":"2013-12-19 05:34:18.000000000","message":"typo s/incluing/including/","commit_id":"16f1293815fd06e50c4fd51ec24cd7d464f860b0"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"83b98a5b7cc6ec6ebfb5de18844981b2ea85e6a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hour if we do not change it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch will add update or reset after adding/removing a host"},{"line_number":19,"context_line":"to one aggregate or updating aggregate metadata incluing"},{"line_number":20,"context_line":"availability_zone."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5dd07f876471b5faf8fb1016e25a861124b7cb6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F847Y%3D","line":19,"in_reply_to":"AAAATn%2F8484%3D","updated":"2013-12-19 05:43:21.000000000","message":"Thanks, Melanie, will change it asap.","commit_id":"16f1293815fd06e50c4fd51ec24cd7d464f860b0"}],"nova/compute/api.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"3a345f2959295229ed2528f0f4925d0d9f5d0427","unresolved":false,"context_lines":[{"line_number":3182,"context_line":"        # If updated metadata include availability_zones, then the cache"},{"line_number":3183,"context_line":"        # which stored availability_zones and host need to be reset"},{"line_number":3184,"context_line":"        if metadata and metadata.get(\u0027availability_zone\u0027):"},{"line_number":3185,"context_line":"            availability_zones.reset_cache()"},{"line_number":3186,"context_line":"        return aggregate"},{"line_number":3187,"context_line":""},{"line_number":3188,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F902w%3D","line":3185,"updated":"2013-12-05 14:48:43.000000000","message":"reset_cache() will lead to cache refreshing, right? whether it will increase db access in timeframe without cache?","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"2a3548766a00a7937a55972a8a88f4616e1fa7aa","unresolved":false,"context_lines":[{"line_number":3182,"context_line":"        # If updated metadata include availability_zones, then the cache"},{"line_number":3183,"context_line":"        # which stored availability_zones and host need to be reset"},{"line_number":3184,"context_line":"        if metadata and metadata.get(\u0027availability_zone\u0027):"},{"line_number":3185,"context_line":"            availability_zones.reset_cache()"},{"line_number":3186,"context_line":"        return aggregate"},{"line_number":3187,"context_line":""},{"line_number":3188,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9ris%3D","line":3185,"in_reply_to":"AAAATn%2F902w%3D","updated":"2013-12-08 04:31:06.000000000","message":"Hi, Tao, you are right, I known it too, this code is a trade-off, if aggregate have many hosts, we can just update cache of these hosts instead of reset cache. then we need add much db access to get the hosts of the aggregate and get availability_zone of these hosts. the cache can only keep one hour. after one hour, it will reset too, if we do not need to show instance detail too much time and not too many instances in many different hosts. I think it is better using reset_cache() as exist function update_aggregate. Thanks, :)","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"3a345f2959295229ed2528f0f4925d0d9f5d0427","unresolved":false,"context_lines":[{"line_number":3242,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3243,"context_line":"        # availability_zone in cache retention time."},{"line_number":3244,"context_line":"        availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3245,"context_line":"                                                               host_name)"},{"line_number":3246,"context_line":"        #NOTE(jogo): Send message to host to support resource pools"},{"line_number":3247,"context_line":"        self.compute_rpcapi.add_aggregate_host(context,"},{"line_number":3248,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F904s%3D","line":3245,"updated":"2013-12-05 14:48:43.000000000","message":"Aggregate may be not an availability zone, so when adding a host into an aggregate, AZ cache update operation mayn\u0027t necessary, I think you should check whether the aggragate is an AZ","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"2a3548766a00a7937a55972a8a88f4616e1fa7aa","unresolved":false,"context_lines":[{"line_number":3242,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3243,"context_line":"        # availability_zone in cache retention time."},{"line_number":3244,"context_line":"        availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3245,"context_line":"                                                               host_name)"},{"line_number":3246,"context_line":"        #NOTE(jogo): Send message to host to support resource pools"},{"line_number":3247,"context_line":"        self.compute_rpcapi.add_aggregate_host(context,"},{"line_number":3248,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9rio%3D","line":3245,"in_reply_to":"AAAATn%2F904s%3D","updated":"2013-12-08 04:31:06.000000000","message":"you are right, will change it. Thanks","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"3a345f2959295229ed2528f0f4925d0d9f5d0427","unresolved":false,"context_lines":[{"line_number":3266,"context_line":"        aggregate.delete_host(host_name)"},{"line_number":3267,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3268,"context_line":"        # availability_zone in cache retention time."},{"line_number":3269,"context_line":"        availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3270,"context_line":"                                                               host_name)"},{"line_number":3271,"context_line":"        self.compute_rpcapi.remove_aggregate_host(context,"},{"line_number":3272,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F904k%3D","line":3269,"updated":"2013-12-05 14:48:43.000000000","message":"ditto","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"2a3548766a00a7937a55972a8a88f4616e1fa7aa","unresolved":false,"context_lines":[{"line_number":3266,"context_line":"        aggregate.delete_host(host_name)"},{"line_number":3267,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3268,"context_line":"        # availability_zone in cache retention time."},{"line_number":3269,"context_line":"        availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3270,"context_line":"                                                               host_name)"},{"line_number":3271,"context_line":"        self.compute_rpcapi.remove_aggregate_host(context,"},{"line_number":3272,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9rik%3D","line":3269,"in_reply_to":"AAAATn%2F904k%3D","updated":"2013-12-08 04:31:06.000000000","message":"you are right, will change it. Thanks","commit_id":"e63d4e06c1dd78450c3ac2c3a32bc8d7eea76e79"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3154fb2f39a39b2172401347eedbf53c91a0d585","unresolved":false,"context_lines":[{"line_number":3245,"context_line":"        aggregate.add_host(context, host_name)"},{"line_number":3246,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3247,"context_line":"        # availability_zone in cache retention time."},{"line_number":3248,"context_line":"        if aggregate.metadata and aggregate.metadata.get(\u0027availability_zone\u0027):"},{"line_number":3249,"context_line":"            availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3250,"context_line":"                                                                   host_name)"},{"line_number":3251,"context_line":"        #NOTE(jogo): Send message to host to support resource pools"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8z%2F0%3D","line":3248,"updated":"2013-12-20 02:34:08.000000000","message":"this can be made DRYer","commit_id":"2bfff41d8d9f0210e38542d0084c057b411032cd"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"f198d53626d0b47f7db3f951e41b3fc77584725d","unresolved":false,"context_lines":[{"line_number":3245,"context_line":"        aggregate.add_host(context, host_name)"},{"line_number":3246,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3247,"context_line":"        # availability_zone in cache retention time."},{"line_number":3248,"context_line":"        if aggregate.metadata and aggregate.metadata.get(\u0027availability_zone\u0027):"},{"line_number":3249,"context_line":"            availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3250,"context_line":"                                                                   host_name)"},{"line_number":3251,"context_line":"        #NOTE(jogo): Send message to host to support resource pools"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F9X4%3D","line":3248,"in_reply_to":"AAAATn%2F8z%2F0%3D","updated":"2013-12-26 09:51:28.000000000","message":"good, will change it, Thanks","commit_id":"2bfff41d8d9f0210e38542d0084c057b411032cd"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3154fb2f39a39b2172401347eedbf53c91a0d585","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3273,"context_line":"        # availability_zone in cache retention time."},{"line_number":3274,"context_line":"        if aggregate.metadata and aggregate.metadata.get(\u0027availability_zone\u0027):"},{"line_number":3275,"context_line":"            availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3276,"context_line":"                                                                   host_name)"},{"line_number":3277,"context_line":"        self.compute_rpcapi.remove_aggregate_host(context,"},{"line_number":3278,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8z%2Fk%3D","line":3275,"updated":"2013-12-20 02:34:08.000000000","message":"duplicate code","commit_id":"2bfff41d8d9f0210e38542d0084c057b411032cd"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"f198d53626d0b47f7db3f951e41b3fc77584725d","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"        # Update the availability_zone cache to avoid getting wrong"},{"line_number":3273,"context_line":"        # availability_zone in cache retention time."},{"line_number":3274,"context_line":"        if aggregate.metadata and aggregate.metadata.get(\u0027availability_zone\u0027):"},{"line_number":3275,"context_line":"            availability_zones.update_host_availability_zone_cache(context,"},{"line_number":3276,"context_line":"                                                                   host_name)"},{"line_number":3277,"context_line":"        self.compute_rpcapi.remove_aggregate_host(context,"},{"line_number":3278,"context_line":"                aggregate\u003daggregate, host_param\u003dhost_name, host\u003dhost_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F9Xw%3D","line":3275,"in_reply_to":"AAAATn%2F8z%2Fk%3D","updated":"2013-12-26 09:51:28.000000000","message":"will change it, Thanks","commit_id":"2bfff41d8d9f0210e38542d0084c057b411032cd"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"5c2f6e2d5a3a5c0271e6eb4c008cf032281f7d7d","unresolved":false,"context_lines":[{"line_number":3196,"context_line":"        if values:"},{"line_number":3197,"context_line":"            aggregate.metadata \u003d values"},{"line_number":3198,"context_line":"        aggregate.save()"},{"line_number":3199,"context_line":""},{"line_number":3200,"context_line":"        # If updated values include availability_zones, then the cache"},{"line_number":3201,"context_line":"        # which stored availability_zones and host need to be reset"},{"line_number":3202,"context_line":"        if values.get(\u0027availability_zone\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F4iw%3D","side":"PARENT","line":3199,"updated":"2013-12-28 06:19:11.000000000","message":"nit. this does not related to your patch","commit_id":"3d19edc023e34c73cbaed60bf1fb0c9dc287fb89"}]}