)]}'
{"nova/api/openstack/compute/contrib/admin_actions.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"3bb425c59920e53bfb5514eeb8646b4ce56bb799","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    \"be specified for live migration.\")"},{"line_number":310,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        block_migration \u003d strutils.bool_from_string(block_migration)"},{"line_number":313,"context_line":"        disk_over_commit \u003d strutils.bool_from_string(disk_over_commit)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F92zo%3D","line":312,"updated":"2013-12-05 07:14:44.000000000","message":"It is better to handle exception ValueError() here","commit_id":"fd964a34aaad0bdcfd1274e56ace8fb883e3ceb5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8a58031cc6aa3c263831475fb8b53c452d89648b","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    \"be specified for live migration.\")"},{"line_number":310,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        block_migration \u003d strutils.bool_from_string(block_migration)"},{"line_number":313,"context_line":"        disk_over_commit \u003d strutils.bool_from_string(disk_over_commit)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F92UM%3D","line":312,"in_reply_to":"AAAATn%2F92uU%3D","updated":"2013-12-05 09:23:03.000000000","message":"That would be good idea, thanks.\n\nI will change them.","commit_id":"fd964a34aaad0bdcfd1274e56ace8fb883e3ceb5"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"1441aee81907c516405b79c79fbe0d01f3bfe031","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    \"be specified for live migration.\")"},{"line_number":310,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        block_migration \u003d strutils.bool_from_string(block_migration)"},{"line_number":313,"context_line":"        disk_over_commit \u003d strutils.bool_from_string(disk_over_commit)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F92uU%3D","line":312,"in_reply_to":"AAAATn%2F92wM%3D","updated":"2013-12-05 07:43:06.000000000","message":"Thanks for pointing this out.\n\nI think that it is better adding strict\u003dTrue for such case to handle some exceptions. Otherwise, users might be confused by some options, as \"strutils.bool_from_string(block_migration)\" will treat all values except TRUE_STRINGS and FALSE_STRINGS as false, it might be a bit ambiguous. Comments?","commit_id":"fd964a34aaad0bdcfd1274e56ace8fb883e3ceb5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a72446c17413900559ff6cc1f3ccdc74d8ff0f42","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    \"be specified for live migration.\")"},{"line_number":310,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        block_migration \u003d strutils.bool_from_string(block_migration)"},{"line_number":313,"context_line":"        disk_over_commit \u003d strutils.bool_from_string(disk_over_commit)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F92wM%3D","line":312,"in_reply_to":"AAAATn%2F92zo%3D","updated":"2013-12-05 07:33:02.000000000","message":"Thanks for review.\n\nbut ValueError() does not happens because of not specifying \"strict\u003dTrue\" as bool_from_string() argument, I guess.","commit_id":"fd964a34aaad0bdcfd1274e56ace8fb883e3ceb5"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"d47164a2b9d90d010cd3c25b15c866376bc434b3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                                        strict\u003dTrue)"},{"line_number":319,"context_line":"            disk_over_commit \u003d strutils.bool_from_string(disk_over_commit,"},{"line_number":320,"context_line":"                                                         strict\u003dTrue)"},{"line_number":321,"context_line":"        except ValueError:"},{"line_number":322,"context_line":"            msg \u003d _(\"block_migration and disk_over_commit must be specified \""},{"line_number":323,"context_line":"                    \"with boolean or string which shows boolean(e.g. \u0027True\u0027, \""},{"line_number":324,"context_line":"                    \"\u0027False\u0027).\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9b5M%3D","line":321,"updated":"2013-12-11 14:54:29.000000000","message":"I think we can use the exception as log message directly.\n\nexcept ValueError as err:\n    raise exc.HTTPBadRequest(explanation\u003dstr(err))\n\nYou can always get some idea by searching \"strutils.bool_from_string\" to see what others are doing with this exception. ;-)","commit_id":"baad80e86bf5553b08eb9bfc26d6696bf2ac8509"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2f36b9d97574a49a18db1b71c3e68400e64fae12","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                                        strict\u003dTrue)"},{"line_number":319,"context_line":"            disk_over_commit \u003d strutils.bool_from_string(disk_over_commit,"},{"line_number":320,"context_line":"                                                         strict\u003dTrue)"},{"line_number":321,"context_line":"        except ValueError:"},{"line_number":322,"context_line":"            msg \u003d _(\"block_migration and disk_over_commit must be specified \""},{"line_number":323,"context_line":"                    \"with boolean or string which shows boolean(e.g. \u0027True\u0027, \""},{"line_number":324,"context_line":"                    \"\u0027False\u0027).\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Ycw%3D","line":321,"in_reply_to":"AAAATn%2F9b5M%3D","updated":"2013-12-12 02:44:36.000000000","message":"OK, will change here as you said. Thanks!","commit_id":"baad80e86bf5553b08eb9bfc26d6696bf2ac8509"}],"nova/api/openstack/compute/plugins/v3/admin_actions.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"1d3d136501112257c1e436dab196f1365ccaab03","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                         strict\u003dTrue)"},{"line_number":295,"context_line":"        except ValueError:"},{"line_number":296,"context_line":"            msg \u003d _(\"block_migration and disk_over_commit must be specified \""},{"line_number":297,"context_line":"                    \"with boolean or string \u0027True\u0027 or \u0027False\u0027.\")"},{"line_number":298,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ijM%3D","line":297,"updated":"2013-12-10 13:12:35.000000000","message":"From the comments of strutils.bool_from_string(), it seems that it will treat many values as boolean True.\n\n A case-insensitive match is performed such that strings matching \u0027t\u0027,\n    \u0027true\u0027, \u0027on\u0027, \u0027y\u0027, \u0027yes\u0027, or \u00271\u0027 are considered True and, when\n    `strict\u003dFalse`, anything else is considered False.","commit_id":"7be048ae03720edd084cdde7863d50850a1a621b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"22a9a8fe9b6d86ae38afac7deb245f7ddabbda9a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                         strict\u003dTrue)"},{"line_number":295,"context_line":"        except ValueError:"},{"line_number":296,"context_line":"            msg \u003d _(\"block_migration and disk_over_commit must be specified \""},{"line_number":297,"context_line":"                    \"with boolean or string \u0027True\u0027 or \u0027False\u0027.\")"},{"line_number":298,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9fMs%3D","line":297,"in_reply_to":"AAAATn%2F9ijM%3D","updated":"2013-12-11 00:47:48.000000000","message":"I know, but if writing all them, the error message would be unreadable :-(\n\nHow about the following?\n\n block_migration and disk_over_commit must be specified\n with boolean or string which shows boolean(e.g. \u0027True\u0027, \u0027\u0027False).","commit_id":"7be048ae03720edd084cdde7863d50850a1a621b"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"d47164a2b9d90d010cd3c25b15c866376bc434b3","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            disk_over_commit \u003d strutils.bool_from_string(disk_over_commit,"},{"line_number":298,"context_line":"                                                         strict\u003dTrue)"},{"line_number":299,"context_line":"        except ValueError:"},{"line_number":300,"context_line":"            msg \u003d _(\"block_migration and disk_over_commit must be specified \""},{"line_number":301,"context_line":"                    \"with boolean or string which shows boolean(e.g. \u0027True\u0027, \""},{"line_number":302,"context_line":"                    \"\u0027False\u0027).\")"},{"line_number":303,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9b4A%3D","line":300,"updated":"2013-12-11 14:54:29.000000000","message":"ditto","commit_id":"baad80e86bf5553b08eb9bfc26d6696bf2ac8509"}]}