)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a669cf48ef838852631674178e4d28037f1bc0df","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The other image cache fields that were in the nova.compute.manager"},{"line_number":13,"context_line":"have also been moved to the common place."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"These common configuration can be used by the"},{"line_number":18,"context_line":"blueprint multiple-image-cache-handlers and the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9tMg%3D","line":15,"updated":"2013-12-06 21:51:32.000000000","message":"I think this docimpact can be improved. You should at the least list the flags moved, and what group they are now in.","commit_id":"fa410cebdfcc3ecea68c94b00af2797ad6fc6c45"}],"nova/virt/imagecache.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8bf6509e407590bbca66e55b5c28e1bfbbb0847d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.corrupt_base_files \u003d []"},{"line_number":71,"context_line":"        self.originals \u003d []"},{"line_number":72,"context_line":"        self.removable_base_files \u003d []"},{"line_number":73,"context_line":"        self.unexplained_images \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_base(self):"},{"line_number":76,"context_line":"        \"\"\"Returns the base directory of the cached images.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9mc0%3D","line":73,"updated":"2013-12-09 19:39:05.000000000","message":"By having these variables here you are assuming that any image cache manager which is implemented will use these values. I\u0027m not sure that\u0027s true -- for example I might use a least used algorithm or something that isn\u0027t expressable with these. Perhaps these should be pushed into the libvirt implementation?","commit_id":"e9597bd66b5f577f1e17e531a39bf486cac2913f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"65a7d1589a6edd27061113e11f2ef65d3959a3cb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.corrupt_base_files \u003d []"},{"line_number":71,"context_line":"        self.originals \u003d []"},{"line_number":72,"context_line":"        self.removable_base_files \u003d []"},{"line_number":73,"context_line":"        self.unexplained_images \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_base(self):"},{"line_number":76,"context_line":"        \"\"\"Returns the base directory of the cached images.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9jkQ%3D","line":73,"in_reply_to":"AAAATn%2F9mc0%3D","updated":"2013-12-10 09:46:08.000000000","message":"I think that there are 2 approaches here:\n1.the first is to have each driver maintain their own data structures for the stats and do the aging internally\n2. the second is to have all of the general stats here and the aging algorithm here and expect the drivers to return the relevant structures.\nI am leaning to the second. The reason for this is that we can keep this code common and all of the drivers can leverage it.\nI\u0027ll make a post a little later and you can get a sense of what I am talking about. If you do not like that I\u0027ll revert","commit_id":"e9597bd66b5f577f1e17e531a39bf486cac2913f"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"a39473c88b1973a2c67b1bcff4905d39dd2f6ff4","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        raise NotImplementedError()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def cache_manager(self, context, all_instances):"},{"line_number":129,"context_line":"        \"\"\"The cache manager."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        This will invoke the cache manager. This will update the cache"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9chQ%3D","line":128,"updated":"2013-12-11 13:17:22.000000000","message":"Naming is a bit redundant here.\nPerhaps call it update() or manage()\nOr leave as is, it\u0027s a minor nit :)","commit_id":"e361e00abac70137a23bff4b0d9c873a302d153f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9dbb8f5bc89856c1a4453353edc3ed10e9faf170","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        raise NotImplementedError()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def cache_manager(self, context, all_instances):"},{"line_number":129,"context_line":"        \"\"\"The cache manager."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        This will invoke the cache manager. This will update the cache"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9Xxk%3D","line":128,"in_reply_to":"AAAATn%2F9chQ%3D","updated":"2013-12-12 06:02:47.000000000","message":"Done","commit_id":"e361e00abac70137a23bff4b0d9c873a302d153f"}]}