)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"46046a163a72a3a11e9d09bfce82734b7e63aaec","unresolved":false,"context_lines":[{"line_number":4445,"context_line":"            self._get_instance_nw_info(context, instance)"},{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception as e:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred:\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F94WY%3D","line":4448,"updated":"2013-12-04 22:38:07.000000000","message":"Get rid of the \u0027as e\u0027?","commit_id":"0a67a960a81b86c111c43be325a586aeecdb8c36"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b2242c89a1a2673d5b6cbc492ecc0dd11b42d9dc","unresolved":false,"context_lines":[{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred:\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"},{"line_number":4452,"context_line":"    def _poll_rebooting_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F94Vk%3D","line":4449,"updated":"2013-12-04 22:38:58.000000000","message":"Nit, but might as well lose the colon also.","commit_id":"b35019b276930fd26322399d7e58472287947f6b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"bc90422cd3ba66a7b0cd1a0e9800eb50f4f42fa0","unresolved":false,"context_lines":[{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred:\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"},{"line_number":4452,"context_line":"    def _poll_rebooting_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F94Ug%3D","line":4449,"in_reply_to":"AAAATn%2F94Vk%3D","updated":"2013-12-04 22:41:14.000000000","message":"Done","commit_id":"b35019b276930fd26322399d7e58472287947f6b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"55c94282b834670b49e712a866444abfca024f39","unresolved":false,"context_lines":[{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"},{"line_number":4452,"context_line":"    def _poll_rebooting_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94Rs%3D","line":4449,"updated":"2013-12-04 22:50:33.000000000","message":"An exception level is symptomatic of an error in the code; however, if you read the docstring for the method, it seems that originally the author wanted to disregard exceptions generated in _get_instance_nw_info (see https://review.openstack.org/#/c/57069/ for details). I am not sure exception gives you an awful lot more information; as for going undetected, I don\u0027t think it\u0027s true you need to know what you\u0027re looking for :)","commit_id":"2a1ed1c4fe93ef6e2d08c6c852d55ad5cfee9cbf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"83ce11e432cd6e4fb5ff03c0fe2a0962ce37f42f","unresolved":false,"context_lines":[{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"},{"line_number":4452,"context_line":"    def _poll_rebooting_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94Ns%3D","line":4449,"in_reply_to":"AAAATn%2F94Pw%3D","updated":"2013-12-04 23:07:59.000000000","message":"Any catch-all clause should be avoided altogether, but in this case it seems a tough call. A syntax error should have been caught by a UT, not by a post-execution inspection of the log :)\n\nThat said, I see what you\u0027re trying to do...I introduced the log trace in the first place. Going to exception level seems the next step if there\u0027s an underlying issue we cannot grasp.","commit_id":"2a1ed1c4fe93ef6e2d08c6c852d55ad5cfee9cbf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e3733aab5821dfed0bb46599fbe8fb816fc3a7ba","unresolved":false,"context_lines":[{"line_number":4446,"context_line":"            LOG.debug(_(\u0027Updated the info_cache for instance\u0027),"},{"line_number":4447,"context_line":"                      instance\u003dinstance)"},{"line_number":4448,"context_line":"        except Exception:"},{"line_number":4449,"context_line":"            LOG.exception(_(\"An error occurred\"))"},{"line_number":4450,"context_line":""},{"line_number":4451,"context_line":"    @periodic_task.periodic_task"},{"line_number":4452,"context_line":"    def _poll_rebooting_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94Pw%3D","line":4449,"in_reply_to":"AAAATn%2F94Rs%3D","updated":"2013-12-04 22:59:33.000000000","message":"The reason why I made this change is I\u0027m improving the behavior in _heal_instance_info_cache(). During this time i had introduced a syntax error in this code section that went completely unnoticed. I think any except: that doesn\u0027t catch a specific exception should be logged.\n\nIf the original author intended to disregard exceptions generated in _get_instance_nw_info() they should have explicitly caught those exceptions above rather than catching everything....","commit_id":"2a1ed1c4fe93ef6e2d08c6c852d55ad5cfee9cbf"}]}