)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a40b0f43545b995c0d93c65a288bcea669a14be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Attila Fazekas \u003cafazekas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-05 14:00:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Consider minimal I/O size when selecting cache type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"none\" cache type is not usable when a file-system"},{"line_number":10,"context_line":"has stricter alignment requirements, for example the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F91VM%3D","line":7,"updated":"2013-12-05 13:16:52.000000000","message":"please prefix this with libvirt:","commit_id":"3d01f3a4810d2266e03c13d19fb2d72600eb9887"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a40b0f43545b995c0d93c65a288bcea669a14be","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"        hasDirectIO \u003d True"},{"line_number":2318,"context_line":"        try:"},{"line_number":2319,"context_line":"            f \u003d os.open(testfile, os.O_CREAT | os.O_WRONLY | os.O_DIRECT)"},{"line_number":2320,"context_line":"            # Check is the writeing allowed with 512 byte alignment"},{"line_number":2321,"context_line":"            m \u003d mmap.mmap(-1, 512)"},{"line_number":2322,"context_line":"            m.write(r\"x\" * 512)"},{"line_number":2323,"context_line":"            os.write(f, m)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F91Vk%3D","line":2320,"updated":"2013-12-05 13:16:52.000000000","message":"writeing \u003d\u003e writing","commit_id":"3d01f3a4810d2266e03c13d19fb2d72600eb9887"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2784cb8964d72699ca6172912c3caaad17b5e2a7","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"            # Check is the write allowed with 512 byte alignment"},{"line_number":2321,"context_line":"            m \u003d mmap.mmap(-1, 512)"},{"line_number":2322,"context_line":"            m.write(r\"x\" * 512)"},{"line_number":2323,"context_line":"            os.write(f, m)"},{"line_number":2324,"context_line":"            os.close(f)"},{"line_number":2325,"context_line":"            LOG.debug(_(\"Path \u0027%(path)s\u0027 supports direct I/O\") %"},{"line_number":2326,"context_line":"                      {\u0027path\u0027: dirpath})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F90pY%3D","line":2323,"updated":"2013-12-05 15:13:30.000000000","message":"As noted in the previous review - you\u0027re not actually testing 512 byte alignment here. You\u0027re testing page size alignment which is 4k\n\nWhat you are testing is whether the filesystem accepts a minimum I/O size of 512 bytes length. I understand that\u0027s sufficient for our needs, but the comment you added is rather misleading as to what\u0027s being checked here. Please update to explain what we\u0027re really checking.\n\nWe should probably add testing of this functionality too.","commit_id":"b9c1621e5aab538411cb925649b2c51a59fc5def"}]}