)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12e599e8f40e582022924f0d28d1df0377f0d937","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"                                                         sign\u003dsign)"},{"line_number":1192,"context_line":"            if require_allocation_refresh:"},{"line_number":1193,"context_line":"                LOG.debug(\"Auto-correcting allocations.\")"},{"line_number":1194,"context_line":"                self.reportclient.update_instance_allocation(context, cn,"},{"line_number":1195,"context_line":"                                                             instance, sign)"},{"line_number":1196,"context_line":"            # new instance, update compute node resource usage:"},{"line_number":1197,"context_line":"            self._update_usage(self._get_usage_dict(instance), nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8625c80c","side":"PARENT","line":1194,"range":{"start_line":1194,"start_character":34,"end_line":1194,"end_character":60},"updated":"2018-09-14 23:08:05.000000000","message":"This is the only usage of this report client method. Kill it.","commit_id":"ffdd8098383a6d5502fbfa7c921633b24512aadf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e024843dce767839a43d9eeb5c399fdce876a394","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"                                                         sign\u003dsign)"},{"line_number":1192,"context_line":"            if require_allocation_refresh:"},{"line_number":1193,"context_line":"                LOG.debug(\"Auto-correcting allocations.\")"},{"line_number":1194,"context_line":"                self.reportclient.update_instance_allocation(context, cn,"},{"line_number":1195,"context_line":"                                                             instance, sign)"},{"line_number":1196,"context_line":"            # new instance, update compute node resource usage:"},{"line_number":1197,"context_line":"            self._update_usage(self._get_usage_dict(instance), nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ebbc726d","side":"PARENT","line":1194,"range":{"start_line":1194,"start_character":34,"end_line":1194,"end_character":60},"in_reply_to":"3f79a3b5_8625c80c","updated":"2018-09-17 09:18:34.000000000","message":"yes, please","commit_id":"ffdd8098383a6d5502fbfa7c921633b24512aadf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"86541cfc63df57e81d022407bf4264ff2938d55b","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"                                                         sign\u003dsign)"},{"line_number":1192,"context_line":"            if require_allocation_refresh:"},{"line_number":1193,"context_line":"                LOG.debug(\"Auto-correcting allocations.\")"},{"line_number":1194,"context_line":"                self.reportclient.update_instance_allocation(context, cn,"},{"line_number":1195,"context_line":"                                                             instance, sign)"},{"line_number":1196,"context_line":"            # new instance, update compute node resource usage:"},{"line_number":1197,"context_line":"            self._update_usage(self._get_usage_dict(instance), nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f902af0b","side":"PARENT","line":1194,"range":{"start_line":1194,"start_character":34,"end_line":1194,"end_character":60},"in_reply_to":"3f79a3b5_ebbc726d","updated":"2018-09-20 18:31:14.000000000","message":"https://review.openstack.org/604186","commit_id":"ffdd8098383a6d5502fbfa7c921633b24512aadf"}],"nova/tests/functional/compute/test_resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12e599e8f40e582022924f0d28d1df0377f0d937","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    @mock.patch(\u0027nova.compute.utils.is_volume_backed_instance\u0027,"},{"line_number":214,"context_line":"                new\u003dmock.Mock(return_value\u003dFalse))"},{"line_number":215,"context_line":"    @mock.patch(\u0027nova.objects.compute_node.ComputeNode.save\u0027, new\u003dmock.Mock())"},{"line_number":216,"context_line":"    def test_ironic_ocata_to_pike(self):"},{"line_number":217,"context_line":"        \"\"\"Check that when going from an Ocata installation with Ironic having"},{"line_number":218,"context_line":"        node\u0027s resource class attributes set, that we properly \"auto-heal\" the"},{"line_number":219,"context_line":"        inventory and allocation records in the placement API to account for"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_262cf4ff","side":"PARENT","line":216,"range":{"start_line":216,"start_character":8,"end_line":216,"end_character":33},"updated":"2018-09-14 23:08:05.000000000","message":"See gibi comments at https://review.openstack.org/#/c/591785/ (which I will now abandon)","commit_id":"ffdd8098383a6d5502fbfa7c921633b24512aadf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e024843dce767839a43d9eeb5c399fdce876a394","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    @mock.patch(\u0027nova.compute.utils.is_volume_backed_instance\u0027,"},{"line_number":214,"context_line":"                new\u003dmock.Mock(return_value\u003dFalse))"},{"line_number":215,"context_line":"    @mock.patch(\u0027nova.objects.compute_node.ComputeNode.save\u0027, new\u003dmock.Mock())"},{"line_number":216,"context_line":"    def test_ironic_ocata_to_pike(self):"},{"line_number":217,"context_line":"        \"\"\"Check that when going from an Ocata installation with Ironic having"},{"line_number":218,"context_line":"        node\u0027s resource class attributes set, that we properly \"auto-heal\" the"},{"line_number":219,"context_line":"        inventory and allocation records in the placement API to account for"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cbb73685","side":"PARENT","line":216,"range":{"start_line":216,"start_character":8,"end_line":216,"end_character":33},"in_reply_to":"3f79a3b5_262cf4ff","updated":"2018-09-17 09:18:34.000000000","message":"I think this patch is fine as it removes calling the periodic healing too.","commit_id":"ffdd8098383a6d5502fbfa7c921633b24512aadf"}]}