)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"f5558642563149a508bb213c43ca46e6c2817747","unresolved":false,"context_lines":[{"line_number":3674,"context_line":"                LOG.warning(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""},{"line_number":3679,"context_line":""},{"line_number":3680,"context_line":"            # NOTE(vish): create bdm here to avoid race condition"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F90tk%3D","line":3677,"updated":"2013-12-05 14:59:56.000000000","message":"As I know, difference between device_name and user input device is work as design, LOG.info is better than LOG.warning","commit_id":"93aeb619516b954ea128bb8a438fb4412fbe32f2"},{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"f222d957a65da1030d7dc400788bc65dfbc6ab0a","unresolved":false,"context_lines":[{"line_number":3674,"context_line":"                LOG.warning(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""},{"line_number":3679,"context_line":""},{"line_number":3680,"context_line":"            # NOTE(vish): create bdm here to avoid race condition"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9z7c%3D","line":3677,"in_reply_to":"AAAATn%2F90tk%3D","updated":"2013-12-05 17:02:48.000000000","message":"Ok, I will change it. Thank you!","commit_id":"93aeb619516b954ea128bb8a438fb4412fbe32f2"},{"author":{"_account_id":9412,"name":"Andres Buraschi","email":"andres.buraschi@intel.com","username":"aburaschi"},"change_message_id":"2906f20e93243362f219a33b20a7ea76e0d615b9","unresolved":false,"context_lines":[{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9znI%3D","line":3675,"updated":"2013-12-05 17:49:32.000000000","message":"Maybe it could be:\n\u0027Trying with %(device_name)s instead.\u0027\nas in the end, the final attached volume could have a different name.\nJust a thought...","commit_id":"3f4a9a6f834d9cc1ae13a0c55f25419481b65c5c"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"f2623c5565718a0eb99a703f32df5e9587a81391","unresolved":false,"context_lines":[{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9zlE%3D","line":3675,"updated":"2013-12-05 17:56:29.000000000","message":"Would be great to indent this line like:\n( \u0027Could not reserve...\u0027\n  \u0027Using device...\u0027)\n\nto match the same style LOG.info is being used on this file.","commit_id":"3f4a9a6f834d9cc1ae13a0c55f25419481b65c5c"},{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"690f25faa6e243d6c1a7acb63382baaf62bdcdf1","unresolved":false,"context_lines":[{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9zcw%3D","line":3675,"in_reply_to":"AAAATn%2F9zlE%3D","updated":"2013-12-05 18:17:43.000000000","message":"I\u0027ll modify it. Thanks!","commit_id":"3f4a9a6f834d9cc1ae13a0c55f25419481b65c5c"},{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"690f25faa6e243d6c1a7acb63382baaf62bdcdf1","unresolved":false,"context_lines":[{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                              \u0027Using %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                            {\u0027device_name\u0027: device_name},"},{"line_number":3677,"context_line":"                            instance\u003dinstance)"},{"line_number":3678,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9zdE%3D","line":3675,"in_reply_to":"AAAATn%2F9znI%3D","updated":"2013-12-05 18:17:43.000000000","message":"Ok, I will change it. Thanks!","commit_id":"3f4a9a6f834d9cc1ae13a0c55f25419481b65c5c"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"585fc2b3160ffa18b505a0570fa4bb14266e95bd","unresolved":false,"context_lines":[{"line_number":3671,"context_line":"                    context, instance, bdms, device)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                           \u0027Trying with %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                         {\u0027device_name\u0027: device_name}, instance\u003dinstance)"},{"line_number":3677,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9PGk%3D","line":3674,"updated":"2013-12-13 17:11:29.000000000","message":"(nit) Put a space after this sentence, since otherwise this message will show up in the log without a space between the period and the next sentence.","commit_id":"04bc6e0834c6567b9ccfc115e2e0ba7b4718b7d2"},{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"79cd8974995931df0610c450c04780fa1d41affe","unresolved":false,"context_lines":[{"line_number":3671,"context_line":"                    context, instance, bdms, device)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name.\u0027"},{"line_number":3675,"context_line":"                           \u0027Trying with %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                         {\u0027device_name\u0027: device_name}, instance\u003dinstance)"},{"line_number":3677,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9O4M%3D","line":3674,"in_reply_to":"AAAATn%2F9PGk%3D","updated":"2013-12-13 18:02:41.000000000","message":"Done","commit_id":"04bc6e0834c6567b9ccfc115e2e0ba7b4718b7d2"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"3a7d19037a388bc61faea7d4976de2f0825fcba5","unresolved":false,"context_lines":[{"line_number":3671,"context_line":"                    context, instance, bdms, device)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name. \u0027"},{"line_number":3675,"context_line":"                           \u0027Trying with %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                         {\u0027device_name\u0027: device_name}, instance\u003dinstance)"},{"line_number":3677,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9AgU%3D","line":3674,"updated":"2013-12-17 19:05:38.000000000","message":"shouldn\u0027t this be a warning?","commit_id":"0df15ceb4f1f840f4c048d88103ad7e4ad7e381a"},{"author":{"_account_id":9449,"name":"Verónica Musso","email":"veronica.a.musso@intel.com","username":"vamusso"},"change_message_id":"09ff25176ab89c63c1b4c73d20ca63b3378ca112","unresolved":false,"context_lines":[{"line_number":3671,"context_line":"                    context, instance, bdms, device)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            if device_name !\u003d device:"},{"line_number":3674,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name. \u0027"},{"line_number":3675,"context_line":"                           \u0027Trying with %(device_name)s instead.\u0027),"},{"line_number":3676,"context_line":"                         {\u0027device_name\u0027: device_name}, instance\u003dinstance)"},{"line_number":3677,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9Acg%3D","line":3674,"in_reply_to":"AAAATn%2F9AgU%3D","updated":"2013-12-17 19:20:45.000000000","message":"According to David Jia comment on previous patch, LOG.info is better than LOG.warning since the difference between device_name and user input device is work as design.","commit_id":"0df15ceb4f1f840f4c048d88103ad7e4ad7e381a"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"7953d2127f2ac3b26e9c812d9dc641615371ee5e","unresolved":false,"context_lines":[{"line_number":3671,"context_line":"                    context, instance, bdms, device)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"            # Adding log info if device name doesn\u0027t match the one proposed"},{"line_number":3674,"context_line":"            # by user due hypervisor settings or naming conventions"},{"line_number":3675,"context_line":"            if device_name !\u003d device:"},{"line_number":3676,"context_line":"                LOG.info(_(\u0027Could not reserve the given device name. \u0027"},{"line_number":3677,"context_line":"                           \u0027Trying with %(device_name)s instead.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2F9AA%3D","line":3674,"updated":"2014-02-08 16:41:24.000000000","message":"^^ Missing a \u0027to\u0027 here in the comment:\n\nby user due to hypervisor settings...","commit_id":"891b1cb34d1efc30ff292cd16fd68c80145e77a3"}]}