)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d5a6a2c6af848e8cca16162e428645b3aacdb82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dirk Mueller \u003cdirk@dmllr.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-05 17:10:49 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct docstring of get_instance_disk_info()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I994f75ef4d0f1540c007ec1d430c6973e9308e35"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F90FQ%3D","line":7,"updated":"2013-12-05 16:39:18.000000000","message":"superfemtonit but fix if you do another patch for any reason, just prefix with \u0027libvirt:\u0027 in the title so there is context.","commit_id":"a5e332d584907e0543d13b52c898061429572059"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96a784e33048cc3c1701213d0c3bb57d0dfc03ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dirk Mueller \u003cdirk@dmllr.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-11 23:36:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct docstring of get_instance_disk_info()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update param list to match reality and fold in pre-existing"},{"line_number":10,"context_line":"NOTEs about the parameters into the doc string."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9V5M%3D","line":7,"updated":"2013-12-12 13:46:20.000000000","message":"nit: should probably have libvirt in the commit title somewhere for context, see bullet 7 here:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"09e0ab5f24a0237fbfe9f2b4703fd4720bd62f72","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dirk Mueller \u003cdirk@dmllr.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-11 23:36:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct docstring of get_instance_disk_info()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update param list to match reality and fold in pre-existing"},{"line_number":10,"context_line":"NOTEs about the parameters into the doc string."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F%2F1uk%3D","line":7,"in_reply_to":"AAAATn%2F9V5M%3D","updated":"2014-01-07 20:56:32.000000000","message":"Done","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"}],"nova/openstack/common/timeutils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7fe2b563f1131c35b326664757f5e6ddb389abc","unresolved":false,"context_lines":[{"line_number":188,"context_line":"def is_soon(dt, window):"},{"line_number":189,"context_line":"    \"\"\"Determines if time is going to happen in the next window seconds."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    :param dt: the time"},{"line_number":192,"context_line":"    :param window: minimum seconds to remain to consider the time not soon"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    :return: True if expiration is within the given duration"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9zMs%3D","line":191,"updated":"2013-12-05 19:19:30.000000000","message":"This has to be changed in oslo-incubator.","commit_id":"5511f36b9cb863963ba215df4fba376d7219029e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b97a737be063008d23c8186751df2a550144e9c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"def is_soon(dt, window):"},{"line_number":189,"context_line":"    \"\"\"Determines if time is going to happen in the next window seconds."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    :param dt: the time"},{"line_number":192,"context_line":"    :param window: minimum seconds to remain to consider the time not soon"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    :return: True if expiration is within the given duration"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9b2A%3D","line":191,"in_reply_to":"AAAATn%2F9cdM%3D","updated":"2013-12-11 14:59:55.000000000","message":"Right, but then you need to sync it over to nova using the oslo update.py script, see:\n\nhttps://wiki.openstack.org/wiki/Oslo#Syncing_Code_from_Incubator\n\nIn other words, I think that should happen separately from this patch.","commit_id":"5511f36b9cb863963ba215df4fba376d7219029e"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"bf6d51f9e39da56ce3e2a97f3d35af16290943da","unresolved":false,"context_lines":[{"line_number":188,"context_line":"def is_soon(dt, window):"},{"line_number":189,"context_line":"    \"\"\"Determines if time is going to happen in the next window seconds."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    :param dt: the time"},{"line_number":192,"context_line":"    :param window: minimum seconds to remain to consider the time not soon"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    :return: True if expiration is within the given duration"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9cdM%3D","line":191,"in_reply_to":"AAAATn%2F9zMs%3D","updated":"2013-12-11 13:31:57.000000000","message":"https://review.openstack.org/61417","commit_id":"5511f36b9cb863963ba215df4fba376d7219029e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d5a6a2c6af848e8cca16162e428645b3aacdb82","unresolved":false,"context_lines":[{"line_number":4443,"context_line":"                               block_device_info\u003dNone):"},{"line_number":4444,"context_line":"        \"\"\"Retrieve information about actual disk sizes of an instance."},{"line_number":4445,"context_line":""},{"line_number":4446,"context_line":"        :params instance:"},{"line_number":4447,"context_line":"            nova.db.sqlalchemy.models.Instance object"},{"line_number":4448,"context_line":"            instance object that is migrated."},{"line_number":4449,"context_line":"        :return:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F90FE%3D","line":4446,"updated":"2013-12-05 16:39:18.000000000","message":"Sorry, what I meant in:\n\nhttps://review.openstack.org/#/c/59771/1/nova/virt/libvirt/driver.py\n\nWas that the parameter name is instance_name which is a string, but the docstring parameter has \u0027instance\u0027 and describes it as an object, which it\u0027s not.","commit_id":"a5e332d584907e0543d13b52c898061429572059"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"904cc6368330af600f055f9307d632e7dc861439","unresolved":false,"context_lines":[{"line_number":4443,"context_line":"                               block_device_info\u003dNone):"},{"line_number":4444,"context_line":"        \"\"\"Retrieve information about actual disk sizes of an instance."},{"line_number":4445,"context_line":""},{"line_number":4446,"context_line":"        :params instance:"},{"line_number":4447,"context_line":"            nova.db.sqlalchemy.models.Instance object"},{"line_number":4448,"context_line":"            instance object that is migrated."},{"line_number":4449,"context_line":"        :return:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9z4Q%3D","line":4446,"in_reply_to":"AAAATn%2F90EY%3D","updated":"2013-12-05 17:07:48.000000000","message":"right, it seems :params is wrong: \nhttp://sphinx-doc.org/domains.html#info-field-lists\n\nI\u0027ll fix it.","commit_id":"a5e332d584907e0543d13b52c898061429572059"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fe9e786cd302434e62e4e2467c21a78fa620620f","unresolved":false,"context_lines":[{"line_number":4443,"context_line":"                               block_device_info\u003dNone):"},{"line_number":4444,"context_line":"        \"\"\"Retrieve information about actual disk sizes of an instance."},{"line_number":4445,"context_line":""},{"line_number":4446,"context_line":"        :params instance:"},{"line_number":4447,"context_line":"            nova.db.sqlalchemy.models.Instance object"},{"line_number":4448,"context_line":"            instance object that is migrated."},{"line_number":4449,"context_line":"        :return:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F90EY%3D","line":4446,"in_reply_to":"AAAATn%2F90FE%3D","updated":"2013-12-05 16:40:35.000000000","message":"Plus it should be :param rather than :params right?  If you\u0027re going to fix this, would you also care to add :param entries for the other parameters, i.e. optional xml domain and optional block_device_info, what they are used for and what happens if they aren\u0027t provided.","commit_id":"a5e332d584907e0543d13b52c898061429572059"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7fe2b563f1131c35b326664757f5e6ddb389abc","unresolved":false,"context_lines":[{"line_number":4451,"context_line":"            instance."},{"line_number":4452,"context_line":"        :param block_device_info:"},{"line_number":4453,"context_line":"            optional passed to block_device_info_get_mapping and"},{"line_number":4454,"context_line":"            sed to filter out devices which are actually volumes."},{"line_number":4455,"context_line":"        :return:"},{"line_number":4456,"context_line":"            json strings with below format::"},{"line_number":4457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9zNY%3D","line":4454,"updated":"2013-12-05 19:19:30.000000000","message":"s/sed/used/?","commit_id":"5511f36b9cb863963ba215df4fba376d7219029e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96a784e33048cc3c1701213d0c3bb57d0dfc03ff","unresolved":false,"context_lines":[{"line_number":4450,"context_line":"        :param instance_name:"},{"line_number":4451,"context_line":"            name of a nova instance as returned by list_instances()"},{"line_number":4452,"context_line":"        :param xml:"},{"line_number":4453,"context_line":"            optional provide XMLDesc of given libvirt instance."},{"line_number":4454,"context_line":"            When it is not passed, libvirt is from the pre-existing"},{"line_number":4455,"context_line":"            instance."},{"line_number":4456,"context_line":"        :param block_device_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9V4c%3D","line":4453,"updated":"2013-12-12 13:46:20.000000000","message":"This reads a bit awkward.  I like rmk\u0027s note on 4462 so let\u0027s try to work that in here.  Maybe something like:\n\n\"Optional domain XML of a given libvirt instance. If not provided, this method attempts to extract it from the pre-existing definition.\"","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"09e0ab5f24a0237fbfe9f2b4703fd4720bd62f72","unresolved":false,"context_lines":[{"line_number":4450,"context_line":"        :param instance_name:"},{"line_number":4451,"context_line":"            name of a nova instance as returned by list_instances()"},{"line_number":4452,"context_line":"        :param xml:"},{"line_number":4453,"context_line":"            optional provide XMLDesc of given libvirt instance."},{"line_number":4454,"context_line":"            When it is not passed, libvirt is from the pre-existing"},{"line_number":4455,"context_line":"            instance."},{"line_number":4456,"context_line":"        :param block_device_info:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F1tI%3D","line":4453,"in_reply_to":"AAAATn%2F9V4c%3D","updated":"2014-01-07 20:56:32.000000000","message":"Agreed, the wording was awkward. How about the new one?","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96a784e33048cc3c1701213d0c3bb57d0dfc03ff","unresolved":false,"context_lines":[{"line_number":4454,"context_line":"            When it is not passed, libvirt is from the pre-existing"},{"line_number":4455,"context_line":"            instance."},{"line_number":4456,"context_line":"        :param block_device_info:"},{"line_number":4457,"context_line":"            optional passed to block_device_info_get_mapping and"},{"line_number":4458,"context_line":"            used to filter out devices which are actually volumes."},{"line_number":4459,"context_line":"        :return:"},{"line_number":4460,"context_line":"            json strings with below format::"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9V3o%3D","line":4457,"updated":"2013-12-12 13:46:20.000000000","message":"I don\u0027t think we need to point out that this is passed to another method, because if that changes in the future, then the docstring is wrong and also has to be fixed, but I doubt someone will catch that regression.  How about we just say this?\n\n\"Optional; used to filter out devices which are actually volumes.\"","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"09e0ab5f24a0237fbfe9f2b4703fd4720bd62f72","unresolved":false,"context_lines":[{"line_number":4454,"context_line":"            When it is not passed, libvirt is from the pre-existing"},{"line_number":4455,"context_line":"            instance."},{"line_number":4456,"context_line":"        :param block_device_info:"},{"line_number":4457,"context_line":"            optional passed to block_device_info_get_mapping and"},{"line_number":4458,"context_line":"            used to filter out devices which are actually volumes."},{"line_number":4459,"context_line":"        :return:"},{"line_number":4460,"context_line":"            json strings with below format::"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F1tM%3D","line":4457,"in_reply_to":"AAAATn%2F9V3o%3D","updated":"2014-01-07 20:56:32.000000000","message":"Done","commit_id":"b7b3590d33a87eb1c19740ac471593b2892e3d27"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9446bac1c4c8d881f414fcf9a3d6b39632b0d37","unresolved":false,"context_lines":[{"line_number":4425,"context_line":"            name of a nova instance as returned by list_instances()"},{"line_number":4426,"context_line":"        :param xml:"},{"line_number":4427,"context_line":"            Optional domain XML of given libvirt instance."},{"line_number":4428,"context_line":"            If omitted, this method attempts to use it from the"},{"line_number":4429,"context_line":"            pre-existing instance."},{"line_number":4430,"context_line":"        :param block_device_info:"},{"line_number":4431,"context_line":"            Optional; Can be used to filter out to filter out"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F1mM%3D","line":4428,"updated":"2014-01-07 21:25:23.000000000","message":"s/use/extract/","commit_id":"bfb2b4d2fcbedccb48fba7740e0eaf71c8b41900"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9446bac1c4c8d881f414fcf9a3d6b39632b0d37","unresolved":false,"context_lines":[{"line_number":4426,"context_line":"        :param xml:"},{"line_number":4427,"context_line":"            Optional domain XML of given libvirt instance."},{"line_number":4428,"context_line":"            If omitted, this method attempts to use it from the"},{"line_number":4429,"context_line":"            pre-existing instance."},{"line_number":4430,"context_line":"        :param block_device_info:"},{"line_number":4431,"context_line":"            Optional; Can be used to filter out to filter out"},{"line_number":4432,"context_line":"            devices which are actually volumes."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F1mA%3D","line":4429,"updated":"2014-01-07 21:25:23.000000000","message":"s/instance/definition/","commit_id":"bfb2b4d2fcbedccb48fba7740e0eaf71c8b41900"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9446bac1c4c8d881f414fcf9a3d6b39632b0d37","unresolved":false,"context_lines":[{"line_number":4428,"context_line":"            If omitted, this method attempts to use it from the"},{"line_number":4429,"context_line":"            pre-existing instance."},{"line_number":4430,"context_line":"        :param block_device_info:"},{"line_number":4431,"context_line":"            Optional; Can be used to filter out to filter out"},{"line_number":4432,"context_line":"            devices which are actually volumes."},{"line_number":4433,"context_line":"        :return:"},{"line_number":4434,"context_line":"            json strings with below format::"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F1l0%3D","line":4431,"updated":"2014-01-07 21:25:23.000000000","message":"/to filter out to filter out/to filter out/","commit_id":"bfb2b4d2fcbedccb48fba7740e0eaf71c8b41900"}]}