)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        compute_node.stats \u003d stats"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        # Update the allocation ratios for the related ComputeNode object"},{"line_number":624,"context_line":"        # but only if the configured values are not the default 0.0; the"},{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b6677d52","line":624,"range":{"start_line":624,"start_character":64,"end_line":624,"end_character":67},"updated":"2018-11-26 21:17:17.000000000","message":"Either remove this or change to None. It\u0027s probably easier to just remove the 0.0 since it already says \"default\".","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        compute_node.stats \u003d stats"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        # Update the allocation ratios for the related ComputeNode object"},{"line_number":624,"context_line":"        # but only if the configured values are not the default 0.0; the"},{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_01d1462e","line":624,"range":{"start_line":624,"start_character":64,"end_line":624,"end_character":67},"in_reply_to":"3f79a3b5_b6677d52","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        # Update the allocation ratios for the related ComputeNode object"},{"line_number":624,"context_line":"        # but only if the configured values are not the default 0.0; the"},{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d6623941","line":626,"range":{"start_line":626,"start_character":59,"end_line":626,"end_character":62},"updated":"2018-11-26 21:17:17.000000000","message":"remove","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        # Update the allocation ratios for the related ComputeNode object"},{"line_number":624,"context_line":"        # but only if the configured values are not the default 0.0; the"},{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a1d3b235","line":626,"range":{"start_line":626,"start_character":59,"end_line":626,"end_character":62},"in_reply_to":"3f79a3b5_d6623941","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"},{"line_number":630,"context_line":"        # the _resource_change method think something changed when really it"},{"line_number":631,"context_line":"        # didn\u0027t."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_766d652e","line":628,"range":{"start_line":628,"start_character":52,"end_line":628,"end_character":59},"updated":"2018-11-26 21:17:17.000000000","message":"same","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        # ComputeNode._from_db_object method takes care of providing default"},{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"},{"line_number":630,"context_line":"        # the _resource_change method think something changed when really it"},{"line_number":631,"context_line":"        # didn\u0027t."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_61e11afd","line":628,"range":{"start_line":628,"start_character":52,"end_line":628,"end_character":59},"in_reply_to":"3f79a3b5_766d652e","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"},{"line_number":630,"context_line":"        # the _resource_change method think something changed when really it"},{"line_number":631,"context_line":"        # didn\u0027t."},{"line_number":632,"context_line":"        # TODO(mriedem): Will this break any scenarios where an operator is"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9668411f","line":629,"range":{"start_line":629,"start_character":46,"end_line":629,"end_character":49},"updated":"2018-11-26 21:17:17.000000000","message":"here also","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        # allocation ratios when the config is left at the 0.0 default, so"},{"line_number":627,"context_line":"        # we\u0027ll really end up with something like a"},{"line_number":628,"context_line":"        # ComputeNode.cpu_allocation_ratio of 16.0, not 0.0. We want to avoid"},{"line_number":629,"context_line":"        # resetting the ComputeNode fields to 0.0 because that will make"},{"line_number":630,"context_line":"        # the _resource_change method think something changed when really it"},{"line_number":631,"context_line":"        # didn\u0027t."},{"line_number":632,"context_line":"        # TODO(mriedem): Will this break any scenarios where an operator is"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_41e2de00","line":629,"range":{"start_line":629,"start_character":46,"end_line":629,"end_character":49},"in_reply_to":"3f79a3b5_9668411f","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        # didn\u0027t."},{"line_number":632,"context_line":"        # TODO(mriedem): Will this break any scenarios where an operator is"},{"line_number":633,"context_line":"        # trying to *reset* the allocation ratios by changing config from"},{"line_number":634,"context_line":"        # non-0.0 back to 0.0? Maybe we should only do this if the fields on"},{"line_number":635,"context_line":"        # the ComputeNode object are not already set. For example, let\u0027s say"},{"line_number":636,"context_line":"        # the cpu_allocation_ratio config was 1.0 and then the operator wants"},{"line_number":637,"context_line":"        # to get back to the default (16.0 via the facade), and to do that they"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1656715e","line":634,"range":{"start_line":634,"start_character":14,"end_line":634,"end_character":17},"updated":"2018-11-26 21:17:17.000000000","message":"s/0.0/None/ here and throughout.","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        # didn\u0027t."},{"line_number":632,"context_line":"        # TODO(mriedem): Will this break any scenarios where an operator is"},{"line_number":633,"context_line":"        # trying to *reset* the allocation ratios by changing config from"},{"line_number":634,"context_line":"        # non-0.0 back to 0.0? Maybe we should only do this if the fields on"},{"line_number":635,"context_line":"        # the ComputeNode object are not already set. For example, let\u0027s say"},{"line_number":636,"context_line":"        # the cpu_allocation_ratio config was 1.0 and then the operator wants"},{"line_number":637,"context_line":"        # to get back to the default (16.0 via the facade), and to do that they"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2195623e","line":634,"range":{"start_line":634,"start_character":14,"end_line":634,"end_character":17},"in_reply_to":"3f79a3b5_1656715e","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"046620d2411f7da264d2b51b6fb8bb30f39b367c","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        for res in (\u0027cpu\u0027, \u0027disk\u0027, \u0027ram\u0027):"},{"line_number":644,"context_line":"            attr \u003d \u0027%s_allocation_ratio\u0027 % res"},{"line_number":645,"context_line":"            conf_alloc_ratio \u003d getattr(self, attr)"},{"line_number":646,"context_line":"            # NOTE(yikun): In Stein version, we change the default value of"},{"line_number":647,"context_line":"            # (cpu|ram|disk)_allocation_ratio from 0.0 to None, but we still"},{"line_number":648,"context_line":"            # should allow 0.0 to keep compatibility, and this 0.0 condition"},{"line_number":649,"context_line":"            # will be removed in the next version (T version)."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b3ec6027","line":646,"range":{"start_line":646,"start_character":36,"end_line":646,"end_character":43},"updated":"2018-11-27 11:53:15.000000000","message":"release seems better.","commit_id":"fffc178cc192daaa26b1f7a21a8992a6d9712720"}],"nova/conf/compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":380,"context_line":"]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":383,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":384,"context_line":"        default\u003dNone,"},{"line_number":385,"context_line":"        min\u003d0.0,"},{"line_number":386,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d61d59bf","line":383,"range":{"start_line":383,"start_character":18,"end_line":383,"end_character":38},"updated":"2018-11-26 21:17:17.000000000","message":"The default value in the docs here:\n\nhttps://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#corefilter\n\nIs wrong today, technically, but I guess maybe it\u0027s just showing that by default it would be 16.0 if left unset. The same is true for the RamFilter and DiskFilter. Anyway, not really something we need to change in this patch.","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"230e79c037e61504ade5fb28ad5c3a016c24330a","unresolved":false,"context_lines":[{"line_number":380,"context_line":"]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":383,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":384,"context_line":"        default\u003dNone,"},{"line_number":385,"context_line":"        min\u003d0.0,"},{"line_number":386,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_6946bc80","line":383,"range":{"start_line":383,"start_character":18,"end_line":383,"end_character":38},"in_reply_to":"3f79a3b5_8173164f","updated":"2018-11-28 17:03:21.000000000","message":"It\u0027s probably not worth it until the initial_*allocation_ratio options show up, because it would be weird to say in the docs that the default is 0.0 but really handled with some internal facade code.","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":380,"context_line":"]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":383,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":384,"context_line":"        default\u003dNone,"},{"line_number":385,"context_line":"        min\u003d0.0,"},{"line_number":386,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8173164f","line":383,"range":{"start_line":383,"start_character":18,"end_line":383,"end_character":38},"in_reply_to":"3f79a3b5_d61d59bf","updated":"2018-11-27 08:04:30.000000000","message":"OK, I will update this doc in follow up.","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":392,"context_line":"out hosts that would have failed the CoreFilter."},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"This configuration specifies ratio for CoreFilter which can be set"},{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_167e7119","line":396,"range":{"start_line":395,"start_character":18,"end_line":396,"end_character":57},"updated":"2018-11-26 21:17:17.000000000","message":"OK so this continues to work in the scheduler because we handle None in the ComputeNode._from_db_object facade:\n\nhttps://github.com/openstack/nova/blob/594c653dc1a312d0364ad24c703e1a9b228133e1/nova/objects/compute_node.py#L195","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_76bc85b5","line":398,"updated":"2018-11-26 21:17:17.000000000","message":"What happens if the value is explicitly set to 0.0 because let\u0027s say someone is running with a sample nova.conf? Right now I don\u0027t think it would make a difference because the ComputeNode._from_db_object facade still handles 0.0:\n\nhttps://github.com/openstack/nova/blob/594c653dc1a312d0364ad24c703e1a9b228133e1/nova/objects/compute_node.py#L191\n\nAnd we\u0027ll ignore that in the ResourceTracker anyway:\n\nhttps://github.com/openstack/nova/blob/594c653dc1a312d0364ad24c703e1a9b228133e1/nova/compute/resource_tracker.py#L646","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a1ddf212","line":398,"in_reply_to":"3f79a3b5_76bc85b5","updated":"2018-11-27 08:04:30.000000000","message":"Yes, for now, we can change it to \"If this option is set to something *other than* ``None`` and ``0.0``\".","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"230e79c037e61504ade5fb28ad5c3a016c24330a","unresolved":false,"context_lines":[{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0955c81e","line":398,"in_reply_to":"3f79a3b5_a1ddf212","updated":"2018-11-28 17:03:21.000000000","message":"You don\u0027t really need to make the update here, since we\u0027ll probably just forget to drop the 0.0 part later...","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"NOTE: As of the 16.0.0 Pike release, this configuration option is ignored"},{"line_number":405,"context_line":"for the ironic.IronicDriver compute driver and is hardcoded to 1.0."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Possible values:"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b6e1bdff","line":405,"range":{"start_line":404,"start_character":0,"end_line":405,"end_character":67},"updated":"2018-11-26 21:17:17.000000000","message":"Might want to rebase on this https://review.openstack.org/#/c/620154/ to avoid conflicts.","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"NOTE: As of the 16.0.0 Pike release, this configuration option is ignored"},{"line_number":405,"context_line":"for the ironic.IronicDriver compute driver and is hardcoded to 1.0."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Possible values:"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e100ca6b","line":405,"range":{"start_line":404,"start_character":0,"end_line":405,"end_character":67},"in_reply_to":"3f79a3b5_b6e1bdff","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"046620d2411f7da264d2b51b6fb8bb30f39b367c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"Possible values:"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d3ff9cae","line":402,"range":{"start_line":398,"start_character":1,"end_line":402,"end_character":59},"updated":"2018-11-27 11:53:15.000000000","message":"As we discussed, could 0.0 be a valid option? like I could set it to 0.0 to indicate that I temporarily mark cpu on this host to None(since num_cpu * 0.0 \u003d 0), and maybe I reset it to 16.0 latter?","commit_id":"fffc178cc192daaa26b1f7a21a8992a6d9712720"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"26dd21dcbf545295b83d0b06b2e50df47aa5226f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"per compute node. For AggregateCoreFilter, it will fall back to this"},{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"Possible values:"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_456423b4","line":402,"range":{"start_line":398,"start_character":1,"end_line":402,"end_character":59},"in_reply_to":"3f79a3b5_d3ff9cae","updated":"2018-11-27 12:31:26.000000000","message":"yes, for now, I think 0.0 is a valid value but we should set it 16.0. and in the future, does 0.0 is a valid value to represent that we disable the inventory of some resource?","commit_id":"fffc178cc192daaa26b1f7a21a8992a6d9712720"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_dad0fef7","line":399,"range":{"start_line":399,"start_character":37,"end_line":399,"end_character":39},"updated":"2018-11-28 03:14:27.000000000","message":"by","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":396,"context_line":"configuration value if no per-aggregate setting is found."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2b1f6671","line":399,"range":{"start_line":399,"start_character":37,"end_line":399,"end_character":39},"in_reply_to":"3f79a3b5_dad0fef7","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":421,"context_line":"per compute node. For AggregateRamFilter, it will fall back to this"},{"line_number":422,"context_line":"configuration value if no per-aggregate setting found."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":425,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":426,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":427,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7af9aa7e","line":424,"updated":"2018-11-28 03:14:27.000000000","message":"or ``0.0``?","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":421,"context_line":"per compute node. For AggregateRamFilter, it will fall back to this"},{"line_number":422,"context_line":"configuration value if no per-aggregate setting found."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":425,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":426,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":427,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ab14d650","line":424,"in_reply_to":"3f79a3b5_7af9aa7e","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"configuration value if no per-aggregate setting found."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":425,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":426,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":427,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":428,"context_line":"want to reset back to the default, explicitly specify 1.5."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9a00466b","line":425,"range":{"start_line":425,"start_character":37,"end_line":425,"end_character":39},"updated":"2018-11-28 03:14:27.000000000","message":"by","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":422,"context_line":"configuration value if no per-aggregate setting found."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":425,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":426,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":427,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":428,"context_line":"want to reset back to the default, explicitly specify 1.5."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ebfdee09","line":425,"range":{"start_line":425,"start_character":37,"end_line":425,"end_character":39},"in_reply_to":"3f79a3b5_9a00466b","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":451,"context_line":"to preserve a percentage of the disk for uses other than"},{"line_number":452,"context_line":"instances."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":455,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":456,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":457,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1af43687","line":454,"updated":"2018-11-28 03:14:27.000000000","message":"or 0.0?","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":451,"context_line":"to preserve a percentage of the disk for uses other than"},{"line_number":452,"context_line":"instances."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":455,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":456,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":457,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0bf94a1b","line":454,"in_reply_to":"3f79a3b5_1af43687","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":452,"context_line":"instances."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":455,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":456,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":457,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":458,"context_line":"want to reset back to the default, explicitly specify 1.0."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ba03c274","line":455,"range":{"start_line":455,"start_character":37,"end_line":455,"end_character":39},"updated":"2018-11-28 03:14:27.000000000","message":"by","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":452,"context_line":"instances."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"NOTE: If this option is set to something *other than* ``None``, the"},{"line_number":455,"context_line":"allocation ratio will be overwritten to the value of this option, otherwise,"},{"line_number":456,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":457,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":458,"context_line":"want to reset back to the default, explicitly specify 1.0."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a6f96b1c","line":455,"range":{"start_line":455,"start_character":37,"end_line":455,"end_character":39},"in_reply_to":"3f79a3b5_ba03c274","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b11acfef90f9a4f4a5589ccbdbb2d15e20c97eb","unresolved":false,"context_lines":[{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten by the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"Possible values:"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ec35fadc","line":402,"range":{"start_line":401,"start_character":72,"end_line":402,"end_character":59},"updated":"2018-11-28 17:12:02.000000000","message":"This is the only point in this help text that mentions the implicit underlying default is 16.0 since you removed this text:\n\n\"\"\"\nThis can be set per-compute, or if set to 0.0, the value\nset on the scheduler node(s) or compute node(s) will be used\nand defaulted to 16.0.\n\"\"\"\n\nSince the ComputeNode._from_db_object facade still exists in this patch, it seems that help text about the implied default should still be in here, at least until the initial_*allocation_ratio change where another option sets the defaults.\n\nThis is kind of the trouble with decoupling the two changes since they are so interdependent.\n\nAlternatively I guess we could just wait to approve the entire series until all of the other patches are approved, which is kind of what I was planning on doing anyway.","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8086b76e7f59f020b3aa1966426a8ff3cba7f970","unresolved":false,"context_lines":[{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten by the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"Possible values:"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5a123166","line":402,"range":{"start_line":401,"start_character":72,"end_line":402,"end_character":59},"in_reply_to":"3f79a3b5_77476a7b","updated":"2018-12-04 15:18:25.000000000","message":"Maybe instead of saying \"If you want to reset back to the initial value\", you could say \"If you want to ALWAYS override the value of the allocation ratio for the compute node, set this option to a non-None, non-0.0 value.\" That seems clear to me...","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ddf345824119bf34cd34dd6d544434b89e111549","unresolved":false,"context_lines":[{"line_number":398,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":399,"context_line":"allocation ratio will be overwritten by the value of this option, otherwise,"},{"line_number":400,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":401,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":402,"context_line":"want to reset back to the default, explicitly specify 16.0."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"Possible values:"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_77476a7b","line":402,"range":{"start_line":401,"start_character":72,"end_line":402,"end_character":59},"in_reply_to":"3f79a3b5_ec35fadc","updated":"2018-11-29 11:23:27.000000000","message":"I also change this text in next patch [1]:\n\n\"\"\"\nIf you want to reset back to the initial value, explicitly specify it to the value of ``initial_allocation_ratio``.\n\"\"\"\n\n[1] https://review.openstack.org/#/c/602804/12/nova/conf/compute.py@432","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b11acfef90f9a4f4a5589ccbdbb2d15e20c97eb","unresolved":false,"context_lines":[{"line_number":424,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":425,"context_line":"allocation ratio will be overwritten by the value of this option, otherwise,"},{"line_number":426,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":427,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":428,"context_line":"want to reset back to the default, explicitly specify 1.5."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Possible values:"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_cc26feb3","line":428,"range":{"start_line":427,"start_character":72,"end_line":428,"end_character":58},"updated":"2018-11-28 17:12:02.000000000","message":"same","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b11acfef90f9a4f4a5589ccbdbb2d15e20c97eb","unresolved":false,"context_lines":[{"line_number":454,"context_line":"NOTE: If this option is set to something *other than* ``None`` or ``0.0``, the"},{"line_number":455,"context_line":"allocation ratio will be overwritten by the value of this option, otherwise,"},{"line_number":456,"context_line":"the allocation ratio will not change. Once set to a non-default value, it is"},{"line_number":457,"context_line":"not possible to \"unset\" the config to get back to the default behavior. If you"},{"line_number":458,"context_line":"want to reset back to the default, explicitly specify 1.0."},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"Possible values:"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_8c4a4657","line":458,"range":{"start_line":457,"start_character":72,"end_line":458,"end_character":58},"updated":"2018-11-28 17:12:02.000000000","message":"same","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"}],"nova/objects/compute_node.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    # ResourceTracker is not updating the value (old node)"},{"line_number":197,"context_line":"                    # or the compute node is updated but the default value has"},{"line_number":198,"context_line":"                    # not been changed"},{"line_number":199,"context_line":"                    value \u003d getattr(CONF, key)"},{"line_number":200,"context_line":"                    if value in (0.0, None) \\"},{"line_number":201,"context_line":"                            and key \u003d\u003d \u0027cpu_allocation_ratio\u0027:"},{"line_number":202,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":203,"context_line":"                        value \u003d 16.0"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d6c6b941","line":200,"range":{"start_line":199,"start_character":20,"end_line":200,"end_character":45},"updated":"2018-11-26 21:17:17.000000000","message":"OK I guess we have to handle 0.0 *or* None here because the nova.conf could have existing 0.0 values hard-coded into it if someone is running with the sample nova.conf values (using defaults). Correct?\n\nShouldn\u0027t we have a unit test for the new condition here?","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    # ResourceTracker is not updating the value (old node)"},{"line_number":197,"context_line":"                    # or the compute node is updated but the default value has"},{"line_number":198,"context_line":"                    # not been changed"},{"line_number":199,"context_line":"                    value \u003d getattr(CONF, key)"},{"line_number":200,"context_line":"                    if value in (0.0, None) \\"},{"line_number":201,"context_line":"                            and key \u003d\u003d \u0027cpu_allocation_ratio\u0027:"},{"line_number":202,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":203,"context_line":"                        value \u003d 16.0"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c4503c0b","line":200,"range":{"start_line":199,"start_character":20,"end_line":200,"end_character":45},"in_reply_to":"3f79a3b5_d6c6b941","updated":"2018-11-27 08:04:30.000000000","message":"Yep, and the new added \"None\" UT is already covered in [1], and we need add a test for old \"0.0\".\n\n[1] https://github.com/openstack/nova/blob/594c653dc1a312d0364ad24c703e1a9b228133e1/nova/tests/unit/objects/test_compute_node.py#L568-L579","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b81872f7112c27c34a97aa1ee508f51b9128e63","unresolved":false,"context_lines":[{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"    def test_copy_resources_update_allocation_zero_ratios(self):"},{"line_number":1567,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1568,"context_line":"        not set if the configured allocation ratio values are default None."},{"line_number":1569,"context_line":"        \"\"\""},{"line_number":1570,"context_line":"        # NOTE(yikun): In Stein version, we change the default value of"},{"line_number":1571,"context_line":"        # (cpu|ram|disk)_allocation_ratio from 0.0 to None, but we still"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_36012d6e","line":1568,"range":{"start_line":1568,"start_character":62,"end_line":1568,"end_character":74},"updated":"2018-11-26 21:17:17.000000000","message":"0.0","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4e6a42fffe908f9d5153c184a80713f861212d76","unresolved":false,"context_lines":[{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"    def test_copy_resources_update_allocation_zero_ratios(self):"},{"line_number":1567,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1568,"context_line":"        not set if the configured allocation ratio values are default None."},{"line_number":1569,"context_line":"        \"\"\""},{"line_number":1570,"context_line":"        # NOTE(yikun): In Stein version, we change the default value of"},{"line_number":1571,"context_line":"        # (cpu|ram|disk)_allocation_ratio from 0.0 to None, but we still"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_41e5fecd","line":1568,"range":{"start_line":1568,"start_character":62,"end_line":1568,"end_character":74},"in_reply_to":"3f79a3b5_36012d6e","updated":"2018-11-27 08:04:30.000000000","message":"Done","commit_id":"38b043544f372eee144a5fd96d5c54883ecf35b5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"    def test_copy_resources_update_allocation_zero_ratios(self):"},{"line_number":1567,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1568,"context_line":"        not set if the configured allocation ratio values are default 0.0."},{"line_number":1569,"context_line":"        \"\"\""},{"line_number":1570,"context_line":"        # NOTE(yikun): In Stein version, we change the default value of"},{"line_number":1571,"context_line":"        # (cpu|ram|disk)_allocation_ratio from 0.0 to None, but we still"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_da3ebe25","line":1568,"range":{"start_line":1568,"start_character":62,"end_line":1568,"end_character":68},"updated":"2018-11-28 03:14:27.000000000","message":"0.0 is not default anymore","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"    def test_copy_resources_update_allocation_zero_ratios(self):"},{"line_number":1567,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1568,"context_line":"        not set if the configured allocation ratio values are default 0.0."},{"line_number":1569,"context_line":"        \"\"\""},{"line_number":1570,"context_line":"        # NOTE(yikun): In Stein version, we change the default value of"},{"line_number":1571,"context_line":"        # (cpu|ram|disk)_allocation_ratio from 0.0 to None, but we still"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e6120356","line":1568,"range":{"start_line":1568,"start_character":62,"end_line":1568,"end_character":68},"in_reply_to":"3f79a3b5_da3ebe25","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"    def test_copy_resources_update_allocation_ratios_from_config(self):"},{"line_number":1590,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1591,"context_line":"        set if the configured allocation ratio values are not None."},{"line_number":1592,"context_line":"        \"\"\""},{"line_number":1593,"context_line":"        # Set explicit ratio config values to 1.0 (the default is None)."},{"line_number":1594,"context_line":"        for res in (\u0027cpu\u0027, \u0027disk\u0027, \u0027ram\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_fa393a3c","line":1591,"range":{"start_line":1591,"start_character":62,"end_line":1591,"end_character":66},"updated":"2018-11-28 03:14:27.000000000","message":"None or 0.0?","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"    def test_copy_resources_update_allocation_ratios_from_config(self):"},{"line_number":1590,"context_line":"        \"\"\"Tests that a ComputeNode object\u0027s allocation ratio fields are"},{"line_number":1591,"context_line":"        set if the configured allocation ratio values are not None."},{"line_number":1592,"context_line":"        \"\"\""},{"line_number":1593,"context_line":"        # Set explicit ratio config values to 1.0 (the default is None)."},{"line_number":1594,"context_line":"        for res in (\u0027cpu\u0027, \u0027disk\u0027, \u0027ram\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_463177ed","line":1591,"range":{"start_line":1591,"start_character":62,"end_line":1591,"end_character":66},"in_reply_to":"3f79a3b5_fa393a3c","updated":"2018-11-28 08:39:30.000000000","message":"are not default","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"}],"nova/tests/unit/objects/test_compute_node.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    def test_compat_allocation_ratios_default_values(self):"},{"line_number":569,"context_line":"        # the CONF.x_allocation_ratio is None by default"},{"line_number":570,"context_line":"        compute_dict \u003d fake_compute_node.copy()"},{"line_number":571,"context_line":"        # new computes provide allocation ratios defaulted to 0.0"},{"line_number":572,"context_line":"        compute_dict[\u0027cpu_allocation_ratio\u0027] \u003d 0.0"},{"line_number":573,"context_line":"        compute_dict[\u0027ram_allocation_ratio\u0027] \u003d 0.0"},{"line_number":574,"context_line":"        compute_dict[\u0027disk_allocation_ratio\u0027] \u003d 0.0"},{"line_number":575,"context_line":"        cls \u003d objects.ComputeNode"},{"line_number":576,"context_line":"        compute \u003d cls._from_db_object(self.context, cls(), compute_dict)"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_3a1d72be","line":574,"range":{"start_line":571,"start_character":8,"end_line":574,"end_character":51},"updated":"2018-11-28 03:14:27.000000000","message":"should this be updated?","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    def test_compat_allocation_ratios_default_values(self):"},{"line_number":569,"context_line":"        # the CONF.x_allocation_ratio is None by default"},{"line_number":570,"context_line":"        compute_dict \u003d fake_compute_node.copy()"},{"line_number":571,"context_line":"        # new computes provide allocation ratios defaulted to 0.0"},{"line_number":572,"context_line":"        compute_dict[\u0027cpu_allocation_ratio\u0027] \u003d 0.0"},{"line_number":573,"context_line":"        compute_dict[\u0027ram_allocation_ratio\u0027] \u003d 0.0"},{"line_number":574,"context_line":"        compute_dict[\u0027disk_allocation_ratio\u0027] \u003d 0.0"},{"line_number":575,"context_line":"        cls \u003d objects.ComputeNode"},{"line_number":576,"context_line":"        compute \u003d cls._from_db_object(self.context, cls(), compute_dict)"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a6cc0bbe","line":574,"range":{"start_line":571,"start_character":8,"end_line":574,"end_character":51},"in_reply_to":"3f79a3b5_3a1d72be","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"55cfef18d67f74cb972915994580ff1530d7c8d0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        self.assertEqual(1.5, compute.ram_allocation_ratio)"},{"line_number":580,"context_line":"        self.assertEqual(1.0, compute.disk_allocation_ratio)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test_compat_allocation_ratios_zero_values(self):"},{"line_number":583,"context_line":"        self.flags(cpu_allocation_ratio\u003d0.0, ram_allocation_ratio\u003d0.0,"},{"line_number":584,"context_line":"                   disk_allocation_ratio\u003d0.0)"},{"line_number":585,"context_line":"        compute_dict \u003d fake_compute_node.copy()"},{"line_number":586,"context_line":"        # the computes provide allocation ratios defaulted to None"},{"line_number":587,"context_line":"        compute_dict[\u0027cpu_allocation_ratio\u0027] \u003d None"},{"line_number":588,"context_line":"        compute_dict[\u0027ram_allocation_ratio\u0027] \u003d None"},{"line_number":589,"context_line":"        compute_dict[\u0027disk_allocation_ratio\u0027] \u003d None"},{"line_number":590,"context_line":"        cls \u003d objects.ComputeNode"},{"line_number":591,"context_line":"        compute \u003d cls._from_db_object(self.context, cls(), compute_dict)"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5a794ef7","line":589,"range":{"start_line":582,"start_character":3,"end_line":589,"end_character":52},"updated":"2018-11-28 03:14:27.000000000","message":"this one and the above one seems miss-placed.","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ec5eeb82de05dcb8104ec5d362f992e0042fceba","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        self.assertEqual(1.5, compute.ram_allocation_ratio)"},{"line_number":580,"context_line":"        self.assertEqual(1.0, compute.disk_allocation_ratio)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test_compat_allocation_ratios_zero_values(self):"},{"line_number":583,"context_line":"        self.flags(cpu_allocation_ratio\u003d0.0, ram_allocation_ratio\u003d0.0,"},{"line_number":584,"context_line":"                   disk_allocation_ratio\u003d0.0)"},{"line_number":585,"context_line":"        compute_dict \u003d fake_compute_node.copy()"},{"line_number":586,"context_line":"        # the computes provide allocation ratios defaulted to None"},{"line_number":587,"context_line":"        compute_dict[\u0027cpu_allocation_ratio\u0027] \u003d None"},{"line_number":588,"context_line":"        compute_dict[\u0027ram_allocation_ratio\u0027] \u003d None"},{"line_number":589,"context_line":"        compute_dict[\u0027disk_allocation_ratio\u0027] \u003d None"},{"line_number":590,"context_line":"        cls \u003d objects.ComputeNode"},{"line_number":591,"context_line":"        compute \u003d cls._from_db_object(self.context, cls(), compute_dict)"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_46d2d760","line":589,"range":{"start_line":582,"start_character":3,"end_line":589,"end_character":52},"in_reply_to":"3f79a3b5_5a794ef7","updated":"2018-11-28 08:39:30.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"}],"releasenotes/notes/add_initial_allocation_ratio-2d2666d62426a4bf.yaml":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3948da6f849040e11070c472ceb70e27751e102e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value for the \"initial_cpu_allocation_ratio\","},{"line_number":5,"context_line":"    \"initial_ram_allocation_ratio\" and \"initial_disk_allocation_ratio\""},{"line_number":6,"context_line":"    configurations have been changed to ``None``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ba9e6265","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":49},"updated":"2018-11-28 02:51:58.000000000","message":"this seems wrong, you are changing the default value for cpu_allocation_ratio, also the file name is wrong","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"dfb8865dfbdc325608984120cb02cd7d128452e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value for the \"initial_cpu_allocation_ratio\","},{"line_number":5,"context_line":"    \"initial_ram_allocation_ratio\" and \"initial_disk_allocation_ratio\""},{"line_number":6,"context_line":"    configurations have been changed to ``None``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_a6840b0f","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":49},"in_reply_to":"3f79a3b5_ba9e6265","updated":"2018-11-28 08:39:51.000000000","message":"Done","commit_id":"e65783f75578c4a64860cab7bdedee5bf6bc8bda"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b11acfef90f9a4f4a5589ccbdbb2d15e20c97eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value for the \"cpu_allocation_ratio\", \"ram_allocation_ratio\""},{"line_number":5,"context_line":"    and \"disk_allocation_ratio\" configurations have been changed to ``None``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_0c5f1610","line":4,"updated":"2018-11-28 17:12:02.000000000","message":"I wasn\u0027t sure that we really needed a release note for this, but I guess since the next change in the series just amends it (which is what I would have done), it\u0027s probably OK.\n\nhttps://review.openstack.org/#/c/602804/12/releasenotes/notes/add_initial_allocation_ratio-2d2666d62426a4bf.yaml","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ddf345824119bf34cd34dd6d544434b89e111549","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value for the \"cpu_allocation_ratio\", \"ram_allocation_ratio\""},{"line_number":5,"context_line":"    and \"disk_allocation_ratio\" configurations have been changed to ``None``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_974fa68c","line":4,"in_reply_to":"3f79a3b5_0c5f1610","updated":"2018-11-29 11:23:27.000000000","message":"yep","commit_id":"212eff600ab6f016ed696a8d4bd884d572db8990"}]}