)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aea1dc3810cc3df8dcde352d4fc636c201b20e4d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch does not changes the default value of"},{"line_number":13,"context_line":"[notifications]/notification_format config option to ``versioned`` yet"},{"line_number":14,"context_line":"as there are many projects still depending on the legacy interface."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I72faa356afffb7a079a9ce86fed1b463773a0507"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_5e58c556","line":15,"updated":"2018-12-05 14:30:48.000000000","message":"Given bug 1805659 I wonder if it would be premature to deprecate unversioned notifications, especially if we are considering making them the default rather than \u0027both\u0027 as it is today. But then I\u0027m not sure what the deprecation criteria would be - getting other projects moved off unversioned notifications?","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-01 19:22:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the default of notification_format to legacy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default config `both` means that both the legacy and the versioned"},{"line_number":10,"context_line":"notifications are emitted. This was selected as default in the past when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_4ed9cef0","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":51},"updated":"2019-05-01 17:50:54.000000000","message":"\u0027unversioned\u0027 might make it easier for someone grepping history for this change.","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-01 19:22:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the default of notification_format to legacy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default config `both` means that both the legacy and the versioned"},{"line_number":10,"context_line":"notifications are emitted. This was selected as default in the past when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_75025d71","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":51},"in_reply_to":"ffb9cba7_4ed9cef0","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"interface reaches feature parity but as major consumers are not ready"},{"line_number":23,"context_line":"to switch we cannot do that."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"So the only option left is to set the default to `legacy`."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1805659"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_eefa0241","line":25,"range":{"start_line":25,"start_character":49,"end_line":25,"end_character":57},"updated":"2019-05-01 17:50:54.000000000","message":"`unversioned`","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":22,"context_line":"interface reaches feature parity but as major consumers are not ready"},{"line_number":23,"context_line":"to switch we cannot do that."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"So the only option left is to set the default to `legacy`."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1805659"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_15fbe178","line":25,"range":{"start_line":25,"start_character":49,"end_line":25,"end_character":57},"in_reply_to":"ffb9cba7_eefa0241","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"586146090622b69c6db4625b86644274a3df9845","unresolved":false,"context_lines":[{"line_number":15,"context_line":"notifications do not have the resources to switch to the new interface."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In the other hand having `both` as a default in an environtment where"},{"line_number":18,"context_line":"only the legacy notifications are consumed causes performance issues in"},{"line_number":19,"context_line":"the message bus hence the bug #1805659."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The original plan was that we set the default to `versioned` when the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dfbec78f_88e3bd33","line":18,"range":{"start_line":18,"start_character":50,"end_line":18,"end_character":68},"updated":"2019-05-06 21:29:44.000000000","message":"Do we have actual performance metrics relate to this issue?\nHow much we can improve the performance with this patch?\nThe bug report didn\u0027t mention that.","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"}],"doc/source/reference/notifications.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"98f90b5d27576809f1a626e00ab4c4bc6bc05e3a","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"There is a Nova configuration parameter"},{"line_number":115,"context_line":":oslo.config:option:`notifications.notification_format`"},{"line_number":116,"context_line":"that can be used to specify which notifications are emitted by Nova. The"},{"line_number":117,"context_line":"possible values are ``unversioned``, ``versioned``, ``both`` and the default"},{"line_number":118,"context_line":"value is ``both``."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9fb8cfa7_755f3872","side":"PARENT","line":116,"updated":"2019-06-05 10:45:47.000000000","message":"oops, good spot.","commit_id":"1f74441680b4376cd401ecc0b0449b464cf7a5fb"}],"nova/conf/notifications.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6b843611ab1d786a2a912b5703f212ae3eb1c1e2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Specifies which notification format shall be used by nova."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The default value is fine for most deployments and rarely needs to be changed."},{"line_number":69,"context_line":"This value can be set to \u0027versioned\u0027 once the infrastructure moves closer to"},{"line_number":70,"context_line":"consuming the newer format of notifications. After this occurs, this option"},{"line_number":71,"context_line":"will be removed."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Note that notifications can be completely disabled by setting ``driver\u003dnoop``"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_261342ba","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":44},"updated":"2018-10-02 14:18:02.000000000","message":"This sentence needs to be changed.","commit_id":"431275d82cae4af3f2b13f04ad9af29cf3844a06"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"30f617936bdffcd1dbee9dbe5e59e32f6ae33af3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        help\u003d\"\"\""},{"line_number":70,"context_line":"Specifies which notification format shall be used by nova."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The default value is fine for most deployments and rarely needs to be changed."},{"line_number":73,"context_line":"This value can be set to \u0027versioned\u0027 if the notification consumers are ready"},{"line_number":74,"context_line":"to consume the new versioned notifications."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a3402160","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":78},"updated":"2018-12-03 15:11:21.000000000","message":"Except that we\u0027re deprecating the unversioned notifications. So I think this sentence should encourage deployers to set the value to \u0027versioned\u0027.","commit_id":"1c46e3375126079047315a648d046ff15ac4f7c4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d9765fc40c7dd8a335717a6483bfccfd2058141","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        help\u003d\"\"\""},{"line_number":70,"context_line":"Specifies which notification format shall be used by nova."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The default value is fine for most deployments and rarely needs to be changed."},{"line_number":73,"context_line":"This value can be set to \u0027versioned\u0027 if the notification consumers are ready"},{"line_number":74,"context_line":"to consume the new versioned notifications."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a63b4f98","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":78},"in_reply_to":"3f79a3b5_a3402160","updated":"2018-12-03 15:21:27.000000000","message":"I removed this sentence.","commit_id":"1c46e3375126079047315a648d046ff15ac4f7c4"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ea83303822307e91f314501e32ec74130a57e63b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"in the ``[oslo_messaging_notifications]`` group."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Note that the unversioned notifications are deprecated. The deprecated"},{"line_number":79,"context_line":"notifications will not be removed but will not be supported either."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"The list of versioned notifications is visible in"},{"line_number":82,"context_line":"https://docs.openstack.org/nova/latest/reference/notifications.html"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_59aa1f1b","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":33},"updated":"2018-12-05 15:11:28.000000000","message":"If you respin, you might want to clarify that they will continue to be emitted with \u0027both\u0027 and \u0027unversioned\u0027 settings. It\u0027s not clear what \"will not be removed\" means.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"dcf410cd3dce669293397655ed5d767a5483bd7d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"in the ``[oslo_messaging_notifications]`` group."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Note that the unversioned notifications are deprecated. The deprecated"},{"line_number":79,"context_line":"notifications will not be removed but will not be supported either."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"The list of versioned notifications is visible in"},{"line_number":82,"context_line":"https://docs.openstack.org/nova/latest/reference/notifications.html"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1c948b97","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":33},"in_reply_to":"3f79a3b5_41d8e57b","updated":"2018-12-05 22:57:50.000000000","message":"Because every consumer of notifications uses the unversioned ones. The improvement to a versioned notification design doesn\u0027t seem to have come from demand from those users.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"27857b36c16bf3428434f994632e542227ec7b68","unresolved":false,"context_lines":[{"line_number":76,"context_line":"in the ``[oslo_messaging_notifications]`` group."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Note that the unversioned notifications are deprecated. The deprecated"},{"line_number":79,"context_line":"notifications will not be removed but will not be supported either."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"The list of versioned notifications is visible in"},{"line_number":82,"context_line":"https://docs.openstack.org/nova/latest/reference/notifications.html"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_41d8e57b","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":33},"in_reply_to":"3f79a3b5_59aa1f1b","updated":"2018-12-05 16:26:11.000000000","message":"If they\u0027re actually deprecated, why are we still emitting them. Surely we should switch the default from \u0027both\u0027 to \u0027versioned\u0027? That would warrant an \u0027upgrade\u0027 release note, of course.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027legacy\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_ae964aef","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":23},"updated":"2019-05-01 17:50:54.000000000","message":"unversioned","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027legacy\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_d5c22934","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":23},"in_reply_to":"ffb9cba7_ae964aef","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Specifies which notification format shall be emitted by nova."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The versioned notification interface are in feature parity with the legacy"},{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_ce9b7e15","line":73,"range":{"start_line":73,"start_character":38,"end_line":73,"end_character":41},"updated":"2019-05-01 17:50:54.000000000","message":"is","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Specifies which notification format shall be emitted by nova."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The versioned notification interface are in feature parity with the legacy"},{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_f5bf2da7","line":73,"range":{"start_line":73,"start_character":38,"end_line":73,"end_character":41},"in_reply_to":"ffb9cba7_ce9b7e15","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The versioned notification interface are in feature parity with the legacy"},{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_6e9cd20d","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":5},"updated":"2019-05-01 17:50:54.000000000","message":"should","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The versioned notification interface are in feature parity with the legacy"},{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_95def10e","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":5},"in_reply_to":"ffb9cba7_6e9cd20d","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note that notifications can be completely disabled by setting ``driver\u003dnoop``"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_4e878eb6","line":76,"updated":"2019-05-01 17:50:54.000000000","message":"However, t","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":73,"context_line":"interface and the versioned interface are actively developed so new consumers"},{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note that notifications can be completely disabled by setting ``driver\u003dnoop``"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_b5e3f5d8","line":76,"in_reply_to":"ffb9cba7_4e878eb6","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3fb6528232faefcabec676d2ca8a76eac4f8b88c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note that notifications can be completely disabled by setting ``driver\u003dnoop``"},{"line_number":80,"context_line":"in the ``[oslo_messaging_notifications]`` group."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_0e8d16d2","line":77,"range":{"start_line":77,"start_character":17,"end_line":77,"end_character":40},"updated":"2019-05-01 17:50:54.000000000","message":"remains the default","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1b83fe041f2cc099bc402680694b4c9f20778492","unresolved":false,"context_lines":[{"line_number":74,"context_line":"shall used the versioned interface."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The legacy interface is heavily used by ceilometer and other mature OpenStack"},{"line_number":77,"context_line":"components so it is also kept available."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note that notifications can be completely disabled by setting ``driver\u003dnoop``"},{"line_number":80,"context_line":"in the ``[oslo_messaging_notifications]`` group."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_75e9fdb4","line":77,"range":{"start_line":77,"start_character":17,"end_line":77,"end_character":40},"in_reply_to":"ffb9cba7_0e8d16d2","updated":"2019-05-01 23:30:48.000000000","message":"Done","commit_id":"f0ff9550d048a42f27e7e3eeff22cc82c56d97fb"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"3d4f63e15e82202351fb38d3418e7b4d191b54ac","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_71d53ab9","side":"PARENT","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":21},"updated":"2019-05-03 20:38:46.000000000","message":"IMHO, we should just have this as the default and keep the bug open, at least someone might come by and invest in changing ceilometer. Changing this to unversioned as default in nova is just going to make it less motivating to move forward to versioned. But this could be just me feeling this way.\n\nAs for the bug, the operators can change this to unversioned if they are suffering which is the suggested workaround.","commit_id":"1f74441680b4376cd401ecc0b0449b464cf7a5fb"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"eae068332a78abfb521fb1ae8fbcd394964aad65","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_823ba736","side":"PARENT","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":21},"in_reply_to":"dfbec78f_03f34fa0","updated":"2019-05-06 08:41:35.000000000","message":"@gibi: okay :) I guess its ultimately your call.","commit_id":"1f74441680b4376cd401ecc0b0449b464cf7a5fb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3512d9c9c40d0d933b77936b09a95c1b0b5e0f71","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_d12d06a9","side":"PARENT","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":21},"in_reply_to":"dfbec78f_71d53ab9","updated":"2019-05-03 20:47:25.000000000","message":"I agree with this. Why is it a problem for deployments to change their conf to fix the bug? How does it help to change the default for a release they\u0027re not using? Were we planning to backport this?","commit_id":"1f74441680b4376cd401ecc0b0449b464cf7a5fb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"026d8c14b574e2e5c372506d758a6cbf2f7948cd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027both\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_03f34fa0","side":"PARENT","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":21},"in_reply_to":"dfbec78f_d12d06a9","updated":"2019-05-03 22:54:30.000000000","message":"If most of our deployers need to change the default value of this config then it means this config does not have a meaningful default value. This motivates me to change the default value to something that is good for most of the deployers.","commit_id":"1f74441680b4376cd401ecc0b0449b464cf7a5fb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7186fbb94c3e5cac23cc16342913af7df030c2b0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027unversioned\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_ccc244ea","line":60,"updated":"2019-06-03 20:03:49.000000000","message":"The docs hard-code the default value:\n\nhttps://docs.openstack.org/nova/latest/reference/notifications.html#versioned-notifications\n\n\"There is a Nova configuration parameter notifications.notification_format that can be used to specify which notifications are emitted by Nova. The possible values are unversioned, versioned, both and the default value is both.\"\n\nSo that would also need to be updated. I\u0027d just remove that last sentence since the docs link to the config option help which defines the default and the choices.","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0fddad1a9e27392712574bdb5962917caf53ed20","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":58,"context_line":"    cfg.StrOpt("},{"line_number":59,"context_line":"        \u0027notification_format\u0027,"},{"line_number":60,"context_line":"        default\u003d\u0027unversioned\u0027,"},{"line_number":61,"context_line":"        choices\u003d["},{"line_number":62,"context_line":"            (\u0027both\u0027, \u0027Both the legacy unversioned and the new versioned \u0027"},{"line_number":63,"context_line":"             \u0027notifications are emitted\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_0cf372a0","line":60,"in_reply_to":"9fb8cfa7_ccc244ea","updated":"2019-06-04 08:42:35.000000000","message":"Done","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"}],"releasenotes/notes/deprecate-unversioned-notifications-4f4ae7e6d2f1bc57.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6b843611ab1d786a2a912b5703f212ae3eb1c1e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value [notifications]/notification_format has been changed from"},{"line_number":5,"context_line":"    ``both`` to ``versioned`` as part of the deprecation of the unversioned"},{"line_number":6,"context_line":"    notfication interface of nova."},{"line_number":7,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_e608ea80","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":21},"updated":"2018-10-02 14:18:02.000000000","message":"value of","commit_id":"431275d82cae4af3f2b13f04ad9af29cf3844a06"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"ea83303822307e91f314501e32ec74130a57e63b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The unversioned legacy notification of nova is deprecated and replaced with"},{"line_number":5,"context_line":"    the versioned notification interface. The deprecated interface will not be"},{"line_number":6,"context_line":"    removed but will not be supported either."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_197587ca","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"updated":"2018-12-05 15:11:28.000000000","message":"Same comment here.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"27857b36c16bf3428434f994632e542227ec7b68","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The unversioned legacy notification of nova is deprecated and replaced with"},{"line_number":5,"context_line":"    the versioned notification interface. The deprecated interface will not be"},{"line_number":6,"context_line":"    removed but will not be supported either."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_e1e1f132","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"in_reply_to":"3f79a3b5_197587ca","updated":"2018-12-05 16:26:11.000000000","message":"Yup, time for some linguistic jujutsu. How about:\n\n  The deprecated interface will be removed in a future release.\n\nIt\u0027s not going to keep working forever, so we\u0027re saying we will remove it without committing to when exactly we do that.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c58bc2e737a605d532fa4682541826d610e071f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The unversioned legacy notification of nova is deprecated and replaced with"},{"line_number":5,"context_line":"    the versioned notification interface. The deprecated interface will not be"},{"line_number":6,"context_line":"    removed but will not be supported either."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_fc68a4b9","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"in_reply_to":"3f79a3b5_e1e1f132","updated":"2019-01-18 15:08:35.000000000","message":"When did we say we were going to ever remove the unversioned notifications (ever)? I thought the conclusion made at the Stein PTG was that we can\u0027t remove them while projects are using them, and at least for now, most projects are still using them, and I would say ceilometer is the biggest one. If we got to the point that the majority of openstack projects we know are consuming nova\u0027s notifications are using the versioned ones, then we could revisit, but I don\u0027t see that happening for a long time unless nova developers do the work in those projects to convert to versioned support.","commit_id":"f0c7fc31c498319dfd821f69d32e0d52f0c51a05"}],"releasenotes/notes/unversioned-as-default-notification_format-f149db44b319aa07.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5d03d9da3e755f24f2e98f75ae30cfc4ba10e1bc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    option`_."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _`bug 1805659`: https://bugs.launchpad.net/nova/+bug/1805659"},{"line_number":10,"context_line":"    .. _`documentation of the config option`: https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfbec78f_503c7dbe","line":10,"updated":"2019-05-07 21:00:05.000000000","message":"I\u0027m wondering if this release note could benefit from a bit more info like, \"if you are using versioned notifications, you will need to adjust your config to ``versioned``\". Maybe that\u0027s too obvious, but I\u0027m thinking about the person who mentioned they use versioned notifications during the Q\u0026A at gibi\u0027s notifications presentation at the summit. I wonder if this existing sentence makes it clear that action is needed for anyone consuming versioned notifications today with the default setting.","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0fddad1a9e27392712574bdb5962917caf53ed20","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    option`_."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _`bug 1805659`: https://bugs.launchpad.net/nova/+bug/1805659"},{"line_number":10,"context_line":"    .. _`documentation of the config option`: https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_6ccd4e5c","line":10,"in_reply_to":"9fb8cfa7_2d7a0724","updated":"2019-06-04 08:42:35.000000000","message":"Done","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"559f1fd3f3603b8aa115458a50e4185f84d73d3d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    option`_."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _`bug 1805659`: https://bugs.launchpad.net/nova/+bug/1805659"},{"line_number":10,"context_line":"    .. _`documentation of the config option`: https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_22451fb4","line":10,"in_reply_to":"9fb8cfa7_6ccd4e5c","updated":"2019-06-04 09:58:00.000000000","message":"nit, could have been one sentence earlier, but this is fine.","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"aadff0d907ed4ea6da83eca4be3963cc0c0d2dac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    option`_."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _`bug 1805659`: https://bugs.launchpad.net/nova/+bug/1805659"},{"line_number":10,"context_line":"    .. _`documentation of the config option`: https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_2d7a0724","line":10,"in_reply_to":"dfbec78f_503c7dbe","updated":"2019-06-03 11:25:23.000000000","message":"Yeah... a follow up to fix this would be great.","commit_id":"7917d4f4b3dbfae9f49c9f97a7f65896830b1a50"}]}