)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5ac7f385f422569910ec0cbf340685cc99dfcfee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Garbutt \u003cjohn@johngarbutt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-17 12:05:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate ComputeCapabilitiesFilter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Help accelerate the transition from capabilities to traits by"},{"line_number":10,"context_line":"deprecating the ComputeCapabilitiesFilter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8f92549e","line":7,"updated":"2018-09-20 14:12:18.000000000","message":"It\u0027s also in the default enabled_filters list - would you remove it from that default list now too? Or when it\u0027s removed? If it\u0027s deprecated, we probably shouldn\u0027t enable it by default for new deployments otherwise they are going to get warnings on a fresh install.","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6c9fd5cbd8606824e2191878d2c86b8865224e82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Garbutt \u003cjohn@johngarbutt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-17 12:05:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate ComputeCapabilitiesFilter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Help accelerate the transition from capabilities to traits by"},{"line_number":10,"context_line":"deprecating the ComputeCapabilitiesFilter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_69cc6334","line":7,"in_reply_to":"3f79a3b5_8f92549e","updated":"2018-09-24 09:25:56.000000000","message":"Didn\u0027t spot that, agreed with you.","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"}],"doc/source/user/filter-scheduler.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5ac7f385f422569910ec0cbf340685cc99dfcfee","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  hosts matching the availability zone specified in the instance properties."},{"line_number":37,"context_line":"  Use a comma to specify multiple zones. The filter will then ensure it matches"},{"line_number":38,"context_line":"  any zone specified."},{"line_number":39,"context_line":"* |ComputeCapabilitiesFilter| DEPRECATED; - checks that the capabilities"},{"line_number":40,"context_line":"  provided by the host compute service satisfy any extra specifications"},{"line_number":41,"context_line":"  associated with the instance type. It passes hosts that can create the"},{"line_number":42,"context_line":"  specified instance type."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ef83c854","line":39,"updated":"2018-09-20 14:12:18.000000000","message":"You should have a deprecation notice on these docs as well:\n\nhttps://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#computecapabilitiesfilter","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6c9fd5cbd8606824e2191878d2c86b8865224e82","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  hosts matching the availability zone specified in the instance properties."},{"line_number":37,"context_line":"  Use a comma to specify multiple zones. The filter will then ensure it matches"},{"line_number":38,"context_line":"  any zone specified."},{"line_number":39,"context_line":"* |ComputeCapabilitiesFilter| DEPRECATED; - checks that the capabilities"},{"line_number":40,"context_line":"  provided by the host compute service satisfy any extra specifications"},{"line_number":41,"context_line":"  associated with the instance type. It passes hosts that can create the"},{"line_number":42,"context_line":"  specified instance type."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_89d1bfcf","line":39,"in_reply_to":"3f79a3b5_ef83c854","updated":"2018-09-24 09:25:56.000000000","message":"oops, yes.","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"}],"nova/scheduler/filters/compute_capabilities_filter.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5ac7f385f422569910ec0cbf340685cc99dfcfee","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                if not has_attr:"},{"line_number":97,"context_line":"                    continue"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                if scope[0] !\u003d \"capabilities\":"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":"                else:"},{"line_number":102,"context_line":"                    del scope[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0f63a4b2","line":99,"updated":"2018-09-20 14:12:18.000000000","message":"I\u0027m pretty unfamiliar with this, but it\u0027s obvious that operators can/would configure their flavors to work with this filter, right? Based on that, should we write a pre-upgrade check that scans the flavors in the system and if they are configured for capabilities scope to work with this filter, we need to dump a warning saying the filter itself is deprecated and those flavor-defined capabilities will no longer work and should be transitioned to using required traits?","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6c9fd5cbd8606824e2191878d2c86b8865224e82","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                if not has_attr:"},{"line_number":97,"context_line":"                    continue"},{"line_number":98,"context_line":"            else:"},{"line_number":99,"context_line":"                if scope[0] !\u003d \"capabilities\":"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":"                else:"},{"line_number":102,"context_line":"                    del scope[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_09ddafdc","line":99,"in_reply_to":"3f79a3b5_0f63a4b2","updated":"2018-09-24 09:25:56.000000000","message":"Had not thought of doing a status check, but you are right, that is a great idea.","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"}],"releasenotes/notes/deprecate-compute-capabilities-ff6e10c07e7fee92.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5ac7f385f422569910ec0cbf340685cc99dfcfee","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    better integrates with Placement."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The ``ComputeCapabilitiesFilter`` is now deprecated. Those making use"},{"line_number":10,"context_line":"    of this filter should move to using Traits, such that placement will be"},{"line_number":11,"context_line":"    able to perform any filtering previously done using capabilities. Note"},{"line_number":12,"context_line":"    traits are only binary tags."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_4f88bc69","line":9,"updated":"2018-09-20 14:12:18.000000000","message":"You should link to whatever ironic flavor/scheduling docs are available for integrating with traits and all that. I know something exists.","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6c9fd5cbd8606824e2191878d2c86b8865224e82","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    better integrates with Placement."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The ``ComputeCapabilitiesFilter`` is now deprecated. Those making use"},{"line_number":10,"context_line":"    of this filter should move to using Traits, such that placement will be"},{"line_number":11,"context_line":"    able to perform any filtering previously done using capabilities. Note"},{"line_number":12,"context_line":"    traits are only binary tags."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_49fc073f","line":9,"in_reply_to":"3f79a3b5_4f88bc69","updated":"2018-09-24 09:25:56.000000000","message":"Ah, good call.\n\nhttps://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html#scheduling-based-on-traits","commit_id":"53b49b64c05ba7f38d5e5112e7f0c224a6f21b9c"}]}