)]}'
{"nova/tests/objects/test_objects.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ee551c2c12cfb60c601c4e95cf9381d338b5e2f0","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                     \u0027nova_object.version\u0027: \u00271.2\u0027,"},{"line_number":417,"context_line":"                     \u0027nova_object.data\u0027: {\u0027foo\u0027: 1}}"},{"line_number":418,"context_line":"        obj \u003d MyObj.obj_from_primitive(primitive)"},{"line_number":419,"context_line":"        self.assertEqual(obj.foo, 1)"},{"line_number":420,"context_line":"        self.assertEqual(\u00271.2\u0027, obj.VERSION)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def test_hydration_bad_ns(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9kyI%3D","line":419,"updated":"2013-12-10 02:55:20.000000000","message":"This is just something that stood out to me. On this line you have\n\n assertEqual(observed, expected)\n\nand the next line\n\n assertEqual(expected, observed)\n\nFWIW testtools defines assertEqual as\n\n def assertEqual(self, expected, observed, message\u003d\u0027\u0027)\n\nthough in practice it doesn\u0027t make much difference. That said, it would be easier to read if you had the same handness within the same test.","commit_id":"21438085c8e37bc102d6858511670aec35cc73aa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"38bf7abec3df9fb0d362d898df8700c98c98670e","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                     \u0027nova_object.version\u0027: \u00271.2\u0027,"},{"line_number":417,"context_line":"                     \u0027nova_object.data\u0027: {\u0027foo\u0027: 1}}"},{"line_number":418,"context_line":"        obj \u003d MyObj.obj_from_primitive(primitive)"},{"line_number":419,"context_line":"        self.assertEqual(obj.foo, 1)"},{"line_number":420,"context_line":"        self.assertEqual(\u00271.2\u0027, obj.VERSION)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def test_hydration_bad_ns(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9h6Y%3D","line":419,"in_reply_to":"AAAATn%2F9kyI%3D","updated":"2013-12-10 15:01:03.000000000","message":"Yeah, the rest of the file is wrong, so when I copied some code I forgot to fix it, but then wrote my new line properly. If I have to rebase I\u0027ll fix it, thanks!","commit_id":"21438085c8e37bc102d6858511670aec35cc73aa"}]}