)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"47e9888815d791073d5b20a7782237deb05d5aa4","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                instance.info_cache \u003d None"},{"line_number":244,"context_line":"            elif not instance.obj_attr_is_set(\u0027info_cache\u0027):"},{"line_number":245,"context_line":"                instance.info_cache \u003d instance_info_cache.InstanceInfoCache()"},{"line_number":246,"context_line":"            if instance.info_cache is not None:"},{"line_number":247,"context_line":"                instance_info_cache.InstanceInfoCache._from_db_object("},{"line_number":248,"context_line":"                    context, instance.info_cache, db_inst[\u0027info_cache\u0027])"},{"line_number":249,"context_line":"        if \u0027security_groups\u0027 in expected_attrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9wlA%3D","line":246,"updated":"2013-12-06 09:44:56.000000000","message":"OK so we will always load the proper version here, if we missed the elif branch (we got smth from the DB, and we had the sub-object set on the object with the proper version).\n\nHowever if we DID NOT have it set on the object - we\u0027ll always load the current version the code is deployed.\n\nIIUC we are skipping the is-compatible check here (arguably we don\u0027t need it, but this code seems to be very unclear about what it wants to do).\n\nCorrect me if I\u0027m wrong here","commit_id":"7d73057d9807e363ef1aefd50a556ee2b1069c2c"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"98ae45cd0f3b423cc30a07a109b4c937d1e26bbd","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            if db_inst[\u0027info_cache\u0027] is None:"},{"line_number":243,"context_line":"                instance.info_cache \u003d None"},{"line_number":244,"context_line":"            elif not instance.obj_attr_is_set(\u0027info_cache\u0027):"},{"line_number":245,"context_line":"                instance.info_cache \u003d instance_info_cache.InstanceInfoCache()"},{"line_number":246,"context_line":"            if instance.info_cache is not None:"},{"line_number":247,"context_line":"                instance_info_cache.InstanceInfoCache._from_db_object("},{"line_number":248,"context_line":"                    context, instance.info_cache, db_inst[\u0027info_cache\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9USE%3D","line":245,"updated":"2013-12-12 18:09:11.000000000","message":"No comment on my previous comment??!? :)\n\nSeriously - we should at least put a NOTE that this should be creating a different version once the mechanism is in place.","commit_id":"e3562affc32311a4eea2a81c8a25c8469c1eda3c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c317e59138507f791c1a8fa6fa250c1cf4312b14","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            if db_inst[\u0027info_cache\u0027] is None:"},{"line_number":243,"context_line":"                instance.info_cache \u003d None"},{"line_number":244,"context_line":"            elif not instance.obj_attr_is_set(\u0027info_cache\u0027):"},{"line_number":245,"context_line":"                instance.info_cache \u003d instance_info_cache.InstanceInfoCache()"},{"line_number":246,"context_line":"            if instance.info_cache is not None:"},{"line_number":247,"context_line":"                instance_info_cache.InstanceInfoCache._from_db_object("},{"line_number":248,"context_line":"                    context, instance.info_cache, db_inst[\u0027info_cache\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UH8%3D","line":245,"in_reply_to":"AAAATn%2F9USE%3D","updated":"2013-12-12 18:33:10.000000000","message":"Sure, sorry I missed that.","commit_id":"e3562affc32311a4eea2a81c8a25c8469c1eda3c"}]}