)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"799a133a115f75a6ed1f2ee60a6088d7289fe9ec","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The policy to allow booting instances without a volume when"},{"line_number":10,"context_line":"root_gb is set to 0 was to be set to default to RULE_ADMIN_API"},{"line_number":11,"context_line":"once the Stein release is out."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I247402b6c4ff8a7cb71ef247a218478194d68ff8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_220ec7e3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":30},"updated":"2018-09-19 21:08:40.000000000","message":"Do you mean once Rocky is out? Or when Stein is out, as in \"in Stein?\" because for CDers (let\u0027s at least assume they exist, ideally), this would be before Stein is GA\u0027ed.\n\nMaybe just reword to, \"default to admin-only in Stein.\"","commit_id":"db1ac86153bec0efd4b5ae01883043f522e52163"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"799a133a115f75a6ed1f2ee60a6088d7289fe9ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The policy to allow booting instances without a volume when"},{"line_number":10,"context_line":"root_gb is set to 0 was to be set to default to RULE_ADMIN_API"},{"line_number":11,"context_line":"once the Stein release is out."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I247402b6c4ff8a7cb71ef247a218478194d68ff8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0224eb5e","line":12,"updated":"2018-09-19 21:08:40.000000000","message":"Add Related-Bug: ##1739646 for context.","commit_id":"db1ac86153bec0efd4b5ae01883043f522e52163"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ef9649b796c70bcada3e6acde877e527a7967b2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"root_gb is set to 0 was to be set to default to admin-only"},{"line_number":11,"context_line":"in Stein."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I537c299b0cd400982189f35b31df74755422737e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Matt Riedemann \u003cmriedem.os@gmail.com\u003e"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_9627c5c7","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2019-02-14 18:30:53.000000000","message":"merged","commit_id":"c8e65a5eb11515cfe70f8e6850b842cd594af6a5"}],"nova/policies/servers.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"96b77e1cfee85d5b80fec54ef73085d204792889","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        ]),"},{"line_number":141,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":142,"context_line":"        ZERO_DISK_FLAVOR,"},{"line_number":143,"context_line":"        RULE_ADMIN_API,"},{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"This rule controls the compute API validation behavior of creating a server"},{"line_number":146,"context_line":"with a flavor that has 0 disk, indicating the server should be volume-backed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a1b3b299","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":22},"updated":"2018-09-20 02:27:49.000000000","message":"base.RULE_ADMIN_API","commit_id":"b52218a7de242b5fc62ba3e2a2b5eae033787686"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d26426b516a6b7fdf9c9313465a96a48b29068f2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"the local disk of the compute (or shared storage cluster). See bug"},{"line_number":157,"context_line":"https://bugs.launchpad.net/nova/+bug/1739646 for details."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"This rule defaults to ``rule:admin_or_owner`` for backward compatibility but"},{"line_number":160,"context_line":"will be changed to default to ``rule:admin_api`` in a subsequent release."},{"line_number":161,"context_line":"\"\"\","},{"line_number":162,"context_line":"        ["},{"line_number":163,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_218ec2d0","line":160,"range":{"start_line":159,"start_character":23,"end_line":160,"end_character":73},"updated":"2018-09-20 02:27:01.000000000","message":"this need to be removed","commit_id":"b52218a7de242b5fc62ba3e2a2b5eae033787686"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"41ead3fd75edf694f24e9db1bb8363194f3bd65d","unresolved":false,"context_lines":[{"line_number":13148,"context_line":"                image, self.instance_type, None)"},{"line_number":13149,"context_line":""},{"line_number":13150,"context_line":"    def test_root_gb_zero_disables_size_check(self):"},{"line_number":13151,"context_line":"        self.policy.set_rules({"},{"line_number":13152,"context_line":"            servers_policy.ZERO_DISK_FLAVOR: servers_policy.RULE_AOO"},{"line_number":13153,"context_line":"        }, overwrite\u003dFalse)"},{"line_number":13154,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13155,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, size\u003d\u00271073741825\u0027)"},{"line_number":13156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_00423568","line":13153,"range":{"start_line":13151,"start_character":0,"end_line":13153,"end_character":27},"updated":"2018-12-03 02:26:52.000000000","message":"IMO, it is better to use an admin context instead of changing the default policy.","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"80ae3210563d53a269db247198fdbce025c71b5e","unresolved":false,"context_lines":[{"line_number":13148,"context_line":"                image, self.instance_type, None)"},{"line_number":13149,"context_line":""},{"line_number":13150,"context_line":"    def test_root_gb_zero_disables_size_check(self):"},{"line_number":13151,"context_line":"        self.policy.set_rules({"},{"line_number":13152,"context_line":"            servers_policy.ZERO_DISK_FLAVOR: servers_policy.RULE_AOO"},{"line_number":13153,"context_line":"        }, overwrite\u003dFalse)"},{"line_number":13154,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13155,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, size\u003d\u00271073741825\u0027)"},{"line_number":13156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ab223d0d","line":13153,"range":{"start_line":13151,"start_character":0,"end_line":13153,"end_character":27},"in_reply_to":"3f79a3b5_00423568","updated":"2018-12-03 12:30:32.000000000","message":"Aren\u0027t we testing policy in this case so we actually want to make sure that the policy is being enforced if it\u0027s set to admin_or_owner ?","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9b2486a74cea57fb064e2908430ed91318c2d6c0","unresolved":false,"context_lines":[{"line_number":13148,"context_line":"                image, self.instance_type, None)"},{"line_number":13149,"context_line":""},{"line_number":13150,"context_line":"    def test_root_gb_zero_disables_size_check(self):"},{"line_number":13151,"context_line":"        self.policy.set_rules({"},{"line_number":13152,"context_line":"            servers_policy.ZERO_DISK_FLAVOR: servers_policy.RULE_AOO"},{"line_number":13153,"context_line":"        }, overwrite\u003dFalse)"},{"line_number":13154,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13155,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, size\u003d\u00271073741825\u0027)"},{"line_number":13156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c548cfb6","line":13153,"range":{"start_line":13151,"start_character":0,"end_line":13153,"end_character":27},"in_reply_to":"3f79a3b5_1b0cb194","updated":"2018-12-14 01:04:03.000000000","message":"Originally this test is not to check the policy, just check whether executing \u0027_check_requested_image\u0027 method is successfull or not.\nIMO, it is not necessary to check the policy expressly here.","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"894c7217278bf1eed90de7215d6165e4a2cef710","unresolved":false,"context_lines":[{"line_number":13148,"context_line":"                image, self.instance_type, None)"},{"line_number":13149,"context_line":""},{"line_number":13150,"context_line":"    def test_root_gb_zero_disables_size_check(self):"},{"line_number":13151,"context_line":"        self.policy.set_rules({"},{"line_number":13152,"context_line":"            servers_policy.ZERO_DISK_FLAVOR: servers_policy.RULE_AOO"},{"line_number":13153,"context_line":"        }, overwrite\u003dFalse)"},{"line_number":13154,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13155,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, size\u003d\u00271073741825\u0027)"},{"line_number":13156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1b0cb194","line":13153,"range":{"start_line":13151,"start_character":0,"end_line":13153,"end_character":27},"in_reply_to":"3f79a3b5_ab223d0d","updated":"2018-12-04 23:01:18.000000000","message":"It probably doesn\u0027t matter either way, I\u0027m not sure it warrants a -1.","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"41ead3fd75edf694f24e9db1bb8363194f3bd65d","unresolved":false,"context_lines":[{"line_number":13154,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13155,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, size\u003d\u00271073741825\u0027)"},{"line_number":13156,"context_line":""},{"line_number":13157,"context_line":"        self.compute_api._check_requested_image(self.context, image[\u0027id\u0027],"},{"line_number":13158,"context_line":"                image, self.instance_type, None)"},{"line_number":13159,"context_line":""},{"line_number":13160,"context_line":"    def test_root_gb_zero_disables_min_disk(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c06afde8","line":13157,"range":{"start_line":13157,"start_character":48,"end_line":13157,"end_character":60},"updated":"2018-12-03 02:26:52.000000000","message":"context.get_admin_context()","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"41ead3fd75edf694f24e9db1bb8363194f3bd65d","unresolved":false,"context_lines":[{"line_number":13158,"context_line":"                image, self.instance_type, None)"},{"line_number":13159,"context_line":""},{"line_number":13160,"context_line":"    def test_root_gb_zero_disables_min_disk(self):"},{"line_number":13161,"context_line":"        self.policy.set_rules({"},{"line_number":13162,"context_line":"            servers_policy.ZERO_DISK_FLAVOR: servers_policy.RULE_AOO"},{"line_number":13163,"context_line":"        }, overwrite\u003dFalse)"},{"line_number":13164,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13165,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, min_disk\u003d\u00272\u0027)"},{"line_number":13166,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e03cd9eb","line":13163,"range":{"start_line":13161,"start_character":0,"end_line":13163,"end_character":27},"updated":"2018-12-03 02:26:52.000000000","message":"ditto","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"41ead3fd75edf694f24e9db1bb8363194f3bd65d","unresolved":false,"context_lines":[{"line_number":13164,"context_line":"        self.instance_type[\u0027root_gb\u0027] \u003d 0"},{"line_number":13165,"context_line":"        image \u003d dict(id\u003d\u0027123\u0027, status\u003d\u0027active\u0027, min_disk\u003d\u00272\u0027)"},{"line_number":13166,"context_line":""},{"line_number":13167,"context_line":"        self.compute_api._check_requested_image(self.context, image[\u0027id\u0027],"},{"line_number":13168,"context_line":"                image, self.instance_type, None)"},{"line_number":13169,"context_line":""},{"line_number":13170,"context_line":"    def test_config_drive_option(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_807405cf","line":13167,"range":{"start_line":13167,"start_character":48,"end_line":13167,"end_character":60},"updated":"2018-12-03 02:26:52.000000000","message":"ditto","commit_id":"de52f3c501eb148242042a228d4472c28098d9a0"}],"releasenotes/notes/default-zero-disk-flavor-to-admin-api-fd99e162812c2c7f.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"737b60d94f5caa387dfdf5df1a3e20c6bb778738","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Users can no longer create instances using instance types that have zero disk"},{"line_number":4,"context_line":"    flavor without specifying a volume by default.  This can be controlled by"},{"line_number":5,"context_line":"    changing the `os_compute_api:servers:create:zero_disk_flavor` policy."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_745be8f7","line":3,"range":{"start_line":3,"start_character":47,"end_line":3,"end_character":61},"updated":"2018-11-29 00:01:52.000000000","message":"flavors","commit_id":"7ea17a65e3d52de1188168924709d2c967e0bbda"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"737b60d94f5caa387dfdf5df1a3e20c6bb778738","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Users can no longer create instances using instance types that have zero disk"},{"line_number":4,"context_line":"    flavor without specifying a volume by default.  This can be controlled by"},{"line_number":5,"context_line":"    changing the `os_compute_api:servers:create:zero_disk_flavor` policy."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_5456ecd2","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":40},"updated":"2018-11-29 00:01:52.000000000","message":"servers (use the resource name from the API)","commit_id":"7ea17a65e3d52de1188168924709d2c967e0bbda"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"737b60d94f5caa387dfdf5df1a3e20c6bb778738","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Users can no longer create instances using instance types that have zero disk"},{"line_number":4,"context_line":"    flavor without specifying a volume by default.  This can be controlled by"},{"line_number":5,"context_line":"    changing the `os_compute_api:servers:create:zero_disk_flavor` policy."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_145074d1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2018-11-29 00:01:52.000000000","message":"nix","commit_id":"7ea17a65e3d52de1188168924709d2c967e0bbda"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf50ad097c2dc90523f752a4ed44fecb4d6bb7e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Users can no longer create servers using flavors that have zero disk"},{"line_number":4,"context_line":"    without specifying a volume by default.  This can be controlled by"},{"line_number":5,"context_line":"    changing the ``os_compute_api:servers:create:zero_disk_flavor`` policy."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_14ece903","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":9},"updated":"2018-11-29 12:59:57.000000000","message":"this is not for all users. only users does not have acces to that policy. we should exaplin it in more detail including - ``os_compute_api:servers:create:zero_disk_flavor`` policy default value is changed from \u0027admin or owner\u0027 to \u0027admin\u0027 so if you are dependent on policy default value then, it might effect the non admin user.\nBy Default only admin will be able to create servers using flavors that have zero disk without specifying a volume by default.","commit_id":"27c3f4d25c7111951f3a1c1f8538c9fa757ce72f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bec5f6e3591dbd23f5b4cf3c128ad91c014628e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Users can no longer create servers using flavors that have zero disk"},{"line_number":4,"context_line":"    without specifying a volume by default.  This can be controlled by"},{"line_number":5,"context_line":"    changing the ``os_compute_api:servers:create:zero_disk_flavor`` policy."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_526ed865","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":9},"in_reply_to":"3f79a3b5_14ece903","updated":"2018-11-30 15:59:49.000000000","message":"Done","commit_id":"27c3f4d25c7111951f3a1c1f8538c9fa757ce72f"}]}