)]}'
{"nova/virt/xenapi/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54c760301040dbaeb06ea74e39e8cc2ac1c000ea","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            max_head \u003d (\u0027HW_GPU_MAX_DISPLAY_HEADS_\u0027 +"},{"line_number":549,"context_line":"                        str(grp_value[\u0027max_heads\u0027]))"},{"line_number":550,"context_line":"            traits_to_add \u003d [max_head] + [resolution]"},{"line_number":551,"context_line":"            LOG.info(\u0027Traits is %s\u0027, traits_to_add)"},{"line_number":552,"context_line":"            bUpdate \u003d False"},{"line_number":553,"context_line":"            if not rp_tree.exists(rp_name):"},{"line_number":554,"context_line":"                # Set gpu group uuid as the resource provider uuid. When nova"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_60d8f051","line":551,"updated":"2018-09-24 13:31:15.000000000","message":"A better log message might be:\n\n LOG.debug(\"Setting traits on provider %s to %s\", rp_name, traits_to_add)","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"a333249ef97471b8fd0440fef4128c3062ffbbfb","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            max_head \u003d (\u0027HW_GPU_MAX_DISPLAY_HEADS_\u0027 +"},{"line_number":549,"context_line":"                        str(grp_value[\u0027max_heads\u0027]))"},{"line_number":550,"context_line":"            traits_to_add \u003d [max_head] + [resolution]"},{"line_number":551,"context_line":"            LOG.info(\u0027Traits is %s\u0027, traits_to_add)"},{"line_number":552,"context_line":"            bUpdate \u003d False"},{"line_number":553,"context_line":"            if not rp_tree.exists(rp_name):"},{"line_number":554,"context_line":"                # Set gpu group uuid as the resource provider uuid. When nova"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0c160b5a","line":551,"in_reply_to":"3f79a3b5_60d8f051","updated":"2018-09-25 01:38:30.000000000","message":"Got it, thanks, Jay.","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54c760301040dbaeb06ea74e39e8cc2ac1c000ea","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        str(grp_value[\u0027max_heads\u0027]))"},{"line_number":550,"context_line":"            traits_to_add \u003d [max_head] + [resolution]"},{"line_number":551,"context_line":"            LOG.info(\u0027Traits is %s\u0027, traits_to_add)"},{"line_number":552,"context_line":"            bUpdate \u003d False"},{"line_number":553,"context_line":"            if not rp_tree.exists(rp_name):"},{"line_number":554,"context_line":"                # Set gpu group uuid as the resource provider uuid. When nova"},{"line_number":555,"context_line":"                # compute requests to spawn an instance, it will send it to"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_40dff437","line":552,"updated":"2018-09-24 13:31:15.000000000","message":"how about calling the variable \"needs_update\" instead of bUpdate?","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"a333249ef97471b8fd0440fef4128c3062ffbbfb","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        str(grp_value[\u0027max_heads\u0027]))"},{"line_number":550,"context_line":"            traits_to_add \u003d [max_head] + [resolution]"},{"line_number":551,"context_line":"            LOG.info(\u0027Traits is %s\u0027, traits_to_add)"},{"line_number":552,"context_line":"            bUpdate \u003d False"},{"line_number":553,"context_line":"            if not rp_tree.exists(rp_name):"},{"line_number":554,"context_line":"                # Set gpu group uuid as the resource provider uuid. When nova"},{"line_number":555,"context_line":"                # compute requests to spawn an instance, it will send it to"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6c277fc9","line":552,"in_reply_to":"3f79a3b5_40dff437","updated":"2018-09-25 01:38:30.000000000","message":"Will modify it.","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54c760301040dbaeb06ea74e39e8cc2ac1c000ea","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                bUpdate \u003d True"},{"line_number":573,"context_line":"            elif rp_tree.have_traits_changed(rp_name, traits_to_add):"},{"line_number":574,"context_line":"                inv[fields.ResourceClass.VGPU][\u0027reserved\u0027] \u003d grp_value["},{"line_number":575,"context_line":"                        \u0027total\u0027]"},{"line_number":576,"context_line":"                bUpdate \u003d True"},{"line_number":577,"context_line":"            if bUpdate:"},{"line_number":578,"context_line":"                rp_tree.add_traits(rp_name, *traits_to_add)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_60e230d7","line":575,"updated":"2018-09-24 13:31:15.000000000","message":"Why are you updating inventory if traits change?","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"a333249ef97471b8fd0440fef4128c3062ffbbfb","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                bUpdate \u003d True"},{"line_number":573,"context_line":"            elif rp_tree.have_traits_changed(rp_name, traits_to_add):"},{"line_number":574,"context_line":"                inv[fields.ResourceClass.VGPU][\u0027reserved\u0027] \u003d grp_value["},{"line_number":575,"context_line":"                        \u0027total\u0027]"},{"line_number":576,"context_line":"                bUpdate \u003d True"},{"line_number":577,"context_line":"            if bUpdate:"},{"line_number":578,"context_line":"                rp_tree.add_traits(rp_name, *traits_to_add)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a70b7020","line":575,"in_reply_to":"3f79a3b5_60e230d7","updated":"2018-09-25 01:38:30.000000000","message":"Hi, Jay, according to the previous discussion with jianghua, if the traits changes, we will treat it as vgpu configure changes, so we will reserve all the resource.\nBut it\u0027s only happened when there is a vgpu instance allocated. Will modify that.","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54c760301040dbaeb06ea74e39e8cc2ac1c000ea","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                        \u0027total\u0027]"},{"line_number":576,"context_line":"                bUpdate \u003d True"},{"line_number":577,"context_line":"            if bUpdate:"},{"line_number":578,"context_line":"                rp_tree.add_traits(rp_name, *traits_to_add)"},{"line_number":579,"context_line":"                rp_tree.update_inventory(rp_name, inv)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        if allocations is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e0d5e0e7","line":578,"updated":"2018-09-24 13:31:15.000000000","message":"This is only necessary if the traits have changed, though, which is why this should be executed in the block of code from line 573-576.\n\nI\u0027m actually not sure you needed to have this bUpdate variable at all, or change any of the code paths that were used for update_inventory().\n\nHow about undoing all the bUpdate changes, moving all the traits processing to below 579 and just doing this instead?\n\n if rp_tree.have_traits_changed(rp_name, traits_to_add):\n     rp_tree.add_traits(rp_name, *traits_to_add)","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"a333249ef97471b8fd0440fef4128c3062ffbbfb","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                        \u0027total\u0027]"},{"line_number":576,"context_line":"                bUpdate \u003d True"},{"line_number":577,"context_line":"            if bUpdate:"},{"line_number":578,"context_line":"                rp_tree.add_traits(rp_name, *traits_to_add)"},{"line_number":579,"context_line":"                rp_tree.update_inventory(rp_name, inv)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        if allocations is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a734d0e0","line":578,"in_reply_to":"3f79a3b5_e0d5e0e7","updated":"2018-09-25 01:38:30.000000000","message":"Will change it, thanks.","commit_id":"0bf1b9c9445464a2e79b04fc49835a3e57ca9102"}]}