)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cf8791ae757daaf4f525bc90b6ab9cf592e54f7","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                                                 database\u003d\u0027placement\u0027)"},{"line_number":865,"context_line":"        else:"},{"line_number":866,"context_line":"            print(\"nova-manage: Placement api database will\""},{"line_number":867,"context_line":"                  \" not sync, because [placement_database]/\""},{"line_number":868,"context_line":"                  \"connection is not configured.\")"},{"line_number":869,"context_line":"        if CONF.api_database.connection is not None:"},{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c245659c","line":867,"range":{"start_line":867,"start_character":19,"end_line":867,"end_character":20},"updated":"2018-09-21 16:00:30.000000000","message":"nit: prefer space at the end of the previous line","commit_id":"923b3102ab886d3453b522188c3fdfc07c4e8861"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"57fc5e584e96c7f8bb38053a66a22d9eedf41f30","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                                                 database\u003d\u0027placement\u0027)"},{"line_number":865,"context_line":"        else:"},{"line_number":866,"context_line":"            print(\"nova-manage: Placement api database will\""},{"line_number":867,"context_line":"                  \" not sync, because [placement_database]/\""},{"line_number":868,"context_line":"                  \"connection is not configured.\")"},{"line_number":869,"context_line":"        if CONF.api_database.connection is not None:"},{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e28741b5","line":867,"range":{"start_line":867,"start_character":19,"end_line":867,"end_character":20},"in_reply_to":"3f79a3b5_c245659c","updated":"2018-09-21 17:15:43.000000000","message":"changed","commit_id":"923b3102ab886d3453b522188c3fdfc07c4e8861"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cf8791ae757daaf4f525bc90b6ab9cf592e54f7","unresolved":false,"context_lines":[{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"},{"line_number":871,"context_line":"        else:"},{"line_number":872,"context_line":"            print(\"nova-manage: Nova api database will\""},{"line_number":873,"context_line":"                \" not sync, because [api_database]/\""},{"line_number":874,"context_line":"                \"connection is not configured.\")"},{"line_number":875,"context_line":"        return result_api and result_placement"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a2df09d5","line":873,"range":{"start_line":873,"start_character":17,"end_line":873,"end_character":18},"updated":"2018-09-21 16:00:30.000000000","message":"ditto","commit_id":"923b3102ab886d3453b522188c3fdfc07c4e8861"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"57fc5e584e96c7f8bb38053a66a22d9eedf41f30","unresolved":false,"context_lines":[{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"},{"line_number":871,"context_line":"        else:"},{"line_number":872,"context_line":"            print(\"nova-manage: Nova api database will\""},{"line_number":873,"context_line":"                \" not sync, because [api_database]/\""},{"line_number":874,"context_line":"                \"connection is not configured.\")"},{"line_number":875,"context_line":"        return result_api and result_placement"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_02835daa","line":873,"range":{"start_line":873,"start_character":17,"end_line":873,"end_character":18},"in_reply_to":"3f79a3b5_a2df09d5","updated":"2018-09-21 17:15:43.000000000","message":"changed","commit_id":"923b3102ab886d3453b522188c3fdfc07c4e8861"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"01a8475457b1a1074d47882b3694f5b51d3ca963","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        else:"},{"line_number":866,"context_line":"            print(\"nova-manage: Placement api database will \""},{"line_number":867,"context_line":"                  \"not sync, because [placement_database]/\""},{"line_number":868,"context_line":"                  \"connection is not configured.\")"},{"line_number":869,"context_line":"        if CONF.api_database.connection is not None:"},{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"},{"line_number":871,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ef1cf3c3","line":868,"updated":"2018-09-24 11:15:47.000000000","message":"We _may_ not want to do this, because this message makes it seem like the [placement_database]/connection is supposed to be configured. In rocky it is optional but not required. And with luck, in Stein the code for syncing placement db will be in openstack/placement.","commit_id":"679558d0f06ac4c39a00ea3bced8ab2c678537da"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"01a8475457b1a1074d47882b3694f5b51d3ca963","unresolved":false,"context_lines":[{"line_number":866,"context_line":"            print(\"nova-manage: Placement api database will \""},{"line_number":867,"context_line":"                  \"not sync, because [placement_database]/\""},{"line_number":868,"context_line":"                  \"connection is not configured.\")"},{"line_number":869,"context_line":"        if CONF.api_database.connection is not None:"},{"line_number":870,"context_line":"            result_api \u003d migration.db_sync(version2, database\u003d\u0027api\u0027)"},{"line_number":871,"context_line":"        else:"},{"line_number":872,"context_line":"            print(\"nova-manage: Nova api database will \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_af5d9b7d","line":869,"updated":"2018-09-24 11:15:47.000000000","message":"Doing this implies that having the api_database _not_ configured is okay. It\u0027s not. Anywhere you\u0027re likely to run nova-manage you almost certainly want the api db configured.","commit_id":"679558d0f06ac4c39a00ea3bced8ab2c678537da"}]}