)]}'
{"gate/test_evacuate.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58d740148c0ecd0254d4e9f49a4cf2d07cd3fb9f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":115,"context_line":"# the root volume from an image."},{"line_number":116,"context_line":"nova boot --flavor ${flavor} --poll \\"},{"line_number":117,"context_line":"--block-device id\u003d${image},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":118,"context_line":"evacuate-bfv-test"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"nova evacuate evacuate-bfv-test"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_f46138d6","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":25},"updated":"2018-09-21 19:56:36.000000000","message":"Ah this isn\u0027t an image ID:\n\nhttp://logs.openstack.org/97/604397/2/check/nova-live-migration/4302638/logs/devstack-gate-post_test_hook.txt.gz#_2018-09-21_18_45_18_171\n\nERROR (BadRequest): Block Device Mapping is Invalid: failed to get image cirros-0.3.5-x86_64-disk. (HTTP 400) (Request-ID: req-d592d7b4-7002-4d0d-a141-aee778b644c8)","commit_id":"e2639229dccae6dd5dd738da9f267f6d8e5d06e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77abf443b168180d603e6110f41e9871a1cb0aa7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":119,"context_line":"evacuate-bfv-test"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"nova evacuate evacuate-bfv-test"},{"line_number":122,"context_line":"# Wait for the instance to go into ACTIVE state from the evacuate."},{"line_number":123,"context_line":"# TODO(mriedem): Move the polling loops into a common function."},{"line_number":124,"context_line":"count\u003d0"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_495c117d","line":121,"updated":"2018-09-22 16:33:35.000000000","message":"Oh yeah this fails because the service is still running, need to force it down first.","commit_id":"290d8ad5a9abb126e67564c0594d5ef14e174071"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2b8afed9ef4fbd7d196ae1a72db6b1f95c026c22","unresolved":false,"context_lines":[{"line_number":118,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":119,"context_line":"evacuate-bfv-test"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"nova evacuate evacuate-bfv-test"},{"line_number":122,"context_line":"# Wait for the instance to go into ACTIVE state from the evacuate."},{"line_number":123,"context_line":"# TODO(mriedem): Move the polling loops into a common function."},{"line_number":124,"context_line":"count\u003d0"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_0e38389d","line":121,"in_reply_to":"3f79a3b5_495c117d","updated":"2018-09-25 11:49:14.000000000","message":"Took the liberty of attempting to fix this.\n\nSummary: create both instances first, then we only have to shuffle libvirt down and up once.","commit_id":"290d8ad5a9abb126e67564c0594d5ef14e174071"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1618ff4890b92110e706e5319dca912f6497952f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"openstack server create --image ${image_id} --flavor ${flavor_id} \\"},{"line_number":47,"context_line":"--availability-zone nova:${subnode} --wait evacuate-test"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"echo \"Creating BFV test server on subnode\""},{"line_number":50,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":51,"context_line":"# the root volume from an image."},{"line_number":52,"context_line":"nova boot --flavor ${flavor_id} --poll \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_4d2ab32f","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":41},"updated":"2018-09-25 14:34:16.000000000","message":"This isn\u0027t true because you\u0027re not forcing it to the subnode using:\n\n--availability-zone nova:${subnode}","commit_id":"58e9e0f1d4c6e01103d2272eeb8f6c95b2631f2c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cfec33fd357d8a37ebe3974af1a5c329b7e7c0c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"openstack server create --image ${image_id} --flavor ${flavor_id} \\"},{"line_number":47,"context_line":"--availability-zone nova:${subnode} --wait evacuate-test"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"echo \"Creating BFV test server on subnode\""},{"line_number":50,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":51,"context_line":"# the root volume from an image."},{"line_number":52,"context_line":"nova boot --flavor ${flavor_id} --poll \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_8d7c4bb7","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":41},"in_reply_to":"3f79a3b5_4d2ab32f","updated":"2018-09-25 14:54:58.000000000","message":"Ack. Also need to wait for it to finish.","commit_id":"58e9e0f1d4c6e01103d2272eeb8f6c95b2631f2c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a621555154be772739d1423df1c991c6df4758a4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# during evacuate and bypassing the scheduler is a very bad idea, but we\u0027re"},{"line_number":67,"context_line":"# doing a negative test here."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"function evacuate_and_wait_for_error() {"},{"line_number":70,"context_line":"    local server\u003d\"$1\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    echo \"Forcing evacuate of ${server} to local host\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_ee005cb4","line":69,"updated":"2018-09-25 11:53:05.000000000","message":"There comes a point in the life of a bash script, some time round about when you define your first function, and definitely by the time you need to start reading the manpage, that you start to wonder whether you should have used another language :)","commit_id":"58e9e0f1d4c6e01103d2272eeb8f6c95b2631f2c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"779c95755e428c7af332b6bf75a695a4b7b74855","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# the root volume from an image."},{"line_number":52,"context_line":"nova boot --flavor ${flavor_id} --poll \\"},{"line_number":53,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":54,"context_line":"--availability-zone nova:${subnode} --poll evacuate-bfv-test"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""},{"line_number":57,"context_line":"openstack --os-compute-api-version 2.11 compute service set --down ${subnode} nova-compute"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f79a3b5_ce121dfe","line":54,"range":{"start_line":54,"start_character":36,"end_line":54,"end_character":42},"updated":"2018-09-26 15:59:10.000000000","message":"Eurgh: I added that. Didn\u0027t notice it was already there.","commit_id":"c5bbf50e6c70d50942a8758abe0ec620e20e3961"}]}