)]}'
{"doc/source/reference/upgrade-checks.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5bf53b67ea941408bb729fb70d123d250d0bf0aa","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  * Install new code"},{"line_number":67,"context_line":"  * Sync the database schema for new models"},{"line_number":68,"context_line":"    (nova-manage api_db sync; nova-manage db sync)"},{"line_number":69,"context_line":"  * Run the online data migrations (nova-manage db online_data_migrations)"},{"line_number":70,"context_line":"  * Run the upgrade check (nova-status upgrade check)"},{"line_number":71,"context_line":"  * Restart services with new code"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_52538a6c","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":49},"updated":"2018-10-15 15:22:34.000000000","message":"You got the rest of them but ``literal`` needed here and on the below lines","commit_id":"c07e5c4664e0043b7ac5aa9837b0709f728ea2bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3e7ee940755833a7a43cb5b1ca529cad3d8ada4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  * Install new code"},{"line_number":67,"context_line":"  * Sync the database schema for new models"},{"line_number":68,"context_line":"    (nova-manage api_db sync; nova-manage db sync)"},{"line_number":69,"context_line":"  * Run the online data migrations (nova-manage db online_data_migrations)"},{"line_number":70,"context_line":"  * Run the upgrade check (nova-status upgrade check)"},{"line_number":71,"context_line":"  * Restart services with new code"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cdb93fec","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":49},"in_reply_to":"3f79a3b5_52538a6c","updated":"2018-10-15 15:43:14.000000000","message":"Done","commit_id":"c07e5c4664e0043b7ac5aa9837b0709f728ea2bf"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8b1ceae49d39a9ea95a0c817a2f289bc7829c90d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Sync the database schema for new models"},{"line_number":68,"context_line":"    (nova-manage api_db sync; nova-manage db sync)"},{"line_number":69,"context_line":"  * Run the online data migrations (nova-manage db online_data_migrations)"},{"line_number":70,"context_line":"  * Run the upgrade check (nova-status upgrade check)"},{"line_number":71,"context_line":"  * Restart services with new code"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Checks must be idempotent so they can be run repeatedly and the results are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_9ae10d2f","line":70,"updated":"2018-09-21 21:58:54.000000000","message":"Hmm, this is problematic for the Designate check since that needs to happen before the db sync. Do you expect any problems if other services have the check run in a different place in the upgrade?","commit_id":"c07e5c4664e0043b7ac5aa9837b0709f728ea2bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e04d9c66f4ccc42af49136f524927548503cd605","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  * Sync the database schema for new models"},{"line_number":68,"context_line":"    (nova-manage api_db sync; nova-manage db sync)"},{"line_number":69,"context_line":"  * Run the online data migrations (nova-manage db online_data_migrations)"},{"line_number":70,"context_line":"  * Run the upgrade check (nova-status upgrade check)"},{"line_number":71,"context_line":"  * Restart services with new code"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Checks must be idempotent so they can be run repeatedly and the results are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a91cc5c2","line":70,"in_reply_to":"3f79a3b5_9ae10d2f","updated":"2018-09-22 16:21:20.000000000","message":"The initial nova checks in ocata relied on the api_db sync running to create the cell_mappings table/schema so yeah in the case of nova it would fail if the table didn\u0027t exist - I\u0027m not sure exactly how it would fail - you might get a 255 exit code from the CLI, which is probably OK if you\u0027re just checking for failures. The tricky thing is going to be that deployment tools will require conditional logic based on the project to know when they should run the check (before or after db sync), and that kind of defeats the purpose of have consistent idempotent checks.\n\nHaving said that, I think it\u0027s OK if the checks are written to be idempotent enough to handle the db sync to having not been run yet, but in the case of nova we certainly aren\u0027t testing it that way (the schema migrations run before the tests as part of the test setup).","commit_id":"c07e5c4664e0043b7ac5aa9837b0709f728ea2bf"}]}