)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"64a08154de8878ea13ba7ec8de88becc20a60000","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # NOTE(Tao Li) Make sure we don\u0027t persist the retried hosts in"},{"line_number":352,"context_line":"        # request_spec table to avoid ignoring these hosts in next migration."},{"line_number":353,"context_line":"        request_spec.reset_retried_hosts()"},{"line_number":354,"context_line":"        # NOTE(sbauza): Make sure we persist the new flavor in case we had"},{"line_number":355,"context_line":"        # a successful scheduler call if and only if nothing bad happened"},{"line_number":356,"context_line":"        if request_spec.obj_what_changed():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_431d8d0e","line":353,"updated":"2018-10-09 00:11:21.000000000","message":"We had a bug like this in the past, which was fixed by this commit [1] and backported to Pike, available beginning in version 16.1.2. Based on the code in the commit, the request_spec.save() on L357 should not be persisting the retry information to the database.\n\nI commented similarly on the launchpad bug. Can you confirm whether you are using a version of nova later than 16.1.2?\n\n[1] https://github.com/openstack/nova/commit/6647f11dc1aba89f9b0e2703f236a43f31d88079","commit_id":"d26ef9e1d1315f563de4cbeac4129813bb976712"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6d8574662131465033504ac7040db2b19310847","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # NOTE(Tao Li) Make sure we don\u0027t persist the retried hosts in"},{"line_number":352,"context_line":"        # request_spec table to avoid ignoring these hosts in next migration."},{"line_number":353,"context_line":"        request_spec.reset_retried_hosts()"},{"line_number":354,"context_line":"        # NOTE(sbauza): Make sure we persist the new flavor in case we had"},{"line_number":355,"context_line":"        # a successful scheduler call if and only if nothing bad happened"},{"line_number":356,"context_line":"        if request_spec.obj_what_changed():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_138d1d31","line":353,"in_reply_to":"3f79a3b5_14581088","updated":"2019-06-13 16:44:48.000000000","message":"\u003e Hi melanie, we use version 9.1.1 of nova.\n \u003e \n \u003e [root@cdpm05 ~]# nova --version\n \u003e 9.1.1\n \u003e \n \u003e Maybe my version is old and I should banckport your commit. so the\n \u003e patch seems no need.\n\nThat\u0027s the version of python-novaclient, not the nova server.","commit_id":"d26ef9e1d1315f563de4cbeac4129813bb976712"},{"author":{"_account_id":9610,"name":"Tao Li","email":"litao3721@126.com","username":"Litao"},"change_message_id":"68f4406961ff6dd3069b31d9799457b0988927ed","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # NOTE(Tao Li) Make sure we don\u0027t persist the retried hosts in"},{"line_number":352,"context_line":"        # request_spec table to avoid ignoring these hosts in next migration."},{"line_number":353,"context_line":"        request_spec.reset_retried_hosts()"},{"line_number":354,"context_line":"        # NOTE(sbauza): Make sure we persist the new flavor in case we had"},{"line_number":355,"context_line":"        # a successful scheduler call if and only if nothing bad happened"},{"line_number":356,"context_line":"        if request_spec.obj_what_changed():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_14581088","line":353,"in_reply_to":"3f79a3b5_431d8d0e","updated":"2018-10-10 00:54:15.000000000","message":"Hi melanie, we use version 9.1.1 of nova.\n\n[root@cdpm05 ~]# nova --version\n9.1.1\n\nMaybe my version is old and I should banckport your commit. so the patch seems no need.","commit_id":"d26ef9e1d1315f563de4cbeac4129813bb976712"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"21fdbee5fe460972c132c341c128ad3b2c861052","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        return rebuild_args, compute_rebuild_args"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    @mock.patch.object(objects.RequestSpec, \u0027reset_retried_hosts\u0027)"},{"line_number":382,"context_line":"    @mock.patch.object(objects.InstanceMapping, \u0027get_by_instance_uuid\u0027)"},{"line_number":383,"context_line":"    @mock.patch.object(objects.RequestSpec, \u0027save\u0027)"},{"line_number":384,"context_line":"    @mock.patch.object(migrate.MigrationTask, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3f3a9997","line":381,"range":{"start_line":381,"start_character":3,"end_line":381,"end_character":66},"updated":"2018-09-29 07:28:56.000000000","message":"not sure we need this or not. let\u0027s see what others think","commit_id":"d26ef9e1d1315f563de4cbeac4129813bb976712"}]}