)]}'
{"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"85b2045803469103ecade6c785434099602737cf","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    database_connection is not specified, it will attempt to use the one"},{"line_number":259,"context_line":"    defined by ``[database]/connection`` in the configuration file. If a"},{"line_number":260,"context_line":"    transport_url is not specified, it will attempt to use the one defined by"},{"line_number":261,"context_line":"    ``[DEFAULT]/transport_url`` in the configuration file. The transport_url"},{"line_number":262,"context_line":"    option is not applicable to cell0 as it does not have a MQ. The meaning of"},{"line_number":263,"context_line":"    the various exit codes returned by this command are explained below:"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    * If successful, it will return 0."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_a7029071","line":262,"range":{"start_line":261,"start_character":59,"end_line":262,"end_character":63},"updated":"2019-03-04 06:44:29.000000000","message":"probably better put this in a note section?","commit_id":"8a499922fea6972f0837e5b88febd5e323c6d3d0"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"c658b86f07ccbf1ebb08a017f2540435d7f71ff1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    database_connection is not specified, it will attempt to use the one"},{"line_number":259,"context_line":"    defined by ``[database]/connection`` in the configuration file. If a"},{"line_number":260,"context_line":"    transport_url is not specified, it will attempt to use the one defined by"},{"line_number":261,"context_line":"    ``[DEFAULT]/transport_url`` in the configuration file. The transport_url"},{"line_number":262,"context_line":"    option is not applicable to cell0 as it does not have a MQ. The meaning of"},{"line_number":263,"context_line":"    the various exit codes returned by this command are explained below:"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    * If successful, it will return 0."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_a70da338","line":262,"range":{"start_line":261,"start_character":59,"end_line":262,"end_character":63},"in_reply_to":"9fdfeff1_a7029071","updated":"2019-03-06 15:06:12.000000000","message":"umm, sure I thought it would be better to keep this closer to the description for \"--transport_url\". But if this works better in the note section, wfm.","commit_id":"8a499922fea6972f0837e5b88febd5e323c6d3d0"}],"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b00d121aa651000554b1a97949156b1d8ce49d5a","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003ccell_name\u003e\u0027, dest\u003d\u0027name\u0027,"},{"line_number":1599,"context_line":"          help\u003d_(\u0027Set the cell name.\u0027))"},{"line_number":1600,"context_line":"    @args(\u0027--transport-url\u0027, metavar\u003d\u0027\u003ctransport_url\u003e\u0027, dest\u003d\u0027transport_url\u0027,"},{"line_number":1601,"context_line":"          help\u003d_(\u0027Set the cell transport_url. NOTE that running nodes \u0027"},{"line_number":1602,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1603,"context_line":"    @args(\u0027--database_connection\u0027, metavar\u003d\u0027\u003cdatabase_connection\u003e\u0027,"},{"line_number":1604,"context_line":"          dest\u003d\u0027db_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dcc65a16","line":1601,"updated":"2018-09-26 13:16:16.000000000","message":"Maybe update the help to mention that this does not apply to cell0. The doc too:\n\nhttps://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-cells-v2","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"8e1d4a1bf2e72575688982706349ee9ab474d81c","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003ccell_name\u003e\u0027, dest\u003d\u0027name\u0027,"},{"line_number":1599,"context_line":"          help\u003d_(\u0027Set the cell name.\u0027))"},{"line_number":1600,"context_line":"    @args(\u0027--transport-url\u0027, metavar\u003d\u0027\u003ctransport_url\u003e\u0027, dest\u003d\u0027transport_url\u0027,"},{"line_number":1601,"context_line":"          help\u003d_(\u0027Set the cell transport_url. NOTE that running nodes \u0027"},{"line_number":1602,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1603,"context_line":"    @args(\u0027--database_connection\u0027, metavar\u003d\u0027\u003cdatabase_connection\u003e\u0027,"},{"line_number":1604,"context_line":"          dest\u003d\u0027db_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b7085727","line":1601,"in_reply_to":"3f79a3b5_dcc65a16","updated":"2018-09-26 13:23:24.000000000","message":"Done","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b00d121aa651000554b1a97949156b1d8ce49d5a","unresolved":false,"context_lines":[{"line_number":1641,"context_line":"        if name:"},{"line_number":1642,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"        if not cell_mapping.is_cell0():"},{"line_number":1645,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1646,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1647,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fc4b16ae","line":1644,"updated":"2018-09-26 13:16:16.000000000","message":"Please add a comment here about why cell0 is special and we don\u0027t update the transport_url from config.","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"8e1d4a1bf2e72575688982706349ee9ab474d81c","unresolved":false,"context_lines":[{"line_number":1641,"context_line":"        if name:"},{"line_number":1642,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"        if not cell_mapping.is_cell0():"},{"line_number":1645,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1646,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1647,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_570f832e","line":1644,"in_reply_to":"3f79a3b5_fc4b16ae","updated":"2018-09-26 13:23:24.000000000","message":"Done","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9b63741b0541b8b98301fd59af4130d8c964cd4d","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"        if not cell_mapping.is_cell0():"},{"line_number":1677,"context_line":"            # The transport_url option is not applicable to cell0"},{"line_number":1678,"context_line":"            # as it does not have a MQ."},{"line_number":1679,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1680,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"        if (self._non_unique_transport_url_database_connection_checker(ctxt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb9cba7_78ee8389","line":1679,"updated":"2019-04-22 09:32:16.000000000","message":"A warning should be output if \u0027--transport-url\u0027 is specified for cell0.","commit_id":"cd10d503e32ec2647ab9241fbe18d74ac6bf10d6"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2d01e73391674e27302273664dc08cae6a7a0c92","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"        if not cell_mapping.is_cell0():"},{"line_number":1677,"context_line":"            # The transport_url option is not applicable to cell0"},{"line_number":1678,"context_line":"            # as it does not have a MQ."},{"line_number":1679,"context_line":"            transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1680,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"        if (self._non_unique_transport_url_database_connection_checker(ctxt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_c503f70c","line":1679,"in_reply_to":"ffb9cba7_78ee8389","updated":"2019-05-04 17:11:04.000000000","message":"I am not sure what you mean by \"a warning should be emitted if its specified for cell0\". Because by default in nova.conf we have cell_db set to cell0 while the transport url is the global one :) so even if a person doesn\u0027t specify one, we are still doing that by default. Honestly I don\u0027t think we should trouble an operator who is updating a cell with these details. For instance we sometimes have downstream people who just follow the documentation into doing this stuff without actually knowing what a \"cell0\" is. Plus the whole point as I have mentioned in my commit message is to NOT have to specify an transport-url for cell0.","commit_id":"cd10d503e32ec2647ab9241fbe18d74ac6bf10d6"}],"nova/tests/unit/test_nova_manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b00d121aa651000554b1a97949156b1d8ce49d5a","unresolved":false,"context_lines":[{"line_number":2261,"context_line":"        self.assertEqual(\u0027none:///\u0027, cell_mapping.transport_url)"},{"line_number":2262,"context_line":"        self.assertEqual(\u0027fake://netloc/nova_cell0\u0027,"},{"line_number":2263,"context_line":"                         cell_mapping.database_connection)"},{"line_number":2264,"context_line":"        self.commands.update_cell(objects.CellMapping.CELL0_UUID,"},{"line_number":2265,"context_line":"                                  db_connection\u003d\u0027fake://db0\u0027)"},{"line_number":2266,"context_line":"        cell_mapping \u003d objects.CellMapping.get_by_uuid(ctxt,"},{"line_number":2267,"context_line":"            objects.CellMapping.CELL0_UUID)"},{"line_number":2268,"context_line":"        # check that transport_url does not get updated."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3c00ae35","line":2265,"range":{"start_line":2264,"start_character":8,"end_line":2265,"end_character":61},"updated":"2018-09-26 13:16:16.000000000","message":"Shouldn\u0027t you ensure the transport_url is configured before calling this? Otherwise how do we know it was ignored?","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"8e1d4a1bf2e72575688982706349ee9ab474d81c","unresolved":false,"context_lines":[{"line_number":2261,"context_line":"        self.assertEqual(\u0027none:///\u0027, cell_mapping.transport_url)"},{"line_number":2262,"context_line":"        self.assertEqual(\u0027fake://netloc/nova_cell0\u0027,"},{"line_number":2263,"context_line":"                         cell_mapping.database_connection)"},{"line_number":2264,"context_line":"        self.commands.update_cell(objects.CellMapping.CELL0_UUID,"},{"line_number":2265,"context_line":"                                  db_connection\u003d\u0027fake://db0\u0027)"},{"line_number":2266,"context_line":"        cell_mapping \u003d objects.CellMapping.get_by_uuid(ctxt,"},{"line_number":2267,"context_line":"            objects.CellMapping.CELL0_UUID)"},{"line_number":2268,"context_line":"        # check that transport_url does not get updated."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1cfff202","line":2265,"range":{"start_line":2264,"start_character":8,"end_line":2265,"end_character":61},"in_reply_to":"3f79a3b5_3c00ae35","updated":"2018-09-26 13:23:24.000000000","message":"you are right, dammit forgot to do that piece.","commit_id":"84eebd140a94c649957c6fdb3323b9a79656e8a7"}]}