)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"hide server address code has been merged in this"},{"line_number":10,"context_line":"- https://review.openstack.org/#/c/603831/ but"},{"line_number":11,"context_line":"unit tests has not been merged."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit add those hide server address tests in"},{"line_number":14,"context_line":"test_serversV21.py file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b2138565","line":11,"updated":"2018-09-26 15:06:04.000000000","message":"Huh, I could have sworn I changed something in test_serversV21.py but apparently didn\u0027t commit it or something.","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            uuid\u003duuid, vm_state\u003dvm_states.BUILDING)"},{"line_number":597,"context_line":"        req \u003d self.req(\u0027/v2/fake/servers/%s\u0027 % uuid)"},{"line_number":598,"context_line":"        res_dict \u003d self.controller.show(req, uuid)"},{"line_number":599,"context_line":"        self.assertFalse(res_dict[\u0027server\u0027][\u0027addresses\u0027])"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def test_show_server_addresses_in_non_building(self):"},{"line_number":602,"context_line":"        uuid \u003d FAKE_UUID"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a86f98c2","line":599,"range":{"start_line":599,"start_character":13,"end_line":599,"end_character":24},"updated":"2018-09-26 15:06:04.000000000","message":"This is not great - can we assert the actual response value is what we expect? Would it be None or []? In fact I thought we had a hacking check against using assertTrue/assertFalse but it might be for something more specific.","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf30d8c24f213df6194b770e7062564abeea75f4","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            uuid\u003duuid, vm_state\u003dvm_states.BUILDING)"},{"line_number":597,"context_line":"        req \u003d self.req(\u0027/v2/fake/servers/%s\u0027 % uuid)"},{"line_number":598,"context_line":"        res_dict \u003d self.controller.show(req, uuid)"},{"line_number":599,"context_line":"        self.assertFalse(res_dict[\u0027server\u0027][\u0027addresses\u0027])"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def test_show_server_addresses_in_non_building(self):"},{"line_number":602,"context_line":"        uuid \u003d FAKE_UUID"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_43a31744","line":599,"range":{"start_line":599,"start_character":13,"end_line":599,"end_character":24},"in_reply_to":"3f79a3b5_a86f98c2","updated":"2018-09-28 10:55:37.000000000","message":"yeah, done","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            uuid\u003duuid, vm_state\u003dvm_states.ACTIVE)"},{"line_number":605,"context_line":"        req \u003d self.req(\u0027/v2/fake/servers/%s\u0027 % uuid)"},{"line_number":606,"context_line":"        res_dict \u003d self.controller.show(req, uuid)"},{"line_number":607,"context_line":"        self.assertTrue(res_dict[\u0027server\u0027][\u0027addresses\u0027])"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_detail_server_hide_addresses(self):"},{"line_number":610,"context_line":"        def fake_get_all(context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_08600ccf","line":607,"range":{"start_line":607,"start_character":13,"end_line":607,"end_character":23},"updated":"2018-09-26 15:06:04.000000000","message":"same","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res_dict \u003d self.controller.show(req, uuid)"},{"line_number":607,"context_line":"        self.assertTrue(res_dict[\u0027server\u0027][\u0027addresses\u0027])"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_detail_server_hide_addresses(self):"},{"line_number":610,"context_line":"        def fake_get_all(context, **kwargs):"},{"line_number":611,"context_line":"            return objects.InstanceList("},{"line_number":612,"context_line":"                objects\u003d[fakes.stub_instance_obj(100, uuid\u003duuids.fake)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_68d4204c","line":609,"updated":"2018-09-26 15:06:04.000000000","message":"This test is confusing - can you at least add a comment about what it\u0027s doing? In other words, I\u0027d have to lookup stub_instance_obj to know what it\u0027s returning and why server[\u0027id\u0027] \u003d\u003d 1 means anything special, I\u0027m assuming that one is in \u0027building\u0027 state? The test is pretty tightly coupled to some stubs outside of the test which makes it brittle. I would say the now deleted test_detail_hides_building_server_addresses was actually easier to read because it explicitly created two servers and one is clearly in the building state so we can see why it doesn\u0027t have addresses while the other server (which is active) does.","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bf30d8c24f213df6194b770e7062564abeea75f4","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res_dict \u003d self.controller.show(req, uuid)"},{"line_number":607,"context_line":"        self.assertTrue(res_dict[\u0027server\u0027][\u0027addresses\u0027])"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_detail_server_hide_addresses(self):"},{"line_number":610,"context_line":"        def fake_get_all(context, **kwargs):"},{"line_number":611,"context_line":"            return objects.InstanceList("},{"line_number":612,"context_line":"                objects\u003d[fakes.stub_instance_obj(100, uuid\u003duuids.fake)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e316e358","line":609,"in_reply_to":"3f79a3b5_68d4204c","updated":"2018-09-28 10:55:37.000000000","message":"ah yeah, this is not correct test. i remember i changed L612 to return 2 servers with building and active state and check the address field. But that seem missed while checkin.\n\nnow L620 block is never get executed and only else block always because stub_instance_obj make vm_state as active by default. \n\ni will fix it.","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        servers \u003d self.controller.detail(req)[\u0027servers\u0027]"},{"line_number":619,"context_line":"        for server in servers:"},{"line_number":620,"context_line":"            if server[\u0027id\u0027] \u003d\u003d 1:"},{"line_number":621,"context_line":"                self.assertFalse(server[\u0027addresses\u0027])"},{"line_number":622,"context_line":"            else:"},{"line_number":623,"context_line":"                self.assertTrue(server[\u0027addresses\u0027])"},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c880d44c","line":621,"range":{"start_line":621,"start_character":21,"end_line":621,"end_character":32},"updated":"2018-09-26 15:06:04.000000000","message":"same","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78e59e39de3692970b652359de54567246307032","unresolved":false,"context_lines":[{"line_number":620,"context_line":"            if server[\u0027id\u0027] \u003d\u003d 1:"},{"line_number":621,"context_line":"                self.assertFalse(server[\u0027addresses\u0027])"},{"line_number":622,"context_line":"            else:"},{"line_number":623,"context_line":"                self.assertTrue(server[\u0027addresses\u0027])"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_get_server_list_empty(self):"},{"line_number":626,"context_line":"        self.mock_get_all.side_effect \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e8835054","line":623,"range":{"start_line":623,"start_character":21,"end_line":623,"end_character":31},"updated":"2018-09-26 15:06:04.000000000","message":"same","commit_id":"e28f9a344ed1cc04899b7c9d608df3d022198a7a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"274fe4127a047832e7845658b34f8e0013d1b425","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                                                 nw_cache\u003dnw_cache),"},{"line_number":675,"context_line":"                         fakes.stub_instance_obj(2,"},{"line_number":676,"context_line":"                                                 vm_state\u003dvm_states.ACTIVE,"},{"line_number":677,"context_line":"                                                 uuid\u003duuids.fake,"},{"line_number":678,"context_line":"                                                 nw_cache\u003dnw_cache)])"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        self.mock_get_all.side_effect \u003d fake_get_all"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ced08bf7","line":677,"updated":"2018-09-30 15:25:29.000000000","message":"nit: should use a unique uuid for the two servers","commit_id":"d33337bd03dd6971005ff05d2bcafb49c58fd1e0"}]}