)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2e0e9b4804b37403f3d4d5cf55ef3e8fe86a18bf","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    # $count limit provided), and a nonzero found value may tell the user"},{"line_number":381,"context_line":"    # that there is still work to do. The done value indicates whether"},{"line_number":382,"context_line":"    # or not any records were actually migrated by the function. Thus"},{"line_number":383,"context_line":"    # if both (found, done) are nonzero, work was done and some work"},{"line_number":384,"context_line":"    # remains. If found is nonzero and done is zero, some records are"},{"line_number":385,"context_line":"    # not migratable (or don\u0027t need migrating), but all migrations that can"},{"line_number":386,"context_line":"    # complete have finished."},{"line_number":387,"context_line":"    online_migrations \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6207dfca","line":384,"range":{"start_line":383,"start_character":55,"end_line":384,"end_character":13},"updated":"2018-10-02 18:44:36.000000000","message":"Even if found \u003d\u003d done \u003c batch_size? Or do we not consider our work \"done\" until done \u003d\u003d 0, even though that means we didn\u0027t actually do anything on the last iteration?","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"37b7369753ea426f6d2c258fe88a6c2e9948947e","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    # $count limit provided), and a nonzero found value may tell the user"},{"line_number":381,"context_line":"    # that there is still work to do. The done value indicates whether"},{"line_number":382,"context_line":"    # or not any records were actually migrated by the function. Thus"},{"line_number":383,"context_line":"    # if both (found, done) are nonzero, work was done and some work"},{"line_number":384,"context_line":"    # remains. If found is nonzero and done is zero, some records are"},{"line_number":385,"context_line":"    # not migratable (or don\u0027t need migrating), but all migrations that can"},{"line_number":386,"context_line":"    # complete have finished."},{"line_number":387,"context_line":"    online_migrations \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ae250fc2","line":384,"range":{"start_line":383,"start_character":55,"end_line":384,"end_character":13},"in_reply_to":"3f79a3b5_6207dfca","updated":"2018-10-24 20:09:06.000000000","message":"\u003e Or do we not consider our work \"done\" until done \u003d\u003d 0, even though that means we didn\u0027t actually do anything on the last iteration?\n\nThis.","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2e0e9b4804b37403f3d4d5cf55ef3e8fe86a18bf","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            except Exception:"},{"line_number":679,"context_line":"                print(_(\"Error attempting to run %(method)s\") % dict("},{"line_number":680,"context_line":"                      method\u003dmigration_meth))"},{"line_number":681,"context_line":"                found \u003d done \u003d 0"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            name \u003d migration_meth.__name__"},{"line_number":684,"context_line":"            if found:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_023ceb8f","line":681,"range":{"start_line":681,"start_character":16,"end_line":681,"end_character":32},"updated":"2018-10-02 18:44:36.000000000","message":"aside: Wouldn\u0027t we want this to result in a nonzero exit code?","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"37b7369753ea426f6d2c258fe88a6c2e9948947e","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            except Exception:"},{"line_number":679,"context_line":"                print(_(\"Error attempting to run %(method)s\") % dict("},{"line_number":680,"context_line":"                      method\u003dmigration_meth))"},{"line_number":681,"context_line":"                found \u003d done \u003d 0"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            name \u003d migration_meth.__name__"},{"line_number":684,"context_line":"            if found:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8e1a9379","line":681,"range":{"start_line":681,"start_character":16,"end_line":681,"end_character":32},"in_reply_to":"3f79a3b5_023ceb8f","updated":"2018-10-24 20:09:06.000000000","message":"Dealt with in https://review.openstack.org/#/c/611701/","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2e0e9b4804b37403f3d4d5cf55ef3e8fe86a18bf","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                                       \u0027meth\u0027: name,"},{"line_number":688,"context_line":"                                       \u0027done\u0027: done})"},{"line_number":689,"context_line":"            # This is the per-migration method result for this batch, and"},{"line_number":690,"context_line":"            # _run_migration will either continue or stop if up to this point"},{"line_number":691,"context_line":"            # we\u0027ve processed max_count of records across all migration"},{"line_number":692,"context_line":"            # methods."},{"line_number":693,"context_line":"            migrations[name] \u003d found, done"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6286ff67","line":690,"range":{"start_line":690,"start_character":41,"end_line":690,"end_character":77},"updated":"2018-10-02 18:44:36.000000000","message":"This could use some punctuation or rewording. Perhaps:\n\n...will either continue on to the next migration, or stop if up to this point...","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"37b7369753ea426f6d2c258fe88a6c2e9948947e","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                                       \u0027meth\u0027: name,"},{"line_number":688,"context_line":"                                       \u0027done\u0027: done})"},{"line_number":689,"context_line":"            # This is the per-migration method result for this batch, and"},{"line_number":690,"context_line":"            # _run_migration will either continue or stop if up to this point"},{"line_number":691,"context_line":"            # we\u0027ve processed max_count of records across all migration"},{"line_number":692,"context_line":"            # methods."},{"line_number":693,"context_line":"            migrations[name] \u003d found, done"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4e10fb58","line":690,"range":{"start_line":690,"start_character":41,"end_line":690,"end_character":77},"in_reply_to":"3f79a3b5_6286ff67","updated":"2018-10-24 20:09:06.000000000","message":"Will update, thanks.","commit_id":"c0163e0ab9d129a91ab3a8214ade281879ab42a2"}]}