)]}'
{"nova/api/openstack/placement/db_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ca00a2aa4a04b2c61760d5402d4eca1159594c7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_placement_engine():"},{"line_number":39,"context_line":"    return placement_context_manager.get_legacy_facade().get_engine()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"@enginefacade.transaction_context_provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_352f1f8a","line":39,"range":{"start_line":39,"start_character":37,"end_line":39,"end_character":54},"updated":"2018-09-28 22:38:28.000000000","message":".","commit_id":"020651ad3d14066af34dc5d1d96cec7c6ffe5cd9"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"325152608d01fefbb56430a72fae84205b37cc09","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    ctxt_mgr \u003d get_context_manager(context)"},{"line_number":137,"context_line":"    if use_slave:"},{"line_number":138,"context_line":"        return ctxt_mgr.reader.get_engine()"},{"line_number":139,"context_line":"    return ctxt_mgr.writer.get_engine()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def get_api_engine():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1af33275","line":139,"updated":"2018-09-28 22:15:07.000000000","message":"For reviewers: please see this oslo.db code to see how the use of \u0027reader\u0027 and \u0027writer\u0027 here are analogues to the old get_legacy_facade().get_engine(use_slave\u003d...) calls:\n\nhttps://github.com/openstack/oslo.db/blob/e64c6bb/oslo_db/sqlalchemy/enginefacade.py#L1279-L1293","commit_id":"020651ad3d14066af34dc5d1d96cec7c6ffe5cd9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ca00a2aa4a04b2c61760d5402d4eca1159594c7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    ctxt_mgr \u003d get_context_manager(context)"},{"line_number":137,"context_line":"    if use_slave:"},{"line_number":138,"context_line":"        return ctxt_mgr.reader.get_engine()"},{"line_number":139,"context_line":"    return ctxt_mgr.writer.get_engine()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def get_api_engine():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_950dd336","line":139,"in_reply_to":"3f79a3b5_1af33275","updated":"2018-09-28 22:38:28.000000000","message":"Thanks for that.","commit_id":"020651ad3d14066af34dc5d1d96cec7c6ffe5cd9"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ba55f369d2040a2324bd21c43eb64def8e040adb","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def get_api_engine():"},{"line_number":143,"context_line":"    return api_context_manager.writer.get_engine()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"_SHADOW_TABLE_PREFIX \u003d \u0027shadow_\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3d0b652b","line":143,"updated":"2018-10-01 17:11:17.000000000","message":"Looks like this is the only change that would be needed in placement/db_api.py (there\u0027s no slave handling)","commit_id":"020651ad3d14066af34dc5d1d96cec7c6ffe5cd9"}]}
