)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"caf0307e30cf02ae9151b720cc502c6ab605fc16","unresolved":false,"context_lines":[{"line_number":12,"context_line":"archive_deleted_rows`` offers a ``max-rows`` parameter which actually"},{"line_number":13,"context_line":"means the batch size of the iteration for moving the soft-deleted"},{"line_number":14,"context_line":"records from table to their shadow-tables. So this patch clarifies"},{"line_number":15,"context_line":"that the batch size does not incldue the API table records that are"},{"line_number":16,"context_line":"purged so that the users are not confused by the ``--verbose`` output"},{"line_number":17,"context_line":"of the command giving more rows than specified."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I652854c7192b996a33ed343a51a0fd8c7620e876"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_5a78a729","line":16,"range":{"start_line":15,"start_character":9,"end_line":16,"end_character":6},"updated":"2018-10-01 16:13:08.000000000","message":"Ideally it would be nice to include this into the max-rows number specified maybe ? But I cannot see how this can be done for instance_group_member table without doing an upcall from sqlalchemy/api.py . As for instance_mappings and request_specs, we could use the concept of the 1:1:1 instance:mapping:spec and just query for max-rows/3 records of deleted instances assuming we would archive 3 times that.","commit_id":"13f3d745989af30ce640a95b4f1fe289f6b0d08e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ee45cf80f4f448f1a5d420016ff31c8be866299","unresolved":false,"context_lines":[{"line_number":12,"context_line":"archive_deleted_rows`` offers a ``max-rows`` parameter which actually"},{"line_number":13,"context_line":"means the batch size of the iteration for moving the soft-deleted"},{"line_number":14,"context_line":"records from table to their shadow-tables. So this patch clarifies"},{"line_number":15,"context_line":"that the batch size does not incldue the API table records that are"},{"line_number":16,"context_line":"purged so that the users are not confused by the ``--verbose`` output"},{"line_number":17,"context_line":"of the command giving more rows than specified."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_9a657b47","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":36},"updated":"2019-03-01 13:57:36.000000000","message":"include","commit_id":"3f7f6250386f53dd3bf57511c9260278592cb8f1"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ee45cf80f4f448f1a5d420016ff31c8be866299","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    of the archive operation for any tables that were changed. Specifying"},{"line_number":68,"context_line":"    ``--until-complete`` will make the command run continuously until all"},{"line_number":69,"context_line":"    deleted rows are archived. Use the ``--max_rows`` option, which defaults to"},{"line_number":70,"context_line":"    1000, as a batch size for each iteration (Note that the purged API database"},{"line_number":71,"context_line":"    table records are not included in this batch size). Specifying ``--purge``"},{"line_number":72,"context_line":"    will cause a `full` DB purge to be completed after archival. If a date"},{"line_number":73,"context_line":"    range is desired for the purge, then run ``nova-manage db purge --before"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_fada87e6","line":70,"range":{"start_line":70,"start_character":46,"end_line":70,"end_character":50},"updated":"2019-03-01 13:57:36.000000000","message":"note","commit_id":"3f7f6250386f53dd3bf57511c9260278592cb8f1"}],"nova/cmd/manage.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ef8d575c31da281e20e216c95eee78215835d0cb","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    @args(\u0027--max_rows\u0027, type\u003dint, metavar\u003d\u0027\u003cnumber\u003e\u0027, dest\u003d\u0027max_rows\u0027,"},{"line_number":497,"context_line":"          help\u003d\u0027Maximum number of deleted rows to archive. Defaults to 1000. \u0027"},{"line_number":498,"context_line":"               \u0027Note that this number does not include the corresponding rows \u0027"},{"line_number":499,"context_line":"               \u0027that are removed if any from the API database of the deleted \u0027"},{"line_number":500,"context_line":"               \u0027instances.\u0027)"},{"line_number":501,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":502,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":503,"context_line":"    @args(\u0027--until-complete\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027until_complete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6dafb67b","line":500,"range":{"start_line":499,"start_character":33,"end_line":500,"end_character":25},"updated":"2018-10-03 19:44:06.000000000","message":"Is there a typo in this? I can\u0027t understand what this part of the sentence is saying. Is it supposed to be something like, \"does not include the corresponding rows, if any, that are removed from the API database for deleted instances\"?","commit_id":"13f3d745989af30ce640a95b4f1fe289f6b0d08e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"a07a017d43dc717ac39a5ea8484409d3767c07b3","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    @args(\u0027--max_rows\u0027, type\u003dint, metavar\u003d\u0027\u003cnumber\u003e\u0027, dest\u003d\u0027max_rows\u0027,"},{"line_number":497,"context_line":"          help\u003d\u0027Maximum number of deleted rows to archive. Defaults to 1000. \u0027"},{"line_number":498,"context_line":"               \u0027Note that this number does not include the corresponding rows \u0027"},{"line_number":499,"context_line":"               \u0027that are removed if any from the API database of the deleted \u0027"},{"line_number":500,"context_line":"               \u0027instances.\u0027)"},{"line_number":501,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":502,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":503,"context_line":"    @args(\u0027--until-complete\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027until_complete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3cb003fd","line":500,"range":{"start_line":499,"start_character":33,"end_line":500,"end_character":25},"in_reply_to":"3f79a3b5_31fa6c76","updated":"2018-10-04 08:44:15.000000000","message":"Done","commit_id":"13f3d745989af30ce640a95b4f1fe289f6b0d08e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"568ffe4f6594735018ac6415d7ebf8c6efd72e97","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    @args(\u0027--max_rows\u0027, type\u003dint, metavar\u003d\u0027\u003cnumber\u003e\u0027, dest\u003d\u0027max_rows\u0027,"},{"line_number":497,"context_line":"          help\u003d\u0027Maximum number of deleted rows to archive. Defaults to 1000. \u0027"},{"line_number":498,"context_line":"               \u0027Note that this number does not include the corresponding rows \u0027"},{"line_number":499,"context_line":"               \u0027that are removed if any from the API database of the deleted \u0027"},{"line_number":500,"context_line":"               \u0027instances.\u0027)"},{"line_number":501,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":502,"context_line":"          help\u003d\u0027Print how many rows were archived per table.\u0027)"},{"line_number":503,"context_line":"    @args(\u0027--until-complete\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027until_complete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_31fa6c76","line":500,"range":{"start_line":499,"start_character":33,"end_line":500,"end_character":25},"in_reply_to":"3f79a3b5_6dafb67b","updated":"2018-10-04 08:06:42.000000000","message":"you are right, that is exactly what I meant. Will patch this up.","commit_id":"13f3d745989af30ce640a95b4f1fe289f6b0d08e"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"90bd120a891839e54c731eccfec012a7f78ea5a5","unresolved":false,"context_lines":[{"line_number":5544,"context_line":"                from_select(columns, sql.select([table], column.in_(records)))"},{"line_number":5545,"context_line":"        delete \u003d table.delete().where(column.in_(records))"},{"line_number":5546,"context_line":"        # NOTE(tssurya): In order to facilitate the deletion of records from"},{"line_number":5547,"context_line":"        # instance_mappings, request_specs and instance_group_member tables in"},{"line_number":5548,"context_line":"        # the nova_api DB, the rows of deleted instances from the instances"},{"line_number":5549,"context_line":"        # table are stored prior to their deletion. Basically the uuids of the"},{"line_number":5550,"context_line":"        # archived instances are queried and returned."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f1f94d7f","line":5547,"range":{"start_line":5547,"start_character":47,"end_line":5547,"end_character":68},"updated":"2019-03-01 15:09:08.000000000","message":"I would have thought this table name was \u0027instance_group_members\u0027, but I just double-checked and indeed, it is not.","commit_id":"17b8e23e754ddc0f64b2a4021ea952fa54485365"}]}