)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a1c16f9e77a6bcf373d68a8ee3d701910cf9f481","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add check for report interval, if report interval is larger"},{"line_number":10,"context_line":"than service down time, the service will not be able to start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes bug #1255685"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1be42e1826142b8f3f2c39f3734bef713a12a693"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9mNs%3D","line":11,"updated":"2013-12-09 20:30:56.000000000","message":"Add the UpgradeImpact tag here, I got the idea from Duncan in the Cinder review: https://review.openstack.org/#/c/60760/","commit_id":"3397c63ea5389fc077195675b02fe089b6a8a345"}],"nova/service.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7035ba1adf75faa485d9588084edc7f70f955f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.port \u003d self.server.port"},{"line_number":322,"context_line":"        self.backdoor_port \u003d None"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def basic_config_check(self):"},{"line_number":325,"context_line":"        \"\"\"Perform basic config checks before starting service.\"\"\""},{"line_number":326,"context_line":"        # Make sure report interval is less than service down time"},{"line_number":327,"context_line":"        report_interval \u003d CONF.report_interval"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9VHU%3D","line":324,"updated":"2013-12-12 15:49:33.000000000","message":"Why isn\u0027t this checked in Service.basic_config_check defined on line 283 instead?","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1124ef03c365a4b8d06a2c72e7a67fda99e724c6","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.port \u003d self.server.port"},{"line_number":322,"context_line":"        self.backdoor_port \u003d None"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def basic_config_check(self):"},{"line_number":325,"context_line":"        \"\"\"Perform basic config checks before starting service.\"\"\""},{"line_number":326,"context_line":"        # Make sure report interval is less than service down time"},{"line_number":327,"context_line":"        report_interval \u003d CONF.report_interval"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2Byw%3D","line":324,"in_reply_to":"AAAATn%2F9VDk%3D","updated":"2014-01-05 11:25:19.000000000","message":"When the service group driver is memcache, service_down_time is used by each service, not only wsgi service.\n\nhttps://github.com/openstack/nova/blob/master/nova/servicegroup/drivers/mc.py#L96\n\nActually I prefer just print a warn message is enough for this case... but cinder side patch already merged...\n\nAnd maybe we can move this check into servicegroup?","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ee5727bf07cacee0425cc8dc2ae32bf15de3e4b9","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.port \u003d self.server.port"},{"line_number":322,"context_line":"        self.backdoor_port \u003d None"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def basic_config_check(self):"},{"line_number":325,"context_line":"        \"\"\"Perform basic config checks before starting service.\"\"\""},{"line_number":326,"context_line":"        # Make sure report interval is less than service down time"},{"line_number":327,"context_line":"        report_interval \u003d CONF.report_interval"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9VDk%3D","line":324,"in_reply_to":"AAAATn%2F9VHU%3D","updated":"2013-12-12 16:01:59.000000000","message":"\u0027service_down_time\u0027 is only used by the wsgi service, no effect at all if it checked on line 283.","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c78e20d92ff4ee836cc68df3d643aaba2bbc926e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        self.port \u003d self.server.port"},{"line_number":322,"context_line":"        self.backdoor_port \u003d None"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def basic_config_check(self):"},{"line_number":325,"context_line":"        \"\"\"Perform basic config checks before starting service.\"\"\""},{"line_number":326,"context_line":"        # Make sure report interval is less than service down time"},{"line_number":327,"context_line":"        report_interval \u003d CONF.report_interval"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2BCQ%3D","line":324,"in_reply_to":"AAAAUH%2F%2F%2Byw%3D","updated":"2014-01-06 03:13:21.000000000","message":"Thanks, Done","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1124ef03c365a4b8d06a2c72e7a67fda99e724c6","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                       \"%(new_service_down_time)s\") %"},{"line_number":335,"context_line":"                     {\u0027service_down_time\u0027: CONF.service_down_time,"},{"line_number":336,"context_line":"                      \u0027report_interval\u0027: report_interval,"},{"line_number":337,"context_line":"                      \u0027new_service_down_time\u0027: new_service_down_time})"},{"line_number":338,"context_line":"            CONF.set_override(\u0027service_down_time\u0027, new_service_down_time)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _get_manager(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2B10%3D","line":337,"updated":"2014-01-05 11:25:19.000000000","message":"we should use LOG.warn(\u0027....\u0027, {...}) instead of LOG.warn(\u0027...\u0027 % {...})","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c78e20d92ff4ee836cc68df3d643aaba2bbc926e","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                       \"%(new_service_down_time)s\") %"},{"line_number":335,"context_line":"                     {\u0027service_down_time\u0027: CONF.service_down_time,"},{"line_number":336,"context_line":"                      \u0027report_interval\u0027: report_interval,"},{"line_number":337,"context_line":"                      \u0027new_service_down_time\u0027: new_service_down_time})"},{"line_number":338,"context_line":"            CONF.set_override(\u0027service_down_time\u0027, new_service_down_time)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _get_manager(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2BCc%3D","line":337,"in_reply_to":"AAAAUH%2F%2F%2B10%3D","updated":"2014-01-06 03:13:21.000000000","message":"Done","commit_id":"a61f91d7999aa7d130a25f6639cd674e8671a1d5"}]}