)]}'
{"Authors":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bcf65b0af9a4035e8cece3d369ce03205689950e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Loganathan Parthipan \u003cparthipan@hp.com\u003e"},{"line_number":122,"context_line":"Lorin Hochstein \u003clorin@nimbisservices.com\u003e"},{"line_number":123,"context_line":"Lvov Maxim \u003cusrleon@gmail.com\u003e"},{"line_number":124,"context_line":"Mandar Vaze\u003cmandar.vaze@vertex.co.in\u003e"},{"line_number":125,"context_line":"Mandell Degerness \u003cmdegerne@gmail.com\u003e"},{"line_number":126,"context_line":"Mark McClain \u003cmark.mcclain@dreamhost.com\u003e"},{"line_number":127,"context_line":"Mark McLoughlin \u003cmarkmc@redhat.com\u003e"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAFX%2F%2F%2FM8%3D","line":124,"updated":"2012-04-09 14:31:36.000000000","message":"Dunno if it\u0027s important for our test suite (which checks Authors), but you probably need to have a space between your name and your email address.","commit_id":"d399797fa678b0b819296c467067fdc7c6984dcd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7883126645e029c99f01fa0d5a75857af73cd6c4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"Lvov Maxim \u003cusrleon@gmail.com\u003e"},{"line_number":127,"context_line":"Mandar Vaze \u003cmandar.vaze@vertex.co.in\u003e"},{"line_number":128,"context_line":"Mandell Degerness \u003cmdegerne@gmail.com\u003e"},{"line_number":129,"context_line":"Mandar Vaze \u003cmandar.vaze@vertex.co.in\u003e"},{"line_number":130,"context_line":"Mark McClain \u003cmark.mcclain@dreamhost.com\u003e"},{"line_number":131,"context_line":"Mark McLoughlin \u003cmarkmc@redhat.com\u003e"},{"line_number":132,"context_line":"Mark Washenberger \u003cmark.washenberger@rackspace.com\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAFn%2F%2F%2F3o%3D","line":129,"updated":"2012-04-17 06:04:38.000000000","message":"Hmmm…you\u0027re already listed.  Your addition is correct, in that it is in the right place alphabetically, but this one is a little out of order :)  Failed conflict resolution?","commit_id":"9bd82c7e85b5b5b966667cd558f8be0fae239823"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"798baef175d359a9623f20852004d789ce1ec3f1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"Lvov Maxim \u003cusrleon@gmail.com\u003e"},{"line_number":127,"context_line":"Mandar Vaze \u003cmandar.vaze@vertex.co.in\u003e"},{"line_number":128,"context_line":"Mandell Degerness \u003cmdegerne@gmail.com\u003e"},{"line_number":129,"context_line":"Mandar Vaze \u003cmandar.vaze@vertex.co.in\u003e"},{"line_number":130,"context_line":"Mark McClain \u003cmark.mcclain@dreamhost.com\u003e"},{"line_number":131,"context_line":"Mark McLoughlin \u003cmarkmc@redhat.com\u003e"},{"line_number":132,"context_line":"Mark Washenberger \u003cmark.washenberger@rackspace.com\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAGn%2F%2F%2FWs%3D","line":129,"in_reply_to":"AAAAFn%2F%2F%2F3o%3D","updated":"2012-04-18 08:05:50.000000000","message":"Duplicate entry removed (See next patchset)","commit_id":"9bd82c7e85b5b5b966667cd558f8be0fae239823"}],"bin/nova-manage":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bcf65b0af9a4035e8cece3d369ce03205689950e","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        # check for certain required inputs"},{"line_number":741,"context_line":"        if not label:"},{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        #Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            print _(\"ERROR: Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            return"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAFX%2F%2F%2FM4%3D","line":743,"updated":"2012-04-09 14:31:36.000000000","message":"style femtonit: I\u0027d prefer a space between the \u0027#\u0027 and \u0027Size\u0027; this would match the style of the rest of the comments here.","commit_id":"d399797fa678b0b819296c467067fdc7c6984dcd"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"630668757d1fffb27a9363be6d7f9676329445cb","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        # check for certain required inputs"},{"line_number":741,"context_line":"        if not label:"},{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        #Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            print _(\"ERROR: Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            return"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAFn%2F%2F%2F6Y%3D","line":743,"in_reply_to":"AAAAFX%2F%2F%2FM4%3D","updated":"2012-04-12 09:33:28.000000000","message":"Done","commit_id":"d399797fa678b0b819296c467067fdc7c6984dcd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bcf65b0af9a4035e8cece3d369ce03205689950e","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        #Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            print _(\"ERROR: Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            return"},{"line_number":747,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"},{"line_number":748,"context_line":"            req \u003d \u0027--fixed_range_v4 or --fixed_range_v6\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAFX%2F%2F%2FMw%3D","line":745,"updated":"2012-04-09 14:31:36.000000000","message":"Why use a print here when all the other error conditions treated here are raised as exceptions?","commit_id":"d399797fa678b0b819296c467067fdc7c6984dcd"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"630668757d1fffb27a9363be6d7f9676329445cb","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        #Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            print _(\"ERROR: Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            return"},{"line_number":747,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"},{"line_number":748,"context_line":"            req \u003d \u0027--fixed_range_v4 or --fixed_range_v6\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAFn%2F%2F%2F6U%3D","line":745,"in_reply_to":"AAAAFX%2F%2F%2FMw%3D","updated":"2012-04-12 09:33:28.000000000","message":"Done","commit_id":"d399797fa678b0b819296c467067fdc7c6984dcd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7883126645e029c99f01fa0d5a75857af73cd6c4","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        # Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            raise Exception(\"Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"},{"line_number":747,"context_line":"            req \u003d \u0027--fixed_range_v4 or --fixed_range_v6\u0027"},{"line_number":748,"context_line":"            raise exception.NetworkNotCreated(req\u003dreq)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAFn%2F%2F%2F3g%3D","line":745,"updated":"2012-04-17 06:04:38.000000000","message":"Eh.  Sorry to nitpick, but I think we want something more specific than Exception.  What does NetworkNotCreated do with its arguments; is there some way of expressing this failure using that (since it\u0027s used elsewhere in this function)?  Is there another exception in exception.py that could be used for this purpose?  What does the API do if it sees a long length; can that action be transposed here?","commit_id":"9bd82c7e85b5b5b966667cd558f8be0fae239823"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"798baef175d359a9623f20852004d789ce1ec3f1","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        # Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            raise Exception(\"Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"},{"line_number":747,"context_line":"            req \u003d \u0027--fixed_range_v4 or --fixed_range_v6\u0027"},{"line_number":748,"context_line":"            raise exception.NetworkNotCreated(req\u003dreq)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAGn%2F%2F%2FWw%3D","line":745,"in_reply_to":"AAAAFn%2F%2F%2F3g%3D","updated":"2012-04-18 08:05:50.000000000","message":"\u003e What does NetworkNotCreated do with its arguments; \n\u003e is there some way of expressing this failure using that \n\u003e (since it\u0027s used elsewhere in this function)?\n\nIt is coded such that it can be used ONLY for mandatory parameters. So it can\u0027 be used as is.\n\n\u003e Is there another exception in exception.py that could be\n\u003e used for this purpose?\n\nUsing exception.InvalidInput now. see the next patchset.\n\n\u003e What does the API do if it sees a long length; \n\u003e can that action be transposed here?\n\nThere is no error checking at API level, hence the original problem. i.e. label gets truncated in DB.","commit_id":"9bd82c7e85b5b5b966667cd558f8be0fae239823"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"fa253b779be5ec7545fe4b27ec3618da708d6946","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if not label:"},{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        # Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            reason \u003d _(\"Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"},{"line_number":747,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAHH%2F%2F%2Flk%3D","line":744,"updated":"2012-04-25 20:10:36.000000000","message":"Ditto the magic numbers comments. Please introduce a constant for this.","commit_id":"0457232ca8e2ddd3c07496c5044f3816035482de"},{"author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"change_message_id":"e2005b5ba32a0d2ac61b56d87f4819816268aa7a","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if not label:"},{"line_number":742,"context_line":"            raise exception.NetworkNotCreated(req\u003d\u0027--label\u0027)"},{"line_number":743,"context_line":"        # Size of \"label\" column in nova.networks is 255, hence the restriction"},{"line_number":744,"context_line":"        if len(label) \u003e 255:"},{"line_number":745,"context_line":"            reason \u003d _(\"Maximum allowed length for \u0027label\u0027 is 255.\")"},{"line_number":746,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"},{"line_number":747,"context_line":"        if not (fixed_range_v4 or fixed_range_v6):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAHH%2F%2F%2FY4%3D","line":744,"in_reply_to":"AAAAHH%2F%2F%2Flk%3D","updated":"2012-04-26 08:27:10.000000000","message":"While using constant in place of hardcoded number is good coding practice, introducing a constant here doesn\u0027t add much value.\n\nIdeally we would need to use the column length from nova.db.sqlalchemy.models:Network - so that changing the value of the constant changes both DB column size as well as validation. But models use hardcoded 255 everywhere to define column lengths. It is overkill to introduce the constant in models just for length check.","commit_id":"0457232ca8e2ddd3c07496c5044f3816035482de"}]}