)]}'
{"id":"openstack%2Fnova~6076","triplet_id":"openstack%2Fnova~master~Iae517e03099e36f1c00f4742049834a9231a2fff","project":"openstack/nova","branch":"master","topic":"bug/965008","hashtags":[],"change_id":"Iae517e03099e36f1c00f4742049834a9231a2fff","subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","status":"MERGED","created":"2012-04-02 10:08:16.000000000","updated":"2012-04-26 19:08:07.000000000","submitted":"2012-04-26 19:08:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f9fd274129ea872490ee74551916341356ba9079","_number":6076,"virtual_id_number":6076,"owner":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":1,"date":"2012-04-26 19:08:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"date":"2012-04-26 19:08:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-04-26 08:43:58.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},{"value":2,"date":"2012-04-26 16:39:08.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"date":"2012-04-26 10:28:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},{"value":1,"date":"2012-04-26 16:39:08.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-04-09 14:09:27.000000000","updated_by":{"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},"reviewer":{"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},"state":"REVIEWER"},{"updated":"2012-04-09 14:45:21.000000000","updated_by":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"reviewer":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"state":"REVIEWER"},{"updated":"2012-04-09 14:51:42.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2012-04-13 00:38:30.000000000","updated_by":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"reviewer":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"state":"REVIEWER"},{"updated":"2012-04-18 14:44:59.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-04-22 14:04:58.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2012-04-22 17:50:02.000000000","updated_by":{"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},"reviewer":{"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},"state":"REVIEWER"},{"updated":"2012-04-25 16:43:59.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-04-25 20:10:36.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2012-04-26 10:28:26.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-04-26 16:39:08.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-04-26 19:08:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"325ba7677621f18c6fa845c814e5314ea1314e99","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-02 10:13:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"991c5d610cb082d3fe68927250024b69666485ca","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-04-02 11:03:18.000000000","message":"Patch Set 2:\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/17010\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/17008\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/17009","accounts_in_message":[],"_revision_number":2},{"id":"0291fef5c34b088b715aeb27113339cd4cea405c","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2012-04-09 13:34:14.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f69c4887525f5c1875f450173208b10115e06716","author":{"_account_id":1475,"name":"Joe Breu","email":"breu@breu.org","username":"breu"},"date":"2012-04-09 14:09:27.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bcf65b0af9a4035e8cece3d369ce03205689950e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-09 14:31:36.000000000","message":"Patch Set 2: (3 inline comments)\n\nA couple of nits and a question I\u0027d like you to address; please see in-line…","accounts_in_message":[],"_revision_number":2},{"id":"8dc8429f608ff0ce293b6f74bf6d26d8210c274e","author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"date":"2012-04-09 14:45:21.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\nAgree with Kevin\u0027s comments.","accounts_in_message":[],"_revision_number":2},{"id":"77e86c284cc16142b1f4fb3dfc3e352c48314bc1","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-04-09 14:51:42.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\nHi Mandar!\n\nNothing wrong with making the client do some pre-checking of the label length, but shouldn\u0027t the server side be validating this kind of thing before it gets to the SQLAlchemy warning (which only warns with MySQL, since PostgreSQL will give an error and SQLite will ignore it, IIRC)\n\nThoughts?\n-jay","accounts_in_message":[],"_revision_number":2},{"id":"a66a90eb94702f9989f93f24a46fae3fe3707e62","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-09 15:09:53.000000000","message":"Patch Set 2:\n\nJay: This is a patch against nova-manage, which isn\u0027t, strictly speaking, a client.","accounts_in_message":[],"_revision_number":2},{"id":"630668757d1fffb27a9363be6d7f9676329445cb","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-12 09:33:28.000000000","message":"Patch Set 2: (2 inline comments)\n\nKevin : Made changes suggested by you.\n\nJay : As Kevin already mentioned, this is patch against nova-manage. \n\ncreate_networks() doesn\u0027t seem to be called from any place other than nova-manage. \n\nAll the validations for params passed to create_networks are done in nova-manage itself. \n\nI also confirmed that NetworkManager.create_networks() and QuantumManager.create_networks() do not perform any validation on the params. BTW, these are library calls not RPC calls (in context of your mention of server-side validation)\n\nEither we move ALL the validations to respective create_networks calls or add this additional validation in nova-manage. I chose the later to be consistent with rest of the code.","accounts_in_message":[],"_revision_number":2},{"id":"7d93deeacd058158fb02504d83d48640c0b98824","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-12 09:57:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ffeb45df2ca97bd6a21478121608c2711580623d","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-04-12 21:06:24.000000000","message":"Patch Set 3:\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/17868\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/17866\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/17867","accounts_in_message":[],"_revision_number":3},{"id":"825063a85281015104e4c3b8b26eb9fd786c693f","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2012-04-13 00:38:30.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"48be4cd65d9d472f0bb27aac5d1ab30a29eaf83c","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-17 05:47:22.000000000","message":"Patch Set 3:\n\nBrian is OK with Patch Set 3 changes.\n\nOthers : Please review this change. Otherwise it will be auto-abandoned(?) by Gerrit after 7 (?) days of inactivity.","accounts_in_message":[],"_revision_number":3},{"id":"7883126645e029c99f01fa0d5a75857af73cd6c4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-17 06:04:38.000000000","message":"Patch Set 3: (2 inline comments)\n\nHmmm, I drafted these some time ago, but apparently neglected to actually publish the comments…","accounts_in_message":[],"_revision_number":3},{"id":"798baef175d359a9623f20852004d789ce1ec3f1","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-18 08:05:50.000000000","message":"Patch Set 3: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"6d34cad85929c42ff43798509c6493fd9382f1d1","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-18 08:06:19.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"fbb5468ca7e284948996a68a250113793a0ecf2f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-04-18 09:13:22.000000000","message":"Patch Set 4:\n\nSmokeStack Results (patch set 4):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/18240\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/18238\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/18239","accounts_in_message":[],"_revision_number":4},{"id":"09bd2b541ad6402fd0dcca31b318d6ef4697d5a9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-18 14:44:59.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"23379026ffbcff76393d434c175791b67a4a3b63","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2012-04-22 14:04:58.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"2fb769138359a20172ccc1b794ac0d374d266c1a","author":{"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},"date":"2012-04-22 17:50:02.000000000","message":"Patch Set 4:\n\nI\u0027m not generally a fan of hard-coding magic numbers like this. Is there a nicer way of encoding the max length here so that if the max length were ever to change in the DB schema, it would be easier to find and update this check?\n\nI won\u0027t hold this up though, since nova-manage should hopefully be gone by Folsom, so long-term maintenance issues here are less important.","accounts_in_message":[],"_revision_number":4},{"id":"f84bb74b00e0229146b3bf777ef7920d604303ee","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-04-25 16:43:59.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"1f3d3dc788b7f31974e294de3b7d0ffa5a9f624a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-25 17:25:07.000000000","message":"Patch Set 4: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3633/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/2288/ : This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1948/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3681/ : FAILURE","accounts_in_message":[],"_revision_number":4},{"id":"fa253b779be5ec7545fe4b27ec3618da708d6946","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2012-04-25 20:10:36.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"e2005b5ba32a0d2ac61b56d87f4819816268aa7a","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-26 08:27:10.000000000","message":"Patch Set 4: (1 inline comment)\n\n@Matt :\nI\u0027ve responded to your inline comment. Additionally, please refer to comment by Lorin that nova-manage would go away in Folsom. So introducing a complex code change for short duration is overkill.\n\nPlease also refer to discussion between Jay Pipes and Kevin Mitchell dated Apr 9th and my response on Apr 12th.","accounts_in_message":[],"_revision_number":4},{"id":"d8226f32b7738579a8d60ef709cb580b6c025091","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-26 08:42:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e8a22f2dbf965eed6bbd4b93ab1160f9bdf0b785","author":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"date":"2012-04-26 08:43:58.000000000","message":"Patch Set 5:\n\nResubmitted after resolving merge conflicts in Authors file. No code changes since previous patch set.","accounts_in_message":[],"_revision_number":5},{"id":"2a0bf7db002638fec189fbdb3039d2bf2f1a3c2d","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-04-26 10:28:26.000000000","message":"Patch Set 5:\n\nSmokeStack Results (patch set 5):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/18856\n\tLibvirt (Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/18855\n\tXenServer (Ubuntu 11.10) Success: http://smokestack.openstack.org/?go\u003d/jobs/18854","accounts_in_message":[],"_revision_number":5},{"id":"894c569bf728a955cd3aa8c60a7546f828690543","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-04-26 16:39:08.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\napproving based on previous +2s","accounts_in_message":[],"_revision_number":5},{"id":"5a54a8de484ca6dcb26788b985ba897c31a958ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-26 19:08:05.000000000","message":"Patch Set 5: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3663/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/2311/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1970/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3704/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"70df59ab46735600d4ac40fc819a02f51529a9ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-26 19:08:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"2cea9b04139a0b64f1bda5b777c062e207d739f9","revisions":{"10224809f12e75b75327f62d981dfc70f12ad9e9":{"kind":"REWORK","_number":1,"created":"2012-04-02 10:08:16.000000000","uploader":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"ref":"refs/changes/76/6076/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/6076/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/6076/1"}}},"commit":{"parents":[{"commit":"a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75","subject":"Merge \"Imported Translations from Launchpad\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75"}]}],"author":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"committer":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","message":"Disallow network creation when label \u003e 255. Fixes bug 965008\n\nAdded length check for label. Without length check,\nlabel is truncated. Warning is shown by sqlalchemy layer.\n\nChange-Id: Iae517e03099e36f1c00f4742049834a9231a2fff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10224809f12e75b75327f62d981dfc70f12ad9e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10224809f12e75b75327f62d981dfc70f12ad9e9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d399797fa678b0b819296c467067fdc7c6984dcd":{"kind":"REWORK","_number":2,"created":"2012-04-02 10:13:29.000000000","uploader":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"ref":"refs/changes/76/6076/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/6076/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/6076/2"}}},"commit":{"parents":[{"commit":"a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75","subject":"Merge \"Imported Translations from Launchpad\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75"}]}],"author":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"committer":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:11:58.000000000","tz":-420},"subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","message":"Disallow network creation when label \u003e 255. Fixes bug 965008\n\nAdded length check for label. Without length check,\nlabel is truncated. Warning is shown by sqlalchemy layer.\n\nChange-Id: Iae517e03099e36f1c00f4742049834a9231a2fff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d399797fa678b0b819296c467067fdc7c6984dcd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d399797fa678b0b819296c467067fdc7c6984dcd"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a8aa3ffdeb4d171ec8b7b07472ed9008df1efb75","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9bd82c7e85b5b5b966667cd558f8be0fae239823":{"kind":"REWORK","_number":3,"created":"2012-04-12 09:57:16.000000000","uploader":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"ref":"refs/changes/76/6076/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/6076/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/6076/3"}}},"commit":{"parents":[{"commit":"42f3bec10c7f7374ad4e9752b275b02ca2b2fdb9","subject":"Merge \"adjust logging levels for linux_net\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/42f3bec10c7f7374ad4e9752b275b02ca2b2fdb9"}]}],"author":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"committer":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-12 09:57:11.000000000","tz":-420},"subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","message":"Disallow network creation when label \u003e 255. Fixes bug 965008\n\nAdded length check for label. Without length check,\nlabel is truncated. Warning is shown by sqlalchemy layer.\n\nRaise an exception when validaiton fails (like rest of the\nsurroudning code)\n\nChange-Id: Iae517e03099e36f1c00f4742049834a9231a2fff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9bd82c7e85b5b5b966667cd558f8be0fae239823"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9bd82c7e85b5b5b966667cd558f8be0fae239823"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"42f3bec10c7f7374ad4e9752b275b02ca2b2fdb9","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"0457232ca8e2ddd3c07496c5044f3816035482de":{"kind":"REWORK","_number":4,"created":"2012-04-18 08:06:19.000000000","uploader":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"ref":"refs/changes/76/6076/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/6076/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/6076/4"}}},"commit":{"parents":[{"commit":"c457ec03806269785c994af9b75383a0f52d628d","subject":"Refactor checking instance count quota.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c457ec03806269785c994af9b75383a0f52d628d"}]}],"author":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"committer":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-18 08:06:12.000000000","tz":-420},"subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","message":"Disallow network creation when label \u003e 255. Fixes bug 965008\n\nAdded length check for label. Without length check,\nlabel is truncated. Warning is shown by sqlalchemy layer.\n\nRaise an InvalidInput exception when validaiton fails (like\nrest of the surroudning code)\n\nChange-Id: Iae517e03099e36f1c00f4742049834a9231a2fff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0457232ca8e2ddd3c07496c5044f3816035482de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0457232ca8e2ddd3c07496c5044f3816035482de"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c457ec03806269785c994af9b75383a0f52d628d","is_merged_in_target_branch":true,"change_id":"I8ab738f3042ccf451d769c62b9fee2d20fa23953","change_number":6562,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"},"2cea9b04139a0b64f1bda5b777c062e207d739f9":{"kind":"REWORK","_number":5,"created":"2012-04-26 08:42:57.000000000","uploader":{"_account_id":2883,"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","username":"mandarvaze"},"ref":"refs/changes/76/6076/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/6076/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/6076/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/6076/5"}}},"commit":{"parents":[{"commit":"caa1b282c701d5e9b9e02ffdb07d432d9b35ed13","subject":"Xen: Pass session to destroy_vdi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/caa1b282c701d5e9b9e02ffdb07d432d9b35ed13"}]}],"author":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-02 10:02:22.000000000","tz":-420},"committer":{"name":"Mandar Vaze","email":"mandar.vaze@vertex.co.in","date":"2012-04-26 08:42:23.000000000","tz":-420},"subject":"Disallow network creation when label \u003e 255. Fixes bug 965008","message":"Disallow network creation when label \u003e 255. Fixes bug 965008\n\nAdded length check for label. Without length check,\nlabel is truncated. Warning is shown by sqlalchemy layer.\n\nRaise an InvalidInput exception when validation fails (like\nrest of the surroudning code)\n\nChange-Id: Iae517e03099e36f1c00f4742049834a9231a2fff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2cea9b04139a0b64f1bda5b777c062e207d739f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2cea9b04139a0b64f1bda5b777c062e207d739f9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"caa1b282c701d5e9b9e02ffdb07d432d9b35ed13","is_merged_in_target_branch":true,"change_id":"I34c59ff536abfdff9221cdb3d9ecc45d1e7a1a90","change_number":6818,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}