)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f6623d4fa9c1ae05c4d06b4dd0e7fd70e7286faf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"add back the existing allocations for existing instances. Keeping the"},{"line_number":29,"context_line":"ComputeNode.uuid the same means we simply look up the existing"},{"line_number":30,"context_line":"ResourceProvider in placement, avoiding all this pain and tears."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #1714248"},{"line_number":33,"context_line":"Co-Authored-By: Dmitry Tantsur \u003cdtantsur@redhat.com\u003e"},{"line_number":34,"context_line":"Change-Id: I4253cffca3dbf558c875eed7e77711a31e9e3406"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1f6d0b66","line":31,"updated":"2018-10-03 16:17:18.000000000","message":"If there were conflicts, you should mention them here with a note, something like this:\n\nhttps://review.openstack.org/#/c/605880/1//COMMIT_MSG@25","commit_id":"5959d4fbad965b234bfeecb004e672f07501c1be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f6623d4fa9c1ae05c4d06b4dd0e7fd70e7286faf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Closes-Bug: #1714248"},{"line_number":33,"context_line":"Co-Authored-By: Dmitry Tantsur \u003cdtantsur@redhat.com\u003e"},{"line_number":34,"context_line":"Change-Id: I4253cffca3dbf558c875eed7e77711a31e9e3406"},{"line_number":35,"context_line":"(cherry picked from commit e3c5e22d1fde7ca916a8cc364f335fba8a3a798f)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3f93275e","line":35,"updated":"2018-10-03 16:17:18.000000000","message":"Did you cherry pick this from queens or the pike backport? If the latter, I\u0027m assuming you forgot the -x option with the cherry-pick command.","commit_id":"5959d4fbad965b234bfeecb004e672f07501c1be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e7a0a5ca9a126a4de70c9b6eaf325188e83aa8c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    nova/virt/fake.py"},{"line_number":37,"context_line":"    nova/virt/ironic/driver.py"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Conflicts were small, primarily due to the removal in Pike of the virt"},{"line_number":40,"context_line":"driver\u0027s requires_allocation_refresh class attribute. This attribute is"},{"line_number":41,"context_line":"still used in Ocata."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3a381239","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":58},"updated":"2018-10-03 19:14:35.000000000","message":"This is incorrect, that still existed in pike:\n\nhttps://github.com/openstack/nova/blob/stable/pike/nova/compute/resource_tracker.py#L1186\n\nI believe it was removed in Stein...\n\nI think you meant the opposite. It\u0027s due to not having Ibbf65a8d817d359786abcdffa6358089ed1107f6 in Ocata.","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1df9090ad7e6c280b698764fb8722de97300c874","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    nova/virt/fake.py"},{"line_number":37,"context_line":"    nova/virt/ironic/driver.py"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Conflicts were small, primarily due to the removal in Pike of the virt"},{"line_number":40,"context_line":"driver\u0027s requires_allocation_refresh class attribute. This attribute is"},{"line_number":41,"context_line":"still used in Ocata."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_4be0a2f8","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":58},"in_reply_to":"3f79a3b5_3a381239","updated":"2018-10-03 21:16:02.000000000","message":"ack, sorry.","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e7a0a5ca9a126a4de70c9b6eaf325188e83aa8c","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            return True"},{"line_number":453,"context_line":"        elif len(cn_candidates) \u003e 1:"},{"line_number":454,"context_line":"            LOG.error("},{"line_number":455,"context_line":"                \"Found more than one ComputeNode for nodename %s. \""},{"line_number":456,"context_line":"                \"Please clean up the orphaned ComputeNode records in your DB.\","},{"line_number":457,"context_line":"                nodename)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3a66d256","line":455,"updated":"2018-10-03 19:14:35.000000000","message":"I expect pep8 to fail on all of the log messages \u003e debug() because we still required translation markers in ocata. Run pep8 to find out.","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d6164d1e045766ca6ec77e3e9ad885709325176b","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        if len(cn_candidates) \u003d\u003d 1:"},{"line_number":444,"context_line":"            cn \u003d cn_candidates[0]"},{"line_number":445,"context_line":"            LOG.info(_LI(\"ComputeNode %(name)s moving from %(old)s to \""},{"line_number":446,"context_line":"                         \"%(new)s\"),"},{"line_number":447,"context_line":"                     {\"name\": nodename, \"old\": cn.host, \"new\": self.host})"},{"line_number":448,"context_line":"            cn.host \u003d self.host"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_63b6ccff","line":445,"range":{"start_line":445,"start_character":21,"end_line":445,"end_character":24},"updated":"2018-10-04 18:45:58.000000000","message":"Note to self: this is needed in Ocata and not in Pike.","commit_id":"028f03c8c3d3dac4de50aa8658c474395a683d61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"94e1a35fa442f365b4fe7a55add4be060e339100","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            return True"},{"line_number":454,"context_line":"        elif len(cn_candidates) \u003e 1:"},{"line_number":455,"context_line":"            LOG.error("},{"line_number":456,"context_line":"                _(\"Found more than one ComputeNode for nodename %s. \""},{"line_number":457,"context_line":"                  \"Please clean up the orphaned ComputeNode records in your \""},{"line_number":458,"context_line":"                  \"DB.\"),"},{"line_number":459,"context_line":"                nodename)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_01bb69bd","line":456,"range":{"start_line":456,"start_character":16,"end_line":456,"end_character":17},"updated":"2018-10-03 23:26:18.000000000","message":"I expect pep8 to complain about this not being _LE.","commit_id":"028f03c8c3d3dac4de50aa8658c474395a683d61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c890c8ba9734c65f194c311c7ec0ff297185f7fa","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            return True"},{"line_number":454,"context_line":"        elif len(cn_candidates) \u003e 1:"},{"line_number":455,"context_line":"            LOG.error("},{"line_number":456,"context_line":"                _(\"Found more than one ComputeNode for nodename %s. \""},{"line_number":457,"context_line":"                  \"Please clean up the orphaned ComputeNode records in your \""},{"line_number":458,"context_line":"                  \"DB.\"),"},{"line_number":459,"context_line":"                nodename)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_41fde138","line":456,"range":{"start_line":456,"start_character":16,"end_line":456,"end_character":17},"in_reply_to":"3f79a3b5_01bb69bd","updated":"2018-10-03 23:47:55.000000000","message":"Huh I guess not.","commit_id":"028f03c8c3d3dac4de50aa8658c474395a683d61"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d6164d1e045766ca6ec77e3e9ad885709325176b","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            return True"},{"line_number":454,"context_line":"        elif len(cn_candidates) \u003e 1:"},{"line_number":455,"context_line":"            LOG.error("},{"line_number":456,"context_line":"                _(\"Found more than one ComputeNode for nodename %s. \""},{"line_number":457,"context_line":"                  \"Please clean up the orphaned ComputeNode records in your \""},{"line_number":458,"context_line":"                  \"DB.\"),"},{"line_number":459,"context_line":"                nodename)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_83bbe8e2","line":456,"range":{"start_line":456,"start_character":16,"end_line":456,"end_character":17},"in_reply_to":"3f79a3b5_41fde138","updated":"2018-10-04 18:45:58.000000000","message":"Note to self: this is needed in Ocata and not in Pike.","commit_id":"028f03c8c3d3dac4de50aa8658c474395a683d61"}],"nova/virt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e7a0a5ca9a126a4de70c9b6eaf325188e83aa8c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"supports_device_tagging\": False,"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    requires_allocation_refresh \u003d False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # Indicates if this driver will rebalance nodes among compute service"},{"line_number":136,"context_line":"    # hosts. This is really here for ironic and should not be used by any"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1a543653","line":133,"updated":"2018-10-03 19:14:35.000000000","message":"This is wrong - it\u0027s not used in ocata.","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1df9090ad7e6c280b698764fb8722de97300c874","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"supports_device_tagging\": False,"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    requires_allocation_refresh \u003d False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # Indicates if this driver will rebalance nodes among compute service"},{"line_number":136,"context_line":"    # hosts. This is really here for ironic and should not be used by any"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6ba55eb3","line":133,"in_reply_to":"3f79a3b5_1a543653","updated":"2018-10-03 21:16:02.000000000","message":"Done","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e7a0a5ca9a126a4de70c9b6eaf325188e83aa8c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # class resources"},{"line_number":136,"context_line":"    # TODO(johngarbutt) we should remove this once the resource class"},{"line_number":137,"context_line":"    # migration has been completed."},{"line_number":138,"context_line":"    requires_allocation_refresh \u003d True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # This driver is capable of rebalancing nodes between computes."},{"line_number":141,"context_line":"    rebalances_nodes \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bac8a220","line":138,"updated":"2018-10-03 19:14:35.000000000","message":"BZZZTTT!","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1df9090ad7e6c280b698764fb8722de97300c874","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # class resources"},{"line_number":136,"context_line":"    # TODO(johngarbutt) we should remove this once the resource class"},{"line_number":137,"context_line":"    # migration has been completed."},{"line_number":138,"context_line":"    requires_allocation_refresh \u003d True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # This driver is capable of rebalancing nodes between computes."},{"line_number":141,"context_line":"    rebalances_nodes \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4b8e6232","line":138,"in_reply_to":"3f79a3b5_bac8a220","updated":"2018-10-03 21:16:02.000000000","message":"Done","commit_id":"f47716b1ea622a00589075e45c5086d9b75f0077"}]}