)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a33902ff30aa92db40d2759ccfb1980c3a82d9ff","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":487,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":488,"context_line":"    When both ``changes-since`` and ``changes-before`` are specified,"},{"line_number":489,"context_line":"    the value of the ``changes-since`` must be earlier than or equal to"},{"line_number":490,"context_line":"    the value of the ``changes-before`` otherwise API will return 400."},{"line_number":491,"context_line":"  in: query"},{"line_number":492,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_b191599e","line":489,"range":{"start_line":489,"start_character":23,"end_line":489,"end_character":36},"updated":"2018-10-19 05:17:17.000000000","message":"nit:\nIt is  a description for \u0027changes-before\u0027 parameter.\nSo it is better that \u0027changes-before\u0027 is the subject word, isn\u0027t it?\n\n  the value of the ``changes-before`` must be later than or equal to the value of the ``changes-since`` otherwise API will return 400.","commit_id":"8f60f9a4705a29c0a06b303bf52e26d01b43cf3b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9c689884ac2fd3c895854c4c775dadfcb9960b96","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":487,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":488,"context_line":"    When both ``changes-since`` and ``changes-before`` are specified,"},{"line_number":489,"context_line":"    the value of the ``changes-since`` must be earlier than or equal to"},{"line_number":490,"context_line":"    the value of the ``changes-before`` otherwise API will return 400."},{"line_number":491,"context_line":"  in: query"},{"line_number":492,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_91c0dd4c","line":489,"range":{"start_line":489,"start_character":23,"end_line":489,"end_character":36},"in_reply_to":"3f79a3b5_b191599e","updated":"2018-10-19 05:44:47.000000000","message":"Done","commit_id":"8f60f9a4705a29c0a06b303bf52e26d01b43cf3b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a33902ff30aa92db40d2759ccfb1980c3a82d9ff","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":543,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":544,"context_line":"    When both ``changes-since`` and ``changes-before`` are specified,"},{"line_number":545,"context_line":"    the value of the ``changes-before`` must be later than or equal to"},{"line_number":546,"context_line":"    the value of the ``changes-since`` otherwise API will return 400."},{"line_number":547,"context_line":"  in: query"},{"line_number":548,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_9188dd6b","line":545,"range":{"start_line":545,"start_character":23,"end_line":545,"end_character":37},"updated":"2018-10-19 05:17:17.000000000","message":"ditto","commit_id":"8f60f9a4705a29c0a06b303bf52e26d01b43cf3b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9c689884ac2fd3c895854c4c775dadfcb9960b96","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":543,"context_line":"    If you omit the time zone, the UTC time zone is assumed."},{"line_number":544,"context_line":"    When both ``changes-since`` and ``changes-before`` are specified,"},{"line_number":545,"context_line":"    the value of the ``changes-before`` must be later than or equal to"},{"line_number":546,"context_line":"    the value of the ``changes-since`` otherwise API will return 400."},{"line_number":547,"context_line":"  in: query"},{"line_number":548,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_11aa8d83","line":545,"range":{"start_line":545,"start_character":23,"end_line":545,"end_character":37},"in_reply_to":"3f79a3b5_9188dd6b","updated":"2018-10-19 05:44:47.000000000","message":"Done","commit_id":"8f60f9a4705a29c0a06b303bf52e26d01b43cf3b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ad9418ef9dbaecd712d03266b1028eae50333cd","unresolved":false,"context_lines":[{"line_number":492,"context_line":"  required: false"},{"line_number":493,"context_line":"  type: string"},{"line_number":494,"context_line":"  min_version: 2.66"},{"line_number":495,"context_line":"changes_before_server:"},{"line_number":496,"context_line":"  description: |"},{"line_number":497,"context_line":"    Filters the response by a date and time stamp when the server last changed."},{"line_number":498,"context_line":"    Those servers that changed before or equal to the specified date and time stamp"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_762d938e","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":21},"updated":"2018-10-24 15:01:47.000000000","message":"Technically this should probably have the same description addition about usage.","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f68de67d74ecd71b7ac2577526eadebc354d64c","unresolved":false,"context_lines":[{"line_number":492,"context_line":"  required: false"},{"line_number":493,"context_line":"  type: string"},{"line_number":494,"context_line":"  min_version: 2.66"},{"line_number":495,"context_line":"changes_before_server:"},{"line_number":496,"context_line":"  description: |"},{"line_number":497,"context_line":"    Filters the response by a date and time stamp when the server last changed."},{"line_number":498,"context_line":"    Those servers that changed before or equal to the specified date and time stamp"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_b6680b22","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":21},"in_reply_to":"3f79a3b5_762d938e","updated":"2018-10-24 15:18:22.000000000","message":"Done here: https://review.openstack.org/#/c/613070/","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ad9418ef9dbaecd712d03266b1028eae50333cd","unresolved":false,"context_lines":[{"line_number":548,"context_line":"  required: false"},{"line_number":549,"context_line":"  type: string"},{"line_number":550,"context_line":"  min_version: 2.59"},{"line_number":551,"context_line":"changes_since_server:"},{"line_number":552,"context_line":"  description: |"},{"line_number":553,"context_line":"    Filters the response by a date and time stamp when the server last"},{"line_number":554,"context_line":"    changed status. To help keep track of changes this may also return"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_564e576e","line":551,"range":{"start_line":551,"start_character":0,"end_line":551,"end_character":20},"updated":"2018-10-24 15:01:47.000000000","message":"same","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"}],"api-ref/source/server-migrations.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ed89a9524a0428412d3550941103fa654bc56f5a","unresolved":false,"context_lines":[{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  - server_id: server_id_path"},{"line_number":32,"context_line":"  - changes-since: changes_since_server"},{"line_number":33,"context_line":"  - changes-before: changes_before_server"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Response"},{"line_number":36,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3f79a3b5_e7304558","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":41},"updated":"2018-10-10 05:20:56.000000000","message":"This change is not necessary.\nThe API reference has already been updated.\nhttps://github.com/openstack/nova/blob/master/api-ref/source/os-migrations.inc#request","commit_id":"991d602f41e4fd57ee80eaf81b22b9ba9b3da446"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b0401fb0061669567420ba6f7709ac6febd2a08b","unresolved":false,"context_lines":[{"line_number":29,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  - server_id: server_id_path"},{"line_number":32,"context_line":"  - changes-since: changes_since_server"},{"line_number":33,"context_line":"  - changes-before: changes_before_server"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Response"},{"line_number":36,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3f79a3b5_36274921","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":41},"in_reply_to":"3f79a3b5_e7304558","updated":"2018-10-10 08:47:00.000000000","message":"Yeah, this change is not necessary, this set in https://review.openstack.org/#/c/599276/, so remove that in this patch.","commit_id":"991d602f41e4fd57ee80eaf81b22b9ba9b3da446"}],"nova/api/openstack/compute/migrations.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5f89c25a94f3b52bafd4a73f62b37b0bd338bc67","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                search_opts[\u0027changes-before\u0027] \u003d timeutils.parse_isotime("},{"line_number":98,"context_line":"                    search_opts[\u0027changes-before\u0027])"},{"line_number":99,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":100,"context_line":"                if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":101,"context_line":"                        search_opts[\u0027changes-since\u0027]:"},{"line_number":102,"context_line":"                    msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":103,"context_line":"                          \u0027or equal to changes-before.\u0027"},{"line_number":104,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e8be4dcc","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":53},"updated":"2018-10-04 05:17:36.000000000","message":"nit:\n\nif (changes_since and search_opts[\u0027changes-before\u0027] \u003c\n        search_opts[\u0027changes-since\u0027]):","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2092405dfaa21fe67b074e6e591d7ac8a3c060e1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                search_opts[\u0027changes-before\u0027] \u003d timeutils.parse_isotime("},{"line_number":98,"context_line":"                    search_opts[\u0027changes-before\u0027])"},{"line_number":99,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":100,"context_line":"                if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":101,"context_line":"                        search_opts[\u0027changes-since\u0027]:"},{"line_number":102,"context_line":"                    msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":103,"context_line":"                          \u0027or equal to changes-before.\u0027"},{"line_number":104,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6b06b71d","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":53},"in_reply_to":"3f79a3b5_e8be4dcc","updated":"2018-10-04 05:51:33.000000000","message":"Done","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5f89c25a94f3b52bafd4a73f62b37b0bd338bc67","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":100,"context_line":"                if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":101,"context_line":"                        search_opts[\u0027changes-since\u0027]:"},{"line_number":102,"context_line":"                    msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":103,"context_line":"                          \u0027or equal to changes-before.\u0027"},{"line_number":104,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                # Before microversion 2.59 the schema allowed"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_68a8fd89","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":55},"updated":"2018-10-04 05:17:36.000000000","message":"marker function is required.\n\nmsg \u003d _(\u0027The value of changes-since must be less than \u0027\n        \u0027or equal to changes-before.\u0027)","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2092405dfaa21fe67b074e6e591d7ac8a3c060e1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":100,"context_line":"                if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":101,"context_line":"                        search_opts[\u0027changes-since\u0027]:"},{"line_number":102,"context_line":"                    msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":103,"context_line":"                          \u0027or equal to changes-before.\u0027"},{"line_number":104,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                # Before microversion 2.59 the schema allowed"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0b114353","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":55},"in_reply_to":"3f79a3b5_68a8fd89","updated":"2018-10-04 05:51:33.000000000","message":"Done","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ad9418ef9dbaecd712d03266b1028eae50333cd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    search_opts[\u0027changes-before\u0027])"},{"line_number":100,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":101,"context_line":"                if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":102,"context_line":"                    search_opts[\u0027changes-since\u0027]):"},{"line_number":103,"context_line":"                    msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":104,"context_line":"                            \u0027or equal to changes-before.\u0027)"},{"line_number":105,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_d66267d9","line":102,"updated":"2018-10-24 15:01:47.000000000","message":"nit: indent","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7c0854e436f7a710eb27785f1b18796b939122f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    search_opts[\u0027changes-before\u0027])"},{"line_number":100,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":101,"context_line":"                if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":102,"context_line":"                    search_opts[\u0027changes-since\u0027]):"},{"line_number":103,"context_line":"                    msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":104,"context_line":"                            \u0027or equal to changes-before.\u0027)"},{"line_number":105,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f6ad23a4","line":102,"in_reply_to":"3f79a3b5_d66267d9","updated":"2018-10-24 15:17:37.000000000","message":"Done","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ad9418ef9dbaecd712d03266b1028eae50333cd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":101,"context_line":"                if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":102,"context_line":"                    search_opts[\u0027changes-since\u0027]):"},{"line_number":103,"context_line":"                    msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":104,"context_line":"                            \u0027or equal to changes-before.\u0027)"},{"line_number":105,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":106,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_36971b9f","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":74},"updated":"2018-10-24 15:01:47.000000000","message":"need a space between words in the error message","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7c0854e436f7a710eb27785f1b18796b939122f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":101,"context_line":"                if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":102,"context_line":"                    search_opts[\u0027changes-since\u0027]):"},{"line_number":103,"context_line":"                    msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":104,"context_line":"                            \u0027or equal to changes-before.\u0027)"},{"line_number":105,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":106,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_16b3ff0a","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":74},"in_reply_to":"3f79a3b5_36971b9f","updated":"2018-10-24 15:17:37.000000000","message":"Done","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"}],"nova/tests/unit/api/openstack/compute/test_migrations.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5f89c25a94f3b52bafd4a73f62b37b0bd338bc67","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_with_bad_request(self):"},{"line_number":367,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"},{"line_number":368,"context_line":"        changes_before \u003d \u00272018-09-03T05:45:27Z\u0027"},{"line_number":369,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/os-migrations?\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c8d4b1ec","line":366,"range":{"start_line":366,"start_character":33,"end_line":366,"end_character":44},"updated":"2018-10-04 05:17:36.000000000","message":"IMO, it is not appropriate. Conditions of the test case should be described.","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2092405dfaa21fe67b074e6e591d7ac8a3c060e1","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_with_bad_request(self):"},{"line_number":367,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"},{"line_number":368,"context_line":"        changes_before \u003d \u00272018-09-03T05:45:27Z\u0027"},{"line_number":369,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/os-migrations?\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_eb3f27af","line":366,"range":{"start_line":366,"start_character":33,"end_line":366,"end_character":44},"in_reply_to":"3f79a3b5_c8d4b1ec","updated":"2018-10-04 05:51:33.000000000","message":"Yeah, change it to \"test_get_migrations_filters_with_distinct_changes_time_bad_request\" as the same PS1","commit_id":"35e05531a4afd2faa6e024f5681385820a67fe76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d74fb21999851088f39bc5e6f542c2b525b66c2d","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            version\u003dself.wsgi_api_version, use_admin_context\u003dTrue)"},{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_filters_with_distinct_changes_time_bad_request("},{"line_number":367,"context_line":"            self):"},{"line_number":368,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9729428a","line":365,"updated":"2018-10-12 08:06:17.000000000","message":"A successful test case specifying both \u0027changes-since\u0027 and \u0027changes-before\u0027 is missing.","commit_id":"be0fdb6910c7290c27b6698301cd8750ac758313"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ece34219a39e5fed226e9c0f083ebaf9c727a677","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            version\u003dself.wsgi_api_version, use_admin_context\u003dTrue)"},{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_filters_with_distinct_changes_time_bad_request("},{"line_number":367,"context_line":"            self):"},{"line_number":368,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_bab5e91b","line":365,"in_reply_to":"3f79a3b5_21124cb5","updated":"2018-10-17 06:47:14.000000000","message":"Done","commit_id":"be0fdb6910c7290c27b6698301cd8750ac758313"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"eaff1e8c92009aee2213f3debd914a4813e0d20a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            version\u003dself.wsgi_api_version, use_admin_context\u003dTrue)"},{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_filters_with_distinct_changes_time_bad_request("},{"line_number":367,"context_line":"            self):"},{"line_number":368,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c22dba90","line":365,"in_reply_to":"3f79a3b5_9729428a","updated":"2018-10-12 08:56:24.000000000","message":"I inherited MigrationsTestCaseV259, I don\u0027t think there is a need to add a successful test case specifying both \u0027changes-since\u0027 and \u0027changes-before\u0027 is missing. I think that will be repeated with the test case \"test_index\" of MigrationsTestCaseV259. What do you think?","commit_id":"be0fdb6910c7290c27b6698301cd8750ac758313"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"99b823b4d3492f2b6de1aa0e3457474dcc15d37a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            version\u003dself.wsgi_api_version, use_admin_context\u003dTrue)"},{"line_number":363,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":364,"context_line":"                          self.controller.index, req)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_get_migrations_filters_with_distinct_changes_time_bad_request("},{"line_number":367,"context_line":"            self):"},{"line_number":368,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_21124cb5","line":365,"in_reply_to":"3f79a3b5_c22dba90","updated":"2018-10-15 03:09:32.000000000","message":"I wanted to say that a successful test case specifying both \u0027changes-since\u0027 and \u0027changes-before\u0027 should be added.","commit_id":"be0fdb6910c7290c27b6698301cd8750ac758313"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ad9418ef9dbaecd712d03266b1028eae50333cd","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                                      (changes_since, changes_before),"},{"line_number":399,"context_line":"                                      version\u003dself.wsgi_api_version,"},{"line_number":400,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":401,"context_line":"        self.assertRaises(exc.HTTPBadRequest, self.controller.index, req)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_index_with_changes_before_old_microversion_failed(self):"},{"line_number":404,"context_line":"        \"\"\"Tests that the changes-before query parameter is an error before"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_96adcfe8","line":401,"updated":"2018-10-24 15:01:47.000000000","message":"Assert the error is what you expect by inspecting the error message, something like:\n\nex \u003d self.assertRaises(...)\nself.assertIn(\u0027The value of changes-since must be less than \u0027\n              \u0027or equal to changes-before\u0027, six.text_type(ex))","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7c0854e436f7a710eb27785f1b18796b939122f","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                                      (changes_since, changes_before),"},{"line_number":399,"context_line":"                                      version\u003dself.wsgi_api_version,"},{"line_number":400,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":401,"context_line":"        self.assertRaises(exc.HTTPBadRequest, self.controller.index, req)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_index_with_changes_before_old_microversion_failed(self):"},{"line_number":404,"context_line":"        \"\"\"Tests that the changes-before query parameter is an error before"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_36863b18","line":401,"in_reply_to":"3f79a3b5_96adcfe8","updated":"2018-10-24 15:17:37.000000000","message":"Done","commit_id":"d0c7e3faa386a954efe68399c41266a5fc0101b5"}]}