)]}'
{"nova/api/openstack/compute/instance_actions.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9473942e321fa240b03a695f1a632736c7bab7b8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            search_opts[\u0027changes-before\u0027] \u003d timeutils.parse_isotime("},{"line_number":112,"context_line":"                search_opts[\u0027changes-before\u0027])"},{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":115,"context_line":"                    search_opts[\u0027changes-since\u0027]:"},{"line_number":116,"context_line":"                msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":117,"context_line":"                      \u0027or equal to changes-before.\u0027"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_28668556","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":49},"updated":"2018-10-04 05:22:02.000000000","message":"nit:\nif (changes_since and search_opts[\u0027changes-before\u0027] \u003c\n        search_opts[\u0027changes-since\u0027]):","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8ee9b3dcb61006b36e4e567363c50985c7d9272e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            search_opts[\u0027changes-before\u0027] \u003d timeutils.parse_isotime("},{"line_number":112,"context_line":"                search_opts[\u0027changes-before\u0027])"},{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":115,"context_line":"                    search_opts[\u0027changes-since\u0027]:"},{"line_number":116,"context_line":"                msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":117,"context_line":"                      \u0027or equal to changes-before.\u0027"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4b3bbb99","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":49},"in_reply_to":"3f79a3b5_28668556","updated":"2018-10-04 06:07:52.000000000","message":"Done","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9473942e321fa240b03a695f1a632736c7bab7b8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":115,"context_line":"                    search_opts[\u0027changes-since\u0027]:"},{"line_number":116,"context_line":"                msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":117,"context_line":"                      \u0027or equal to changes-before.\u0027"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        limit, marker \u003d common.get_limit_and_marker(req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a8637540","line":117,"range":{"start_line":116,"start_character":0,"end_line":117,"end_character":51},"updated":"2018-10-04 05:22:02.000000000","message":"The marker function is required.\n\n    msg \u003d _(\u0027The value of changes-since must be less than \u0027\n            \u0027or equal to changes-before.\u0027)","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8ee9b3dcb61006b36e4e567363c50985c7d9272e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if changes_since and search_opts[\u0027changes-before\u0027] \u003c \\"},{"line_number":115,"context_line":"                    search_opts[\u0027changes-since\u0027]:"},{"line_number":116,"context_line":"                msg \u003d \u0027The value of changes-since must be less than\u0027 \\"},{"line_number":117,"context_line":"                      \u0027or equal to changes-before.\u0027"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        limit, marker \u003d common.get_limit_and_marker(req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6b3eb78a","line":117,"range":{"start_line":116,"start_character":0,"end_line":117,"end_character":51},"in_reply_to":"3f79a3b5_a8637540","updated":"2018-10-04 06:07:52.000000000","message":"Done","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"599f8a22e4a08f78fe4091972f4fc1fd79c52c57","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":115,"context_line":"                search_opts[\u0027changes-since\u0027]):"},{"line_number":116,"context_line":"                msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":117,"context_line":"                        \u0027or equal to changes-before.\u0027)"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_56ead70d","line":116,"range":{"start_line":116,"start_character":69,"end_line":116,"end_character":70},"updated":"2018-10-24 15:02:26.000000000","message":"same comment as https://review.openstack.org/#/c/607798/","commit_id":"a8f9474cdc9fde4efa4ebf06b6bfb4d2acda9c06"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7f831d59113d9e76dc37951763d80cf2551a3a8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            changes_since \u003d search_opts.get(\u0027changes-since\u0027)"},{"line_number":114,"context_line":"            if (changes_since and search_opts[\u0027changes-before\u0027] \u003c"},{"line_number":115,"context_line":"                search_opts[\u0027changes-since\u0027]):"},{"line_number":116,"context_line":"                msg \u003d _(\u0027The value of changes-since must be less than\u0027"},{"line_number":117,"context_line":"                        \u0027or equal to changes-before.\u0027)"},{"line_number":118,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f690c343","line":116,"range":{"start_line":116,"start_character":69,"end_line":116,"end_character":70},"in_reply_to":"3f79a3b5_56ead70d","updated":"2018-10-24 15:18:01.000000000","message":"Done","commit_id":"a8f9474cdc9fde4efa4ebf06b6bfb4d2acda9c06"}],"nova/tests/unit/api/openstack/compute/test_instance_actions.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9473942e321fa240b03a695f1a632736c7bab7b8","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        self.assertIn(\u0027Invalid input for query parameters changes-before\u0027,"},{"line_number":341,"context_line":"                      six.text_type(ex))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_get_action_with_bad_request(self):"},{"line_number":344,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"},{"line_number":345,"context_line":"        changes_before \u003d \u00272018-09-03T05:45:27Z\u0027"},{"line_number":346,"context_line":"        req \u003d self._get_http_req(\u0027os-instance-actions?\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6859dd8a","line":343,"range":{"start_line":343,"start_character":29,"end_line":343,"end_character":40},"updated":"2018-10-04 05:22:02.000000000","message":"IMO, it is not appropriate. The conditions of the test case should be described.","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8ee9b3dcb61006b36e4e567363c50985c7d9272e","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        self.assertIn(\u0027Invalid input for query parameters changes-before\u0027,"},{"line_number":341,"context_line":"                      six.text_type(ex))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_get_action_with_bad_request(self):"},{"line_number":344,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"},{"line_number":345,"context_line":"        changes_before \u003d \u00272018-09-03T05:45:27Z\u0027"},{"line_number":346,"context_line":"        req \u003d self._get_http_req(\u0027os-instance-actions?\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cbfcabb7","line":343,"range":{"start_line":343,"start_character":29,"end_line":343,"end_character":40},"in_reply_to":"3f79a3b5_6859dd8a","updated":"2018-10-04 06:07:52.000000000","message":"Done","commit_id":"c7efec7afe1cdb9983e1ccba269f3c078901194b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7255c7f2dadae0442d2bd71bde9f14f0a08f5f6b","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                               self.controller.index, req)"},{"line_number":340,"context_line":"        self.assertIn(\u0027Invalid input for query parameters changes-before\u0027,"},{"line_number":341,"context_line":"                      six.text_type(ex))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_instance_actions_filters_with_distinct_changes_time_bad_request("},{"line_number":344,"context_line":"            self):"},{"line_number":345,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a153bc6b","line":342,"updated":"2018-10-15 02:53:29.000000000","message":"A successful test case specifying both \u0027changes-since\u0027 and \u0027changes-before\u0027 should be added.","commit_id":"b5cfea1ba6ee8b8bb75e3ace5e6cf094c8ee17f0"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0ceb983b68c9f94d732fae7d0f8491055ca22d37","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                               self.controller.index, req)"},{"line_number":340,"context_line":"        self.assertIn(\u0027Invalid input for query parameters changes-before\u0027,"},{"line_number":341,"context_line":"                      six.text_type(ex))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_instance_actions_filters_with_distinct_changes_time_bad_request("},{"line_number":344,"context_line":"            self):"},{"line_number":345,"context_line":"        changes_since \u003d \u00272018-09-04T05:45:27Z\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_37125263","line":342,"in_reply_to":"3f79a3b5_a153bc6b","updated":"2018-10-17 06:22:39.000000000","message":"Done","commit_id":"b5cfea1ba6ee8b8bb75e3ace5e6cf094c8ee17f0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"599f8a22e4a08f78fe4091972f4fc1fd79c52c57","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        req \u003d self._get_http_req(\u0027os-instance-actions?\u0027"},{"line_number":373,"context_line":"                                 \u0027changes-since\u003d%s\u0026changes-before\u003d%s\u0027 %"},{"line_number":374,"context_line":"                                 (changes_since, changes_before))"},{"line_number":375,"context_line":"        self.assertRaises(exc.HTTPBadRequest,"},{"line_number":376,"context_line":"                          self.controller.index, req, FAKE_UUID)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def test_get_action_with_changes_before_old_microversion(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f6ea030b","line":375,"updated":"2018-10-24 15:02:26.000000000","message":"same comment as https://review.openstack.org/#/c/607798/","commit_id":"a8f9474cdc9fde4efa4ebf06b6bfb4d2acda9c06"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7f831d59113d9e76dc37951763d80cf2551a3a8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        req \u003d self._get_http_req(\u0027os-instance-actions?\u0027"},{"line_number":373,"context_line":"                                 \u0027changes-since\u003d%s\u0026changes-before\u003d%s\u0027 %"},{"line_number":374,"context_line":"                                 (changes_since, changes_before))"},{"line_number":375,"context_line":"        self.assertRaises(exc.HTTPBadRequest,"},{"line_number":376,"context_line":"                          self.controller.index, req, FAKE_UUID)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def test_get_action_with_changes_before_old_microversion(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f67a03ed","line":375,"in_reply_to":"3f79a3b5_f6ea030b","updated":"2018-10-24 15:18:01.000000000","message":"Done","commit_id":"a8f9474cdc9fde4efa4ebf06b6bfb4d2acda9c06"}]}