)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"562e30b9c3aff7c5ce6ed610cbd316566a0ccdc9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make \u0027plugin\u0027 a required argument for \u0027_get_vif_instance\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027plugin\u0027 is the one argument for \u0027os_vif.objects.vif.VIFBase\u0027 (and"},{"line_number":10,"context_line":"therefore all subclasses) that doesn\u0027t have a default and is therefore"},{"line_number":11,"context_line":"required [1]. Enforce this on the nova side and prevent possible slip"},{"line_number":12,"context_line":"ups like those seen in [2]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/openstack/os-vif/blob/1.11.1/os_vif/objects/vif.py#L27-L52"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_2c2cdcb0","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":13},"updated":"2018-10-23 00:37:12.000000000","message":"nit: techncally this is not true.\nyou are also required to pass the neutron port uuid as\nthe id field.\n\nhttps://github.com/openstack/os-vif/blob/c5fda08d4010f91487d1336852ec94b275fdbd8d/os_vif/objects/vif.py#L29","commit_id":"ebd31089d537522221dd1d08f7dab8d0d5232fe1"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e601ad8d8b4c686dc9b5b48708c762ce78fc0c01","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    \"\"\"Instantiate an os-vif VIF instance"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    :param vif: the nova.network.model.VIF instance"},{"line_number":252,"context_line":"    :param cls: class for a os_vif.objects.vif.VIFBase subclass"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    :returns: a os_vif.objects.vif.VIFBase instance"},{"line_number":255,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_58eb0fdc","line":252,"updated":"2018-10-23 04:18:03.000000000","message":"nit: Add :param plugin: ...","commit_id":"ebd31089d537522221dd1d08f7dab8d0d5232fe1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ce36549bdee940fc6fe993bf870b39bd4a10fb39","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    \"\"\"Instantiate an os-vif VIF instance"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    :param vif: the nova.network.model.VIF instance"},{"line_number":252,"context_line":"    :param cls: class for a os_vif.objects.vif.VIFBase subclass"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    :returns: a os_vif.objects.vif.VIFBase instance"},{"line_number":255,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_1077b5a2","line":252,"in_reply_to":"3f79a3b5_58eb0fdc","updated":"2019-01-16 19:05:40.000000000","message":"+1, should add this if you respin.","commit_id":"ebd31089d537522221dd1d08f7dab8d0d5232fe1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"f29f60ad8171bfa228a76f0d3c2de91704f5423a","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    :param vif: the nova.network.model.VIF instance"},{"line_number":252,"context_line":"    :param cls: class for a os_vif.objects.vif.VIFBase subclass"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    :returns: a os_vif.objects.vif.VIFBase instance"},{"line_number":255,"context_line":"    \"\"\""},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_e4635219","line":253,"updated":"2019-01-25 15:22:37.000000000","message":"docstring?","commit_id":"c43ff8ac4bb35c76d94a9691feab293fb43bc9f7"}]}