)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"09c56cfac510d5b34d64e36765bbee8f825440b1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Warning, memory usage is 0 for \u003cinstance\u003e on baremetal node \u003cnode\u003e."},{"line_number":14,"context_line":"Warning, number of cpus is 0 for \u003cinstance\u003e on baremetal node \u003cnode\u003e."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As of the Rocky release [1], the standard compute resources (VCPU,"},{"line_number":17,"context_line":"MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes."},{"line_number":18,"context_line":"They were not required to be set since the Pike release, but still this"},{"line_number":19,"context_line":"warning is emitted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_78f14400","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":15},"updated":"2018-10-09 14:46:30.000000000","message":"This is actually wrong since [1] didn\u0027t merge until Stein.","commit_id":"3b35d1ca0af64dd4249a7da3701be75c8923622e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1d76395f2b2c93d3d52773e935e8c5218fd4f2d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Warning, memory usage is 0 for \u003cinstance\u003e on baremetal node \u003cnode\u003e."},{"line_number":14,"context_line":"Warning, number of cpus is 0 for \u003cinstance\u003e on baremetal node \u003cnode\u003e."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As of the Rocky release [1], the standard compute resources (VCPU,"},{"line_number":17,"context_line":"MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes."},{"line_number":18,"context_line":"They were not required to be set since the Pike release, but still this"},{"line_number":19,"context_line":"warning is emitted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_df64fe23","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":27},"updated":"2019-02-21 15:42:03.000000000","message":"This is wrong, that change landed in master (Stein) which makes me very hesitant to land this change in stable/rocky based on the (incorrect) presumption of how the code works in Rocky.","commit_id":"6dea38cb5828cb76294aa844a9ee52f8973cee16"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50d39c374b4534f8c57bd1940791341457daab20","unresolved":false,"context_lines":[{"line_number":903,"context_line":"            return hardware.InstanceInfo("},{"line_number":904,"context_line":"                state\u003dmap_power_state(ironic_states.NOSTATE))"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        properties \u003d self._parse_node_properties(node)"},{"line_number":907,"context_line":"        memory_kib \u003d properties[\u0027memory_mb\u0027] * 1024"},{"line_number":908,"context_line":"        if memory_kib \u003d\u003d 0:"},{"line_number":909,"context_line":"            LOG.warning(\"Warning, memory usage is 0 for \""},{"line_number":910,"context_line":"                        \"%(instance)s on baremetal node %(node)s.\","},{"line_number":911,"context_line":"                        {\u0027instance\u0027: instance.uuid,"},{"line_number":912,"context_line":"                         \u0027node\u0027: instance.node})"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        num_cpu \u003d properties[\u0027cpus\u0027]"},{"line_number":915,"context_line":"        if num_cpu \u003d\u003d 0:"},{"line_number":916,"context_line":"            LOG.warning(\"Warning, number of cpus is 0 for \""},{"line_number":917,"context_line":"                        \"%(instance)s on baremetal node %(node)s.\","},{"line_number":918,"context_line":"                        {\u0027instance\u0027: instance.uuid,"},{"line_number":919,"context_line":"                         \u0027node\u0027: instance.node})"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        return hardware.InstanceInfo(state\u003dmap_power_state(node.power_state))"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_fa3310f5","side":"PARENT","line":919,"range":{"start_line":906,"start_character":8,"end_line":919,"end_character":48},"updated":"2019-02-21 15:51:02.000000000","message":"So this depends on how the node is configured, correct? And in Rocky we still report standard resource class inventory *unless* https://docs.openstack.org/nova/rocky/configuration/config.html#workarounds.report_ironic_standard_resource_class_inventory is False - so it seems this should be conditional on the value of that configuration option because if you are reporting standard resource class inventory for the node then these warnings probably still apply, right?","commit_id":"cb65d3d69c2b36a1a18d3fe4347b445f17f6d856"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"041bb724e9463ab15f862c8c14faf760adeda726","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            for rc, field in [(rc_fields.ResourceClass.VCPU, \u0027vcpus\u0027),"},{"line_number":813,"context_line":"                              (rc_fields.ResourceClass.MEMORY_MB, \u0027memory_mb\u0027),"},{"line_number":814,"context_line":"                              (rc_fields.ResourceClass.DISK_GB, \u0027local_gb\u0027)]:"},{"line_number":815,"context_line":"                # NOTE(dtantsur): any of these fields can be zero starting with"},{"line_number":816,"context_line":"                # the Pike release."},{"line_number":817,"context_line":"                if info[field]:"},{"line_number":818,"context_line":"                    result[rc] \u003d {"},{"line_number":819,"context_line":"                        \u0027total\u0027: info[field],"},{"line_number":820,"context_line":"                        \u0027reserved\u0027: info[field] if reserved else 0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7acac0a1","line":817,"range":{"start_line":815,"start_character":16,"end_line":817,"end_character":31},"updated":"2019-02-21 15:58:09.000000000","message":"So here is where we don\u0027t report standard resource class inventory for vcpus, memory_mb or disk_gb if the node is reporting 0 for those values, regardless of report_ironic_standard_resource_class_inventory.","commit_id":"6dea38cb5828cb76294aa844a9ee52f8973cee16"}]}