)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a09e893c7ab1b26c8a674aaeaceb03ebabf14faa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allowes nova-compute to finish creating all currently spawning instances,"},{"line_number":10,"context_line":"when SIGTERM is sent to nova-compute process."},{"line_number":11,"context_line":"graceful_shutdown_timeout in nova.conf is set to 9000 - must set a bigger number in"},{"line_number":12,"context_line":"order to work."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1798326"},{"line_number":15,"context_line":"Change-Id: I706b21b9921001f45500ef18f970d70d561c1665"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_159fa6b4","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":14},"updated":"2019-01-25 09:10:15.000000000","message":"do you want to add this into reno as well?","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"bf745c3fd4dff6ae5ebdc1564213602f86801915","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allowes nova-compute to finish creating all currently spawning instances,"},{"line_number":10,"context_line":"when SIGTERM is sent to nova-compute process."},{"line_number":11,"context_line":"graceful_shutdown_timeout in nova.conf is set to 9000 - must set a bigger number in"},{"line_number":12,"context_line":"order to work."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1798326"},{"line_number":15,"context_line":"Change-Id: I706b21b9921001f45500ef18f970d70d561c1665"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_84904650","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"9fdfeff1_159fa6b4","updated":"2019-01-25 15:06:46.000000000","message":"Fixed provided in patch 6.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82f8d85b24c78aa737c9a810a4e522175a57d3a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementing graceful shutdown."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allowes nova-compute to finish creating all currently spawning instances,"},{"line_number":10,"context_line":"when SIGTERM is sent to nova-compute process."},{"line_number":11,"context_line":"graceful_shutdown_timeout in nova.conf is set to 9000 - must set a bigger number in"},{"line_number":12,"context_line":"order to work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_3e5082d4","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":12},"updated":"2019-01-27 13:01:02.000000000","message":"allows","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82f8d85b24c78aa737c9a810a4e522175a57d3a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allowes nova-compute to finish creating all currently spawning instances,"},{"line_number":10,"context_line":"when SIGTERM is sent to nova-compute process."},{"line_number":11,"context_line":"graceful_shutdown_timeout in nova.conf is set to 9000 - must set a bigger number in"},{"line_number":12,"context_line":"order to work."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1798326"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_3e7c02b4","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2019-01-27 13:01:02.000000000","message":"I see no change to the default value of this option (60) in this patch?","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"e66a655d4e8db5b155d0fdd33f4d7b4d55249559","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allowes nova-compute to finish creating all currently spawning instances,"},{"line_number":10,"context_line":"when SIGTERM is sent to nova-compute process."},{"line_number":11,"context_line":"graceful_shutdown_timeout in nova.conf is set to 9000 - must set a bigger number in"},{"line_number":12,"context_line":"order to work."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1798326"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_78b436f3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"9fdfeff1_3e7c02b4","updated":"2019-06-18 08:04:46.000000000","message":"I will updated the default value","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5acb2ee1d566880c63145170a974dc0501493196","unresolved":false,"context_lines":[{"line_number":1856,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1857,"context_line":"        # want to tie up RPC workers."},{"line_number":1858,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1859,"context_line":"                           context, instance, image, request_spec,"},{"line_number":1860,"context_line":"                           filter_properties, admin_password, injected_files,"},{"line_number":1861,"context_line":"                           requested_networks, security_groups,"},{"line_number":1862,"context_line":"                           block_device_mapping, node, limits, host_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f1c85f77","line":1859,"updated":"2018-10-17 13:38:17.000000000","message":"why this change?","commit_id":"ab6ed7481fd39c2867d29b8aed7fa3f9653f8fc2"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"f5c885bd46e92956b265b39f98b71552d3d4c9b9","unresolved":false,"context_lines":[{"line_number":1856,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1857,"context_line":"        # want to tie up RPC workers."},{"line_number":1858,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1859,"context_line":"                           context, instance, image, request_spec,"},{"line_number":1860,"context_line":"                           filter_properties, admin_password, injected_files,"},{"line_number":1861,"context_line":"                           requested_networks, security_groups,"},{"line_number":1862,"context_line":"                           block_device_mapping, node, limits, host_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b152e735","line":1859,"in_reply_to":"3f79a3b5_f1c85f77","updated":"2018-10-17 13:55:14.000000000","message":"This is reverted - I applied new patch.","commit_id":"ab6ed7481fd39c2867d29b8aed7fa3f9653f8fc2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"13b1db205e328991007f7ca729b4f7a7f6fd3571","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1855,"context_line":"        # want to tie up RPC workers."},{"line_number":1856,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1857,"context_line":"                       context, instance, image, request_spec,"},{"line_number":1858,"context_line":"                       filter_properties, admin_password, injected_files,"},{"line_number":1859,"context_line":"                       requested_networks, security_groups,"},{"line_number":1860,"context_line":"                       block_device_mapping, node, limits, host_list)"},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"    def _delete_allocation_for_instance(self, context, instance_uuid):"},{"line_number":1863,"context_line":"        rt \u003d self._get_resource_tracker()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_5e8909c5","line":1860,"range":{"start_line":1857,"start_character":23,"end_line":1860,"end_character":69},"updated":"2018-10-18 11:23:08.000000000","message":"seems unrelated changes.","commit_id":"10dc2bfa0679f19c1a96628cad750e66d9b81c00"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"a926f467eb36fb699e6926ac9cb302c28cd78aef","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1855,"context_line":"        # want to tie up RPC workers."},{"line_number":1856,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1857,"context_line":"                       context, instance, image, request_spec,"},{"line_number":1858,"context_line":"                       filter_properties, admin_password, injected_files,"},{"line_number":1859,"context_line":"                       requested_networks, security_groups,"},{"line_number":1860,"context_line":"                       block_device_mapping, node, limits, host_list)"},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"    def _delete_allocation_for_instance(self, context, instance_uuid):"},{"line_number":1863,"context_line":"        rt \u003d self._get_resource_tracker()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fe457573","line":1860,"range":{"start_line":1857,"start_character":23,"end_line":1860,"end_character":69},"in_reply_to":"3f79a3b5_5e8909c5","updated":"2018-10-18 11:28:33.000000000","message":"It\u0027s a fix from the previous patch.","commit_id":"10dc2bfa0679f19c1a96628cad750e66d9b81c00"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"a5e8863e21aeb877f46fd3a6e76e533428f19fd6","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"                self._update_scheduler_instance_info(context, instances)"},{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"    def cleanup_host(self):"},{"line_number":1228,"context_line":"        if utils.InstancePoolHolder.instance_spawning_pool.running() \u003e 0:"},{"line_number":1229,"context_line":"            utils.InstancePoolHolder.instance_spawning_pool.waitall()"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        self.driver.register_event_listener(None)"},{"line_number":1232,"context_line":"        self.instance_events.cancel_all_events()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_f181d74b","line":1229,"range":{"start_line":1228,"start_character":8,"end_line":1229,"end_character":69},"updated":"2019-01-25 08:11:30.000000000","message":"This is executed after self.rpcserver.stop(). Will the spawning task get failed caused by RPC connect error?","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"4ca6cc048c4eda02217376d19ed80837680d0c02","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"                self._update_scheduler_instance_info(context, instances)"},{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"    def cleanup_host(self):"},{"line_number":1228,"context_line":"        if utils.InstancePoolHolder.instance_spawning_pool.running() \u003e 0:"},{"line_number":1229,"context_line":"            utils.InstancePoolHolder.instance_spawning_pool.waitall()"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        self.driver.register_event_listener(None)"},{"line_number":1232,"context_line":"        self.instance_events.cancel_all_events()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_f19c775e","line":1229,"range":{"start_line":1228,"start_character":8,"end_line":1229,"end_character":69},"in_reply_to":"9fdfeff1_f181d74b","updated":"2019-01-25 08:35:52.000000000","message":"I have changed the implementation not the order of execution - I mean this is executed here as before my change - cleanup_host is called after rpc stop. What do you see here as an issue?","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"5a0b0f27f5bb9fd56e802f22506124b28b63ef97","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"                self._update_scheduler_instance_info(context, instances)"},{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"    def cleanup_host(self):"},{"line_number":1228,"context_line":"        if utils.InstancePoolHolder.instance_spawning_pool.running() \u003e 0:"},{"line_number":1229,"context_line":"            utils.InstancePoolHolder.instance_spawning_pool.waitall()"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        self.driver.register_event_listener(None)"},{"line_number":1232,"context_line":"        self.instance_events.cancel_all_events()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_e84f9c8f","line":1229,"range":{"start_line":1228,"start_character":8,"end_line":1229,"end_character":69},"in_reply_to":"9fdfeff1_f19c775e","updated":"2019-01-26 02:47:41.000000000","message":"I mean while waiting for greenthread to finish its work, if the rpc_server is stoped, how the greenthread to save database which through nova-conductor?","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"a5e8863e21aeb877f46fd3a6e76e533428f19fd6","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1855,"context_line":"        # want to tie up RPC workers."},{"line_number":1856,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1857,"context_line":"                       context, instance, image, request_spec,"},{"line_number":1858,"context_line":"                       filter_properties, admin_password, injected_files,"},{"line_number":1859,"context_line":"                       requested_networks, security_groups,"},{"line_number":1860,"context_line":"                       block_device_mapping, node, limits, host_list)"},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"    def _delete_allocation_for_instance(self, context, instance_uuid):"},{"line_number":1863,"context_line":"        rt \u003d self._get_resource_tracker()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_d614c950","line":1860,"range":{"start_line":1857,"start_character":22,"end_line":1860,"end_character":25},"updated":"2019-01-25 08:11:30.000000000","message":"Don\u0027t need to change this.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"4ca6cc048c4eda02217376d19ed80837680d0c02","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"},{"line_number":1855,"context_line":"        # want to tie up RPC workers."},{"line_number":1856,"context_line":"        utils.spawn_n(_locked_do_build_and_run_instance,"},{"line_number":1857,"context_line":"                       context, instance, image, request_spec,"},{"line_number":1858,"context_line":"                       filter_properties, admin_password, injected_files,"},{"line_number":1859,"context_line":"                       requested_networks, security_groups,"},{"line_number":1860,"context_line":"                       block_device_mapping, node, limits, host_list)"},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"    def _delete_allocation_for_instance(self, context, instance_uuid):"},{"line_number":1863,"context_line":"        rt \u003d self._get_resource_tracker()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_71e2c731","line":1860,"range":{"start_line":1857,"start_character":22,"end_line":1860,"end_character":25},"in_reply_to":"9fdfeff1_d614c950","updated":"2019-01-25 08:35:52.000000000","message":"I suppose some formatting issue with my IDE thats it","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"}],"nova/conf/compute.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"13b1db205e328991007f7ca729b4f7a7f6fd3571","unresolved":false,"context_lines":[{"line_number":609,"context_line":"Possible values:"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_running_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9e7fa1bb","line":612,"range":{"start_line":612,"start_character":27,"end_line":612,"end_character":34},"updated":"2018-10-18 11:23:08.000000000","message":"spawning, running is misleading","commit_id":"10dc2bfa0679f19c1a96628cad750e66d9b81c00"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"a926f467eb36fb699e6926ac9cb302c28cd78aef","unresolved":false,"context_lines":[{"line_number":609,"context_line":"Possible values:"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_running_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7e1e4576","line":612,"range":{"start_line":612,"start_character":27,"end_line":612,"end_character":34},"in_reply_to":"3f79a3b5_9e7fa1bb","updated":"2018-10-18 11:28:33.000000000","message":"Ok I\u0027ll change it.","commit_id":"10dc2bfa0679f19c1a96628cad750e66d9b81c00"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a09e893c7ab1b26c8a674aaeaceb03ebabf14faa","unresolved":false,"context_lines":[{"line_number":609,"context_line":"Possible values:"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_spawning_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_f54d4272","line":612,"updated":"2019-01-25 09:10:15.000000000","message":"I believe you want a new line here","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"bf745c3fd4dff6ae5ebdc1564213602f86801915","unresolved":false,"context_lines":[{"line_number":609,"context_line":"Possible values:"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_spawning_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_a4ab0a87","line":612,"in_reply_to":"9fdfeff1_f54d4272","updated":"2019-01-25 15:06:46.000000000","message":"Fixed provided in patch 6.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"200ea87bc63173f64abe0ca67f54d21fab46f4f0","unresolved":false,"context_lines":[{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_spawning_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."},{"line_number":616,"context_line":"Possible values:"},{"line_number":617,"context_line":"* Any positive integer representing greenthreads count."}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_d55a7e28","line":614,"updated":"2019-01-25 09:07:26.000000000","message":"Add a \u0027min\u0027 (minimum) setting.\n\ne.g. min\u003d1","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"bf745c3fd4dff6ae5ebdc1564213602f86801915","unresolved":false,"context_lines":[{"line_number":611,"context_line":"* Any positive integer representing greenthreads count."},{"line_number":612,"context_line":"\"\"\"), cfg.IntOpt(\u0027instance_spawning_pool_size\u0027,"},{"line_number":613,"context_line":"        default\u003d1000,"},{"line_number":614,"context_line":"        help\u003d\"\"\""},{"line_number":615,"context_line":"Number of greenthreads available for spawning virtual machines."},{"line_number":616,"context_line":"Possible values:"},{"line_number":617,"context_line":"* Any positive integer representing greenthreads count."}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_64952240","line":614,"in_reply_to":"9fdfeff1_d55a7e28","updated":"2019-01-25 15:06:46.000000000","message":"Fixed provided in patch 6.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"}],"nova/tests/unit/test_utils.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"91574b7bf89c0ae25e07b350ebdcf841600ec76b","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"        def fake(arg):"},{"line_number":1065,"context_line":"            pass"},{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"        with mock.patch.object(eventlet, \u0027GreenPool\u0027, _fake_spawn):"},{"line_number":1068,"context_line":"            getattr(utils, self.spawn_name)(fake, \u0027test\u0027)"},{"line_number":1069,"context_line":"        self.assertIsNone(common_context.get_current())"},{"line_number":1070,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_75ddd26e","line":1067,"range":{"start_line":1067,"start_character":8,"end_line":1067,"end_character":67},"updated":"2019-01-25 09:14:36.000000000","message":"why don\u0027t you just change the self.spawn_name? since you changed all the places that used it","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"189e7817d8dc0da55c50d106bf94c4405174ff05","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"        def fake(arg):"},{"line_number":1065,"context_line":"            pass"},{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"        with mock.patch.object(eventlet, \u0027GreenPool\u0027, _fake_spawn):"},{"line_number":1068,"context_line":"            getattr(utils, self.spawn_name)(fake, \u0027test\u0027)"},{"line_number":1069,"context_line":"        self.assertIsNone(common_context.get_current())"},{"line_number":1070,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_1e7a6387","line":1067,"range":{"start_line":1067,"start_character":8,"end_line":1067,"end_character":67},"in_reply_to":"9fdfeff1_75ddd26e","updated":"2019-01-25 12:11:10.000000000","message":"Because we have to test the call of self.spawn_name which is equal to \u0027spawn_n\u0027 which is a function part of eventlet.GreenPool class. And before we were calling spawn_n directly on the eventlet. So thats why self.spawn_name must remain the same since only the object on which is called this method must be changed.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"}],"nova/utils.py":[{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"5a0b0f27f5bb9fd56e802f22506124b28b63ef97","unresolved":false,"context_lines":[{"line_number":803,"context_line":"            profiler.init(**profiler_info)"},{"line_number":804,"context_line":"        return func(*args, **kwargs)"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"    return eventlet.spawn(context_wrapper, *args, **kwargs)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"def spawn_n(func, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_48602802","line":806,"range":{"start_line":806,"start_character":4,"end_line":806,"end_character":59},"updated":"2019-01-26 02:47:41.000000000","message":"Do you need to change this to InstancePoolHolder.instance_spawning_pool?","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82f8d85b24c78aa737c9a810a4e522175a57d3a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    return cmd"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class InstancePoolHolder(object):"},{"line_number":111,"context_line":"    instance_spawning_pool \u003d eventlet.GreenPool("},{"line_number":112,"context_line":"        size\u003dCONF.instance_spawning_pool_size)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_9e464e7c","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":33},"updated":"2019-01-27 13:01:02.000000000","message":"did you make this class in order to avoid having a variable in the global scope?","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"e66a655d4e8db5b155d0fdd33f4d7b4d55249559","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    return cmd"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class InstancePoolHolder(object):"},{"line_number":111,"context_line":"    instance_spawning_pool \u003d eventlet.GreenPool("},{"line_number":112,"context_line":"        size\u003dCONF.instance_spawning_pool_size)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_ab5e6441","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":33},"in_reply_to":"9fdfeff1_9e464e7c","updated":"2019-06-18 08:04:46.000000000","message":"Yes","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82f8d85b24c78aa737c9a810a4e522175a57d3a","unresolved":false,"context_lines":[{"line_number":829,"context_line":"            profiler.init(**profiler_info)"},{"line_number":830,"context_line":"        func(*args, **kwargs)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    InstancePoolHolder.instance_spawning_pool.spawn_n("},{"line_number":833,"context_line":"        context_wrapper, *args, **kwargs)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"def is_none_string(val):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_be3eb2d7","line":833,"range":{"start_line":832,"start_character":4,"end_line":833,"end_character":41},"updated":"2019-01-27 13:01:02.000000000","message":"spawn_n is used in places other than the compute manager and for uses other than Instance spawning. I think it would be more appropriate to create a specific thread pool object inside the compute.manager.Manager object itself that can be used specifically for this graceful-shutdown purpose.","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"e66a655d4e8db5b155d0fdd33f4d7b4d55249559","unresolved":false,"context_lines":[{"line_number":829,"context_line":"            profiler.init(**profiler_info)"},{"line_number":830,"context_line":"        func(*args, **kwargs)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    InstancePoolHolder.instance_spawning_pool.spawn_n("},{"line_number":833,"context_line":"        context_wrapper, *args, **kwargs)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"def is_none_string(val):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_9b2564ae","line":833,"range":{"start_line":832,"start_character":4,"end_line":833,"end_character":41},"in_reply_to":"9fdfeff1_be3eb2d7","updated":"2019-06-18 08:04:46.000000000","message":"Yes, the thread pool I\u0027ll move inside the manager","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"}],"releasenotes/notes/bug-1798326-instance_spawning_pool_size-c69571df95fe22ac.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"200ea87bc63173f64abe0ca67f54d21fab46f4f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The [DEFAULT]/instance_spawning_pool_size sets the number of"},{"line_number":5,"context_line":"    greenthreads available in the eventlet.GreenPool for spawning"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fdfeff1_b557ba02","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2019-01-25 09:07:26.000000000","message":"The issue that this patch fixes should be mentioned or the link to bug report should be added.","commit_id":"765d9bea5963bddcc19edae428635dddd9c2ee83"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82f8d85b24c78aa737c9a810a4e522175a57d3a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The [DEFAULT]/instance_spawning_pool_size sets the number of"},{"line_number":5,"context_line":"    greenthreads available in the eventlet.GreenPool for spawning"},{"line_number":6,"context_line":"    virtual machines. ``graceful_shutdown_timeout`` in nova.conf"},{"line_number":7,"context_line":"    is set to 9000 - must set a bigger number in order to work."},{"line_number":8,"context_line":"    `Bug 1798326`_"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1798326: https://bugs.launchpad.net/nova/+bug/1798326"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_1e033eba","line":7,"range":{"start_line":6,"start_character":22,"end_line":7,"end_character":18},"updated":"2019-01-27 13:01:02.000000000","message":"this patch doesn\u0027t change the graceful_shutdown_timeout CONF option default...","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"b2487850b5c05102879e779acc9e68db9060c439","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The [DEFAULT]/instance_spawning_pool_size sets the number of"},{"line_number":5,"context_line":"    greenthreads available in the eventlet.GreenPool for spawning"},{"line_number":6,"context_line":"    virtual machines. ``graceful_shutdown_timeout`` in nova.conf"},{"line_number":7,"context_line":"    is set to 9000 - must set a bigger number in order to work."},{"line_number":8,"context_line":"    `Bug 1798326`_"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1798326: https://bugs.launchpad.net/nova/+bug/1798326"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_a7ee0b89","line":7,"range":{"start_line":6,"start_character":22,"end_line":7,"end_character":18},"in_reply_to":"9fdfeff1_1e033eba","updated":"2019-06-18 12:09:58.000000000","message":"I\u0027ll add the change in oslo_service project","commit_id":"7a2b04f5cfaaed798143ceb8ad236bf77ffbe5b8"}]}