)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7a94540d003e96d337f86ba5b9c3e4ad5e98f7d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Make use of the newer fixtures in oslo_db.sqlalchemy.test_fixtures"},{"line_number":10,"context_line":"which is what was intended to supersede fixtures"},{"line_number":11,"context_line":"in oslo_db.sqlalchemy.test_base."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icb88c13336fffb499083197ed864b8e4e45dc241"},{"line_number":14,"context_line":"Closes-Bug: #1797102"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b2b4891e","line":12,"updated":"2018-10-12 13:31:09.000000000","message":"So most of these changes are necessary due to https://github.com/openstack/oslo.db/commit/39c52cc7c998b361e35b9a64de2da21e01fefadd","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7a94540d003e96d337f86ba5b9c3e4ad5e98f7d","unresolved":false,"context_lines":[{"line_number":8832,"context_line":"        self.assertTrue(call_api())"},{"line_number":8833,"context_line":""},{"line_number":8834,"context_line":""},{"line_number":8835,"context_line":"class TestSqlalchemyTypesRepr("},{"line_number":8836,"context_line":"        test_fixtures.OpportunisticDBTestMixin, test.NoDBTestCase):"},{"line_number":8837,"context_line":""},{"line_number":8838,"context_line":"    def setUp(self):"},{"line_number":8839,"context_line":"        # NOTE(sdague): the oslo_db base test case completely"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_237cad20","line":8836,"range":{"start_line":8835,"start_character":0,"end_line":8836,"end_character":67},"updated":"2018-10-12 13:31:09.000000000","message":"Yeah, so we\u0027re still using the mixin, which is what was used in oslo.db\u0027s \u0027DbTestCase\u0027, and now setting \u0027self.engine\u0027 ourselves. We\u0027re not setting \u0027self.sessionmaker\u0027 because we don\u0027t use it, I guess\n\nhttps://github.com/openstack/oslo.db/blob/39c52cc7/oslo_db/tests/sqlalchemy/base.py#L35-L42\n\nHowever, we\u0027re now inheriting from our own base class, nova.test.NoDBTestCase, which is itself based on testtools.TestCase (via nova.test.TestCase) and not oslo_test.base.BaseTestCase. However, I don\u0027t see anything too big in the diff so I think we\u0027re good","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7a94540d003e96d337f86ba5b9c3e4ad5e98f7d","unresolved":false,"context_lines":[{"line_number":8836,"context_line":"        test_fixtures.OpportunisticDBTestMixin, test.NoDBTestCase):"},{"line_number":8837,"context_line":""},{"line_number":8838,"context_line":"    def setUp(self):"},{"line_number":8839,"context_line":"        # NOTE(sdague): the oslo_db base test case completely"},{"line_number":8840,"context_line":"        # invalidates our logging setup, we actually have to do that"},{"line_number":8841,"context_line":"        # before it is called to keep this from vomitting all over our"},{"line_number":8842,"context_line":"        # test output."},{"line_number":8843,"context_line":"        self.useFixture(nova_fixtures.StandardLogging())"},{"line_number":8844,"context_line":""},{"line_number":8845,"context_line":"        super(TestSqlalchemyTypesRepr, self).setUp()"},{"line_number":8846,"context_line":"        self.engine \u003d enginefacade.writer.get_engine()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9242ad3b","line":8843,"range":{"start_line":8839,"start_character":0,"end_line":8843,"end_character":56},"updated":"2018-10-12 13:31:09.000000000","message":"Is this still valid though?","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c2d26f3f3ac6b95064d97c95c751fee10e899d9a","unresolved":false,"context_lines":[{"line_number":8836,"context_line":"        test_fixtures.OpportunisticDBTestMixin, test.NoDBTestCase):"},{"line_number":8837,"context_line":""},{"line_number":8838,"context_line":"    def setUp(self):"},{"line_number":8839,"context_line":"        # NOTE(sdague): the oslo_db base test case completely"},{"line_number":8840,"context_line":"        # invalidates our logging setup, we actually have to do that"},{"line_number":8841,"context_line":"        # before it is called to keep this from vomitting all over our"},{"line_number":8842,"context_line":"        # test output."},{"line_number":8843,"context_line":"        self.useFixture(nova_fixtures.StandardLogging())"},{"line_number":8844,"context_line":""},{"line_number":8845,"context_line":"        super(TestSqlalchemyTypesRepr, self).setUp()"},{"line_number":8846,"context_line":"        self.engine \u003d enginefacade.writer.get_engine()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1e15eae7","line":8843,"range":{"start_line":8839,"start_character":0,"end_line":8843,"end_character":56},"in_reply_to":"3f79a3b5_9242ad3b","updated":"2018-11-29 11:10:15.000000000","message":"not sure but let\u0027s try to remove in separate patch and see if all logging is fine.","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7a94540d003e96d337f86ba5b9c3e4ad5e98f7d","unresolved":false,"context_lines":[{"line_number":8870,"context_line":"                self.assertEqual(addrs[idx][1], row.addr)"},{"line_number":8871,"context_line":""},{"line_number":8872,"context_line":""},{"line_number":8873,"context_line":"class TestMySQLSqlalchemyTypesRepr(TestSqlalchemyTypesRepr):"},{"line_number":8874,"context_line":"    FIXTURE \u003d test_fixtures.MySQLOpportunisticFixture"},{"line_number":8875,"context_line":""},{"line_number":8876,"context_line":""},{"line_number":8877,"context_line":"class TestPostgreSQLSqlalchemyTypesRepr(TestSqlalchemyTypesRepr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b249e92f","line":8874,"range":{"start_line":8873,"start_character":0,"end_line":8874,"end_character":53},"updated":"2018-10-12 13:31:09.000000000","message":"Yup, same thing\n\nhttps://github.com/openstack/oslo.db/blob/39c52cc7/oslo_db/tests/sqlalchemy/base.py#L48-L49","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7a94540d003e96d337f86ba5b9c3e4ad5e98f7d","unresolved":false,"context_lines":[{"line_number":8874,"context_line":"    FIXTURE \u003d test_fixtures.MySQLOpportunisticFixture"},{"line_number":8875,"context_line":""},{"line_number":8876,"context_line":""},{"line_number":8877,"context_line":"class TestPostgreSQLSqlalchemyTypesRepr(TestSqlalchemyTypesRepr):"},{"line_number":8878,"context_line":"    FIXTURE \u003d test_fixtures.PostgresqlOpportunisticFixture"},{"line_number":8879,"context_line":""},{"line_number":8880,"context_line":""},{"line_number":8881,"context_line":"class TestDBInstanceTags(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_726111a8","line":8878,"range":{"start_line":8877,"start_character":0,"end_line":8878,"end_character":58},"updated":"2018-10-12 13:31:09.000000000","message":"https://github.com/openstack/oslo.db/blob/39c52cc7/oslo_db/tests/sqlalchemy/base.py#L56-L57","commit_id":"79fdcef733df7f92ac408f4593815b38e90a3005"}]}