)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef54f9aa0e79334446e26c61a4555c58a3d36e36","unresolved":false,"context_lines":[{"line_number":10,"context_line":"libvirt driver will if the guest is gone during an evacuate,"},{"line_number":11,"context_line":"we\u0027ll get a NoneType error trying to unpack the return value"},{"line_number":12,"context_line":"from the driver. Instead, simply return as if the driver"},{"line_number":13,"context_line":"raised NotImplementedError."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I98a2785c07f7af02ad83650c72d9e1868290ece4"},{"line_number":16,"context_line":"Closes-Bug: #1796981"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f9f1ab6b","line":13,"updated":"2018-10-11 06:44:13.000000000","message":"Libvirt driver returning None seems like against the contract described in the doc of the nova.virt.driver.ComputeDriver.block_stats() function stub. So either we need to update the contract there as well, stating that None can be returned or need to fix the libvirt driver to follow the contract and not return None.","commit_id":"b3c5a31d432a41de91ebb4c7238cba90815f5a6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"884fd596975de7420e378891e6ebbd9d66cee0e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"libvirt driver will if the guest is gone during an evacuate,"},{"line_number":11,"context_line":"we\u0027ll get a NoneType error trying to unpack the return value"},{"line_number":12,"context_line":"from the driver. Instead, simply return as if the driver"},{"line_number":13,"context_line":"raised NotImplementedError."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I98a2785c07f7af02ad83650c72d9e1868290ece4"},{"line_number":16,"context_line":"Closes-Bug: #1796981"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0fdc2b6f","line":13,"in_reply_to":"3f79a3b5_f9f1ab6b","updated":"2018-10-12 21:29:16.000000000","message":"I\u0027ll update the docstring.","commit_id":"b3c5a31d432a41de91ebb4c7238cba90815f5a6e"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b2c7654660decf056262229e821ecf64624be2f","unresolved":false,"context_lines":[{"line_number":5550,"context_line":"            mp \u003d mp[5:]"},{"line_number":5551,"context_line":"        try:"},{"line_number":5552,"context_line":"            vol_stats \u003d self.driver.block_stats(instance, mp)"},{"line_number":5553,"context_line":"            if vol_stats is None:"},{"line_number":5554,"context_line":"                return"},{"line_number":5555,"context_line":"        except NotImplementedError:"},{"line_number":5556,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a8552ac4","line":5553,"range":{"start_line":5553,"start_character":12,"end_line":5553,"end_character":33},"updated":"2018-10-10 19:09:05.000000000","message":"Maybe this should be: \"if not vol_stats\" to handle an empty list.","commit_id":"b3c5a31d432a41de91ebb4c7238cba90815f5a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef54f9aa0e79334446e26c61a4555c58a3d36e36","unresolved":false,"context_lines":[{"line_number":5550,"context_line":"            mp \u003d mp[5:]"},{"line_number":5551,"context_line":"        try:"},{"line_number":5552,"context_line":"            vol_stats \u003d self.driver.block_stats(instance, mp)"},{"line_number":5553,"context_line":"            if vol_stats is None:"},{"line_number":5554,"context_line":"                return"},{"line_number":5555,"context_line":"        except NotImplementedError:"},{"line_number":5556,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f9968bef","line":5553,"range":{"start_line":5553,"start_character":12,"end_line":5553,"end_character":33},"in_reply_to":"3f79a3b5_a8552ac4","updated":"2018-10-11 06:44:13.000000000","message":"While [] would cause L5559 to blow the contract described in nova.virt.driver.ComputeDriver.block_stats() does not allow [] (or any other edge case value like False or collections.defaultbag(dict) ) to be returned by the implementations so I would not start preparing for those.","commit_id":"b3c5a31d432a41de91ebb4c7238cba90815f5a6e"}]}