)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"016b0ccbe16e2a88bb732386243448ceef5b55e6","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            if not is_new_compute_node:"},{"line_number":1257,"context_line":"                LOG.error(\"Skipping removal of allocations for deleted \""},{"line_number":1258,"context_line":"                          \"instances: %s\", e)"},{"line_number":1259,"context_line":"            return"},{"line_number":1260,"context_line":"        allocations \u003d pai.allocations"},{"line_number":1261,"context_line":"        if not allocations:"},{"line_number":1262,"context_line":"            # The main loop below would short-circuit anyway, but this saves us"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_87761892","line":1259,"range":{"start_line":1259,"start_character":12,"end_line":1259,"end_character":18},"updated":"2018-10-10 21:50:25.000000000","message":"Hmm, I guess arguably we shouldn\u0027t even call this method if is_new_compute_node is True...","commit_id":"e689988ee9aa58ed63e4a8833757430fa6127239"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bed7f1ddba9e2d85e3ba9fc307ee03ee1b77d359","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            if not is_new_compute_node:"},{"line_number":1257,"context_line":"                LOG.error(\"Skipping removal of allocations for deleted \""},{"line_number":1258,"context_line":"                          \"instances: %s\", e)"},{"line_number":1259,"context_line":"            return"},{"line_number":1260,"context_line":"        allocations \u003d pai.allocations"},{"line_number":1261,"context_line":"        if not allocations:"},{"line_number":1262,"context_line":"            # The main loop below would short-circuit anyway, but this saves us"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a73eb487","line":1259,"range":{"start_line":1259,"start_character":12,"end_line":1259,"end_character":18},"in_reply_to":"3f79a3b5_87761892","updated":"2018-10-10 21:57:32.000000000","message":"get_allocations_for_resource_provider stops making sense anyway with nested. But if we\u0027re looking for a backportable fix, then yeah, that would also work nicely.","commit_id":"e689988ee9aa58ed63e4a8833757430fa6127239"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4de13baca9b364c9302f8ca846047f00c14b1b52","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"            if not is_new_compute_node:"},{"line_number":1257,"context_line":"                LOG.error(\"Skipping removal of allocations for deleted \""},{"line_number":1258,"context_line":"                          \"instances: %s\", e)"},{"line_number":1259,"context_line":"            return"},{"line_number":1260,"context_line":"        allocations \u003d pai.allocations"},{"line_number":1261,"context_line":"        if not allocations:"},{"line_number":1262,"context_line":"            # The main loop below would short-circuit anyway, but this saves us"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_076688bd","line":1259,"range":{"start_line":1259,"start_character":12,"end_line":1259,"end_character":18},"in_reply_to":"3f79a3b5_a73eb487","updated":"2018-10-10 21:59:20.000000000","message":"This doesn\u0027t require a backport since the bug showed up in stein.","commit_id":"e689988ee9aa58ed63e4a8833757430fa6127239"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bed7f1ddba9e2d85e3ba9fc307ee03ee1b77d359","unresolved":false,"context_lines":[{"line_number":3068,"context_line":"        )"},{"line_number":3069,"context_line":"        rc.get_allocations_for_resource_provider \u003d mock.Mock("},{"line_number":3070,"context_line":"            side_effect\u003dside_effects)"},{"line_number":3071,"context_line":"        for index, _ in enumerate(side_effects):"},{"line_number":3072,"context_line":"            # The compute node is only new once..."},{"line_number":3073,"context_line":"            is_new_compute_node \u003d True if index \u003d\u003d 0 else False"},{"line_number":3074,"context_line":"            # If we didn\u0027t no op, this would blow up at \u0027ctx\u0027.elevated()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a77b1478","line":3071,"range":{"start_line":3071,"start_character":24,"end_line":3071,"end_character":33},"updated":"2018-10-10 21:57:32.000000000","message":"fancy","commit_id":"e689988ee9aa58ed63e4a8833757430fa6127239"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bed7f1ddba9e2d85e3ba9fc307ee03ee1b77d359","unresolved":false,"context_lines":[{"line_number":3070,"context_line":"            side_effect\u003dside_effects)"},{"line_number":3071,"context_line":"        for index, _ in enumerate(side_effects):"},{"line_number":3072,"context_line":"            # The compute node is only new once..."},{"line_number":3073,"context_line":"            is_new_compute_node \u003d True if index \u003d\u003d 0 else False"},{"line_number":3074,"context_line":"            # If we didn\u0027t no op, this would blow up at \u0027ctx\u0027.elevated()"},{"line_number":3075,"context_line":"            self.rt._remove_deleted_instances_allocations("},{"line_number":3076,"context_line":"                \u0027ctx\u0027, cn, [], self.rt.tracked_instances,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_47d9e081","line":3073,"range":{"start_line":3073,"start_character":12,"end_line":3073,"end_character":63},"updated":"2018-10-10 21:57:32.000000000","message":"or\n\n is_new_compute_node \u003d index \u003d\u003d 0\n\nor\n\n is_new_compute_node \u003d True\n for _ in side_effects:\n     sef.rt._remove_deleted_instances_allocations(...)\n     is_new_compute_node \u003d False","commit_id":"e689988ee9aa58ed63e4a8833757430fa6127239"}]}