)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b7daa024c23a86c9efc4af50c88db33ba704ade7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: OVA and StrOpt images as VM templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Optimize instance creation by keeping images as VM templates per"},{"line_number":10,"context_line":"datastore."},{"line_number":11,"context_line":"So far instance creation from image worked as follows:"},{"line_number":12,"context_line":"- Import image as VM, cache the VM disk, and unregister VM."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_5ce0f796","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":26},"updated":"2019-01-16 22:08:15.000000000","message":"What are we optimizing here?","commit_id":"a827ef911d25569b0b055d791bc5ad1f00049792"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"d316d644f929e97df081926b4474f7daed2292b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: OVA and StrOpt images as VM templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Optimize instance creation by keeping images as VM templates per"},{"line_number":10,"context_line":"datastore."},{"line_number":11,"context_line":"So far instance creation from image worked as follows:"},{"line_number":12,"context_line":"- Import image as VM, cache the VM disk, and unregister VM."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_91a5dd06","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":26},"in_reply_to":"bfdaf3ff_5ce0f796","updated":"2019-01-17 10:09:37.000000000","message":"Keeping the imported VM as template spare us importing it anew the next time a VM from that same image is requested.\nThe benefit from keeping the templates per datastore is that the instance VM is created by cloning template which is on the same datastore.","commit_id":"a827ef911d25569b0b055d791bc5ad1f00049792"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b7daa024c23a86c9efc4af50c88db33ba704ade7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Create actual (instance) VM anew using the cached disk."},{"line_number":14,"context_line":"The current implementation changes this as follows:"},{"line_number":15,"context_line":"- Import image as VM (per datastore) and mark that VM as template."},{"line_number":16,"context_line":"- Create actual (instance) VM by cloning the template VM for the image."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6d51f35089888345f110dabda474e4274f12bd46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_5cf9d74a","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":56},"updated":"2019-01-16 22:08:15.000000000","message":"Currently we support linked cloning. Does that work with the new implementation?","commit_id":"a827ef911d25569b0b055d791bc5ad1f00049792"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"d316d644f929e97df081926b4474f7daed2292b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Create actual (instance) VM anew using the cached disk."},{"line_number":14,"context_line":"The current implementation changes this as follows:"},{"line_number":15,"context_line":"- Import image as VM (per datastore) and mark that VM as template."},{"line_number":16,"context_line":"- Create actual (instance) VM by cloning the template VM for the image."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6d51f35089888345f110dabda474e4274f12bd46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_d18fe520","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":56},"in_reply_to":"bfdaf3ff_5cf9d74a","updated":"2019-01-17 10:09:37.000000000","message":"What do you mean? What are your concerns?","commit_id":"a827ef911d25569b0b055d791bc5ad1f00049792"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1337fadccff4a1b99a6d1238cd8cb230d29e1203","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    config_spec.extraConfig \u003d extra_config"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    append_vif_infos_to_config_spec(client_factory, config_spec, vif_infos,"},{"line_number":280,"context_line":"                                    vif_limits\u003dextra_specs.vif_limits)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    # Set the VM to be \u0027managed\u0027 by \u0027OpenStack\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3e3f86e0","line":279,"updated":"2018-10-17 13:30:05.000000000","message":"you could do this change in a separate patch to make the review process a little easier","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"94a69a4386ba47008687e378998bb155876740f8","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    config_spec.extraConfig \u003d extra_config"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    append_vif_infos_to_config_spec(client_factory, config_spec, vif_infos,"},{"line_number":280,"context_line":"                                    vif_limits\u003dextra_specs.vif_limits)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    # Set the VM to be \u0027managed\u0027 by \u0027OpenStack\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e5057210","line":279,"in_reply_to":"3f79a3b5_3e3f86e0","updated":"2018-10-24 10:23:47.000000000","message":"Done","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1337fadccff4a1b99a6d1238cd8cb230d29e1203","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        inventoryPath\u003dinv_path)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"def mark_vm_as_template(session, vm_ref):"},{"line_number":1688,"context_line":"    \"\"\"Mark a VM instance as template. Assumes VM is powered off.\"\"\""},{"line_number":1689,"context_line":"    try:"},{"line_number":1690,"context_line":"        LOG.debug(\"Marking the VM as template %s\", vm_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1e564a2d","line":1687,"updated":"2018-10-17 13:30:05.000000000","message":"can you pass the instance here so that the logging can have context?","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"6b9ba28ac54273fcb1f7efd35829c964561fdf66","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        inventoryPath\u003dinv_path)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"def mark_vm_as_template(session, vm_ref):"},{"line_number":1688,"context_line":"    \"\"\"Mark a VM instance as template. Assumes VM is powered off.\"\"\""},{"line_number":1689,"context_line":"    try:"},{"line_number":1690,"context_line":"        LOG.debug(\"Marking the VM as template %s\", vm_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4ad63c29","line":1687,"in_reply_to":"3f79a3b5_1e564a2d","updated":"2018-10-17 15:23:19.000000000","message":"Done","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1337fadccff4a1b99a6d1238cd8cb230d29e1203","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                                                 profile_spec\u003dprofile_spec,"},{"line_number":329,"context_line":"                                                 metadata\u003dmetadata)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        folder \u003d self._get_project_folder(dc_info,"},{"line_number":332,"context_line":"                                          project_id\u003dinstance.project_id,"},{"line_number":333,"context_line":"                                          type_\u003d\u0027Instances\u0027)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_5e128263","line":331,"updated":"2018-10-17 13:30:05.000000000","message":"this can be split into a separate patch","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"94a69a4386ba47008687e378998bb155876740f8","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                                                 profile_spec\u003dprofile_spec,"},{"line_number":329,"context_line":"                                                 metadata\u003dmetadata)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        folder \u003d self._get_project_folder(dc_info,"},{"line_number":332,"context_line":"                                          project_id\u003dinstance.project_id,"},{"line_number":333,"context_line":"                                          type_\u003d\u0027Instances\u0027)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a50bfa1f","line":331,"in_reply_to":"3f79a3b5_5e128263","updated":"2018-10-24 10:23:47.000000000","message":"Done","commit_id":"ab573e26bec24a05eabf0730ae01f3a9ae5f225c"}]}