)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07eb639ed95bf18ec7c99b61e027547c841c5405","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  limitations of doing so,"},{"line_number":15,"context_line":"* bump the heading level of \"Guest agent support\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch differs from the version in Stein (and the clean"},{"line_number":18,"context_line":"cherry-pick into Rocky) in that it omits mentioning the option of"},{"line_number":19,"context_line":"enabling the vmx flag via cpu_model_extra_flags. The rationale for"},{"line_number":20,"context_line":"that is that vmx is not a supported option in stable/queens at the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_bcfb43bc","line":17,"updated":"2019-02-21 18:01:03.000000000","message":"Well, this section was omitted:\n\nhttps://review.openstack.org/#/c/609789/4/doc/source/admin/configuration/hypervisor-kvm.rst@357\n\nAnd doesn\u0027t mention anything about vmx, and since the cpu_model_extra_flags option is in queens couldn\u0027t we include that section?\n\nIt seems the vmx part you\u0027re talking about being omitted is this:\n\nhttps://review.openstack.org/#/c/609789/4/doc/source/admin/configuration/hypervisor-kvm.rst@433","commit_id":"9d53413b4ecea9ff948af9862f1d6966c4c7c304"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"cd4e2b2a8f4e78e71298dc4d1ba2fbf51dcb4ada","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  limitations of doing so,"},{"line_number":15,"context_line":"* bump the heading level of \"Guest agent support\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch differs from the version in Stein (and the clean"},{"line_number":18,"context_line":"cherry-pick into Rocky) in that it omits mentioning the option of"},{"line_number":19,"context_line":"enabling the vmx flag via cpu_model_extra_flags. The rationale for"},{"line_number":20,"context_line":"that is that vmx is not a supported option in stable/queens at the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_a016dcf0","line":17,"in_reply_to":"9fdfeff1_bcfb43bc","updated":"2019-10-21 20:58:22.000000000","message":"I\u0027ve reinstated the deleted section.","commit_id":"9d53413b4ecea9ff948af9862f1d6966c4c7c304"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"18a9b52a1675f21a69f30155ed234f452c293892","unresolved":false,"context_lines":[{"line_number":29,"context_line":"for cpu_model_extra_flags, regardless of the cpu_model being used,"},{"line_number":30,"context_line":"because (again at the time of writing) none of the CPU models defined"},{"line_number":31,"context_line":"in libvirt do enable the vmx flag automatically."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: 1791678"},{"line_number":34,"context_line":"Change-Id: I671acd16c7e5eca01b0bd633caf8e58287d0a913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_68b9e2c9","line":32,"updated":"2019-10-17 09:32:25.000000000","message":"If I was pedantic, I\u0027d still appreciate some mention of the cherry-picked SHA1, even if the patch differs from the original.","commit_id":"9d53413b4ecea9ff948af9862f1d6966c4c7c304"},{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"cd4e2b2a8f4e78e71298dc4d1ba2fbf51dcb4ada","unresolved":false,"context_lines":[{"line_number":29,"context_line":"for cpu_model_extra_flags, regardless of the cpu_model being used,"},{"line_number":30,"context_line":"because (again at the time of writing) none of the CPU models defined"},{"line_number":31,"context_line":"in libvirt do enable the vmx flag automatically."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: 1791678"},{"line_number":34,"context_line":"Change-Id: I671acd16c7e5eca01b0bd633caf8e58287d0a913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_20e0acfa","line":32,"in_reply_to":"3fa7e38b_68b9e2c9","updated":"2019-10-21 20:58:22.000000000","message":"Mentioned in updated commit message.","commit_id":"9d53413b4ecea9ff948af9862f1d6966c4c7c304"}],"doc/source/admin/configuration/hypervisor-kvm.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d403c50a4ce0b15ce4796b83acc635816ae63bf3","unresolved":false,"context_lines":[{"line_number":351,"context_line":"If your ``nova.conf`` file contains ``cpu_mode\u003dnone``, libvirt does not specify"},{"line_number":352,"context_line":"a CPU model. Instead, the hypervisor chooses the default model."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Set CPU feature flags"},{"line_number":355,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"Regardless of whether your selected ``cpu_mode`` is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_5826dbbc","line":354,"updated":"2019-10-23 15:40:00.000000000","message":"OK this is the new thing for PS9 and matches what\u0027s in rocky:\n\nhttps://review.opendev.org/#/c/609789/4/doc/source/admin/configuration/hypervisor-kvm.rst@357","commit_id":"4055261eba3c04f0eab9d754cce822db92f492ca"}]}
