)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4b64a22a0e3080729a1f8a372afe991d7ca50fe9","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            # NOTE(mriedem): Don\u0027t persist retries or requested_destination"},{"line_number":562,"context_line":"            # since those are per-request"},{"line_number":563,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027):"},{"line_number":564,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":565,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":566,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":567,"context_line":"            # no need for it after scheduling"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3d3da5bb","line":564,"range":{"start_line":564,"start_character":40,"end_line":564,"end_character":63},"updated":"2018-10-12 16:13:45.000000000","message":"This is probably not necessary here or in the original version I think, but doesn\u0027t hurt I guess. Unless maybe it was trying to avoid explicit dirtying or something?","commit_id":"c17bf9cbf2d8136ac37293e5bb420fd203c0f82a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a80e24b76c43ea9b2f63f21475a4d822b070f4de","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            # NOTE(mriedem): Don\u0027t persist retries or requested_destination"},{"line_number":562,"context_line":"            # since those are per-request"},{"line_number":563,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027):"},{"line_number":564,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":565,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":566,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":567,"context_line":"            # no need for it after scheduling"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_347a9a24","line":564,"range":{"start_line":564,"start_character":40,"end_line":564,"end_character":63},"in_reply_to":"3f79a3b5_3d3da5bb","updated":"2018-10-12 20:45:40.000000000","message":"Don\u0027t know, but that\u0027s what it was in the original.","commit_id":"c17bf9cbf2d8136ac37293e5bb420fd203c0f82a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4a787b0479d6dd042422102bffdc73ca2167e835","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            # since those are per-request"},{"line_number":563,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027):"},{"line_number":564,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":565,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":566,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":567,"context_line":"            # no need for it after scheduling"},{"line_number":568,"context_line":"            if \u0027network_metadata\u0027 in spec and spec.network_metadata:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1404e918","line":565,"updated":"2018-10-17 14:31:02.000000000","message":"We also reset other fields somewhere else, but this method prevents the DB field to be read anyway. Maybe we should consider later to do the same for \u0027force_hosts\u0027 and \u0027force_nodes\u0027 fields and drop the explicit call to reset_forced_destinations()","commit_id":"ce3af5e33ae6843411e611e81c6ca1c21e0f1e09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7e99e8ab0b6b93c98e5c43226083163365eafdd","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            # since those are per-request"},{"line_number":563,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027):"},{"line_number":564,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":565,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":566,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"},{"line_number":567,"context_line":"            # no need for it after scheduling"},{"line_number":568,"context_line":"            if \u0027network_metadata\u0027 in spec and spec.network_metadata:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b641470b","line":565,"in_reply_to":"3f79a3b5_1404e918","updated":"2018-10-19 12:56:28.000000000","message":"I don\u0027t want to deal with that in this change since this needs to be backported. I agree it would be nice to not have to whack all of the moles in so many different places, but that\u0027s going to require more thought.","commit_id":"ce3af5e33ae6843411e611e81c6ca1c21e0f1e09"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4a787b0479d6dd042422102bffdc73ca2167e835","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.force_nodes \u003d None"},{"line_number":640,"context_line":"        # NOTE(sbauza): Make sure we don\u0027t persist this, we need to keep the"},{"line_number":641,"context_line":"        # original request for the forced hosts"},{"line_number":642,"context_line":"        self.obj_reset_changes([\u0027force_hosts\u0027, \u0027force_nodes\u0027])"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"# NOTE(sbauza): Since verifying a huge list of instances can be a performance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8ff8e618","line":642,"updated":"2018-10-17 14:31:02.000000000","message":"I\u0027m talking of this.","commit_id":"ce3af5e33ae6843411e611e81c6ca1c21e0f1e09"}],"nova/tests/unit/objects/test_request_spec.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fc03f1a1091dc0f14652f04a30c511f73e521b47","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertIsNone(serialized_obj.instance_group.members)"},{"line_number":595,"context_line":"        self.assertIsNone(serialized_obj.instance_group.hosts)"},{"line_number":596,"context_line":"        self.assertIsNone(serialized_obj.retry)"},{"line_number":597,"context_line":"        self.assertIsNone(serialized_obj.requested_destination)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    def test_create(self):"},{"line_number":600,"context_line":"        req_obj \u003d fake_request_spec.fake_spec_obj(remove_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e728daee","line":597,"updated":"2018-10-15 14:48:29.000000000","message":"Sweet vindication :P","commit_id":"ce3af5e33ae6843411e611e81c6ca1c21e0f1e09"}]}