)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"change_message_id":"99f4d23df3c30c0a65459b5892bc60afef1a6d0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use a distionary to eliminate the inner loop in _choose_host_filters()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"it looks like an o(n²) algorithm, we can use a distionary to eliminate"},{"line_number":10,"context_line":"the inner loop."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I32747120ae1f2f1bc0a3810a03e0cd9baa7a8d2c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9kC4%3D","line":9,"updated":"2013-12-10 07:47:16.000000000","message":"nit: spelling mistake (dictionary)","commit_id":"cc85164316407165a7507bec815539ead23138ea"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"4dd3dbc499c2a796947b5287d5fd1ca1452ae11d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9iS0%3D","line":348,"updated":"2013-12-10 13:57:21.000000000","message":"Call me pedantic, but it seems like an else is a better form.  It\u0027s more understandable and less likely to break if we add things later to this function.","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"dcf8be37f415db3ac185f7b826c3e39822b4538b","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9fOk%3D","line":348,"in_reply_to":"AAAATn%2F9g1A%3D","updated":"2013-12-11 00:21:32.000000000","message":"Hi All,\nthis is Kevin L.Mitchell\u0027s idea. it\u0027s so good in my another patch, so i just move it here, thanks kevin for the job. thanks all for reviewing.","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"51ab3c6f02527b104e2db9431e1c52ea2bea350c","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9gtQ%3D","line":348,"in_reply_to":"AAAATn%2F9g1A%3D","updated":"2013-12-10 19:07:27.000000000","message":"I\u0027m not convinced, but I\u0027m going to remove my -1.  If it\u0027s modeled after other work, then that\u0027s reasonable reason for the style.","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"d27dd8bcd7fa75ca484c9796edd8a4e80a4a5a91","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9gnM%3D","line":348,"in_reply_to":"AAAATn%2F9gtQ%3D","updated":"2013-12-10 19:44:01.000000000","message":"Well actually that\u0027s arguing for a broken window, technically.\n\nBut I\u0027m not seeing any real issues with this statement, so I\u0027m going to say it\u0027s ok.","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1c4791c88fe3df05bd733985f2c7a2f44a93bf1b","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9g1A%3D","line":348,"in_reply_to":"AAAATn%2F9hsU%3D","updated":"2013-12-10 18:35:02.000000000","message":"I actually prefer the continue, as it makes this code easier to read if the else case ever gets bigger.","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"24f90a1be7c9bf63871e85bae97a1b5bec97f9aa","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        for filter_name in filter_cls_names:"},{"line_number":346,"context_line":"            if filter_name not in cls_map:"},{"line_number":347,"context_line":"                bad_filters.append(filter_name)"},{"line_number":348,"context_line":"                continue"},{"line_number":349,"context_line":"            good_filters.append(cls_map[filter_name])"},{"line_number":350,"context_line":"        if bad_filters:"},{"line_number":351,"context_line":"            msg \u003d \", \".join(bad_filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9hsU%3D","line":348,"in_reply_to":"AAAATn%2F9iS0%3D","updated":"2013-12-10 15:32:05.000000000","message":"For something this simple, you can go either way.  He\u0027s pulling this in from code I suggested for another patch, though, where he used a similar algorithm, so I suppose I\u0027m the one to blame :)","commit_id":"ff763b214a63363d3ee628607258c97bbf287f6c"}]}